Page MenuHomePhabricator
Create Task
Maniphest T188741

MCR Scheme change - Make rev_text_id DEFAULT 0
Closed, ResolvedPublic
Actions

Description

As discussed in https://gerrit.wikimedia.org/r/#/c/406595/14/includes/Storage/RevisionStore.php@473 rev_text_id currently has no default, so inserts will fail if no value is set.
After the MCR migration we don't want to have to worry about inserting anything into this field, but for now we will have to keep inserting 0.
A schema change adding a default will allow us to stop explicitly inserting this.

Details

SubjectRepoBranchLines +/-
Add default for revision.rev_text_id where missingmediawiki/coremaster+78 -2
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolveddanielT174024 Implement MCR revision retrieval interface
ResolvedAddshoreT188741 MCR Scheme change - Make rev_text_id DEFAULT 0
ResolvedMarosteguiT190148 Change DEFAULT 0 for rev_text_id on production DBs
· · ·

Event Timeline

Addshore created this task.Mar 2 2018, 3:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 2 2018, 3:29 PM
Addshore claimed this task.Mar 6 2018, 5:28 PM
Addshore moved this task from Inbox to Next on the Multi-Content-Revisions board.
Restricted Application added a project: User-Addshore. · View Herald TranscriptMar 6 2018, 5:28 PM
Addshore moved this task from Unsorted 💣 to Next on the User-Addshore board.Mar 6 2018, 5:28 PM
Addshore added a parent task: T174024: Implement MCR revision retrieval interface.
Addshore triaged this task as Medium priority.Mar 7 2018, 2:03 PM
gerritbot subscribed.Mar 12 2018, 4:21 PM

Change 418946 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/core@master] WIP DNM: Add default for revision.rev_text_id of 0

https://gerrit.wikimedia.org/r/418946

gerritbot added a project: Patch-For-Review.Mar 12 2018, 4:21 PM
Addshore moved this task from Next to Active 🚁 on the User-Addshore board.Mar 14 2018, 3:23 PM
gerritbot added a comment.Mar 19 2018, 8:14 PM

Change 418946 merged by jenkins-bot:
[mediawiki/core@master] Add default for revision.rev_text_id where missing

https://gerrit.wikimedia.org/r/418946

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)).Mar 19 2018, 9:00 PM
Addshore added a subtask: T190148: Change DEFAULT 0 for rev_text_id on production DBs.Mar 20 2018, 1:42 PM

Patch is merged and the ticket for the schema change on production has been created.

CCicalese_WMF moved this task from Next to In Progress on the Multi-Content-Revisions board.May 10 2018, 4:26 PM
Marostegui closed subtask T190148: Change DEFAULT 0 for rev_text_id on production DBs as Resolved.May 28 2018, 9:00 AM
Addshore closed this task as Resolved.Jun 6 2018, 8:50 AM

deployed everywhere now, so we can start assuming that it is present everywhere!

Addshore moved this task from Active 🚁 to Closing ✔️ on the User-Addshore board.Jun 6 2018, 8:51 AM
CCicalese_WMF moved this task from In Progress to Done on the Multi-Content-Revisions board.Jul 13 2018, 3:23 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits