Implement MCR revision retrieval interface
Closed, ResolvedPublic
Actions

Description

The revision retrieval interface allows all relevant information for a given page revision to be retrieved. The information provided must be sufficient to locate and load all content objects that belong to the revision (slots). Access to revision meta-data such as the edit comment is also covered by this ticket.

The functionality provided is roughly equivalent to the retrieve/read functionality offered by the Revision class. The Revision class should remain a thin layer on top of the new revision retrieval interface, as a legacy proxy.

Design draft: https://www.mediawiki.org/wiki/Multi-Content_Revisions/Revision_Retrieval
See also: Design draft: https://www.mediawiki.org/wiki/Multi-Content_Revisions/Content_Meta-Data

Details

Subject	Repo	Branch	Lines +/-
MCR RevisionStore, multi content mode..	mediawiki/core	master	+1 K -386
Fix undeletion write-both/read-old mode.	mediawiki/core	master	+171 -38
Prepare newNullRevision for MCR.	mediawiki/core	master	+29 -52
[MCR] RevisionStore, enable insertions for new schema	mediawiki/core	master	+747 -251
MCR: RevisionStore: test old and intermediate schema.	mediawiki/core	master	+1 K -544

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Resolved	daniel	T174023 Implement MCR storage layer
Resolved	daniel	T174038 Initial implementation of MCR page update interface
Resolved	daniel	T174024 Implement MCR revision retrieval interface
Resolved	daniel	T174025 Implement MCR revision retrieval legacy version
Resolved	Anomie	T166732 Refactor comment storage in the database and abstract access in MediaWiki
Resolved	daniel	T174028 Finalize database schema for MCR content meta-data
Resolved	Addshore	T188518 Implement Storage service for content models and slot roles
Resolved	daniel	T189004 replace slot_inherited with slot_origin
Resolved	Addshore	T188741 MCR Scheme change - Make rev_text_id DEFAULT 0
Resolved	Tgr	T187586 Installer fails in RevisionStore
Resolved	Tgr	T196653 Test MCR Storage Layer Patches
		· · ·

Event Timeline

daniel created this task.Aug 24 2017, 2:20 PM

daniel created subtask T174025: Implement MCR revision retrieval legacy version.

daniel created subtask T174026: Implement MCR content meta-data storage service.Aug 24 2017, 2:25 PM

daniel updated the task description. (Show Details)Aug 24 2017, 2:27 PM

daniel added subtasks: T166732: Refactor comment storage in the database and abstract access in MediaWiki, T161671: Compacting the revision table.Aug 24 2017, 2:29 PM

daniel created subtask T174030: Implement DB schema migration tools for MCR.Aug 24 2017, 2:34 PM

daniel updated the task description. (Show Details)Aug 24 2017, 2:53 PM

Anomie closed subtask T166732: Refactor comment storage in the database and abstract access in MediaWiki as Resolved.Sep 7 2017, 1:35 PM

CCicalese_WMF moved this task from Inbox to MWPT-Q2-Oct-Dec-2017 on the MediaWiki-Platform-Team-Archived board.Oct 13 2017, 6:50 PM

CCicalese_WMF edited projects, added MediaWiki-Platform-Team-Archived (MWPT-Q2-Oct-Dec-2017); removed MediaWiki-Platform-Team-Archived.

• Ramsey-WMF moved this task from Backlog to Continuous tasks / Epics on the SDC General board.Nov 17 2017, 5:37 PM

daniel added a project: Multi-Content-Revisions.Nov 20 2017, 7:33 PM

daniel moved this task from Inbox to Done on the Multi-Content-Revisions board.Nov 20 2017, 7:41 PM

daniel moved this task from Done to Inbox on the Multi-Content-Revisions board.

thiemowmde triaged this task as Medium priority.Dec 11 2017, 4:04 PM

Lydia_Pintscher moved this task from incoming to consider for next sprint on the Wikidata board.Dec 18 2017, 3:24 PM

Lydia_Pintscher moved this task from consider for next sprint to monitoring on the Wikidata board.

CCicalese_WMF moved this task from MWPT-Q2-Oct-Dec-2017 to MWPT-Q3-Jan-Mar-2018 on the MediaWiki-Platform-Team-Archived board.Dec 21 2017, 4:19 PM

CCicalese_WMF edited projects, added MediaWiki-Platform-Team-Archived (MWPT-Q3-Jan-Mar-2018); removed MediaWiki-Platform-Team-Archived (MWPT-Q2-Oct-Dec-2017).

daniel removed a subtask: T161671: Compacting the revision table.Dec 21 2017, 7:02 PM

daniel updated the task description. (Show Details)Jan 4 2018, 6:49 PM

daniel merged a task: T174026: Implement MCR content meta-data storage service.

daniel mentioned this in T174026: Implement MCR content meta-data storage service.

daniel added a subscriber: gerritbot.

daniel added a parent task: T174038: Initial implementation of MCR page update interface.Jan 4 2018, 6:51 PM

daniel removed a subtask: T174030: Implement DB schema migration tools for MCR.Jan 5 2018, 11:22 AM

daniel edited subtasks, added: T174028: Finalize database schema for MCR content meta-data ; removed: T174026: Implement MCR content meta-data storage service.

This is on our workboard and Q3 goal list but https://wikifarm.wmflabs.org/mcr/index.php/Main_Page has it assigned to Adam, I assume that is @Addshore. Is it OK to assign this task?

Yup!

Restricted Application added a project: User-Addshore. · View Herald TranscriptFeb 8 2018, 11:17 PM

Addshore moved this task from Inbox to Next on the Multi-Content-Revisions board.Feb 8 2018, 11:17 PM

cicalese moved this task from Ready to Watching on the MediaWiki-Platform-Team-Archived (MWPT-Q3-Jan-Mar-2018) board.Feb 11 2018, 11:03 PM

Addshore moved this task from Unsorted 💣 to Back Burner 🏛️ on the User-Addshore board.Feb 21 2018, 3:04 PM

Change 406595 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/core@master] WIP DNM [MCR] RevisionStore, enable insertions for new schema

https://gerrit.wikimedia.org/r/406595

gerritbot added a project: Patch-For-Review.Feb 28 2018, 3:28 PM

Addshore added a subtask: T188518: Implement Storage service for content models and slot roles.Mar 4 2018, 12:05 PM

Addshore closed subtask T188518: Implement Storage service for content models and slot roles as Resolved.

Addshore mentioned this in T183488: MCR schema migration stage 2: populate new fields.Mar 6 2018, 5:11 PM

Addshore added a subtask: T188741: MCR Scheme change - Make rev_text_id DEFAULT 0.Mar 6 2018, 5:29 PM

Abit subscribed.Mar 29 2018, 11:59 PM

CCicalese_WMF edited projects, added MediaWiki-Platform-Team-Archived (MWPT-Q4-Apr-Jun-2018); removed MediaWiki-Platform-Team-Archived (MWPT-Q3-Jan-Mar-2018).Apr 4 2018, 6:51 PM

CCicalese_WMF moved this task from Ready to Watching on the MediaWiki-Platform-Team-Archived (MWPT-Q4-Apr-Jun-2018) board.Apr 4 2018, 6:55 PM

Change 416465 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/core@master] WIP DNM RevisionStore, multi content mode..

https://gerrit.wikimedia.org/r/416465

CCicalese_WMF closed subtask T189004: replace slot_inherited with slot_origin as Resolved.Apr 19 2018, 4:53 PM

daniel closed subtask T174025: Implement MCR revision retrieval legacy version as Resolved.Apr 19 2018, 6:29 PM

daniel moved this task from Next to Done on the Multi-Content-Revisions board.May 7 2018, 10:38 AM

daniel claimed this task.May 7 2018, 10:50 AM

Change 422443 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] MCR: RevisionStore: test old and intermediate schema.

https://gerrit.wikimedia.org/r/422443

Change 425519 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] [MCR] [DNM] Set MCR migration stage to MIGRATION_WRITE_BOTH.

https://gerrit.wikimedia.org/r/425519

CCicalese_WMF moved this task from Done to MCR-SDC Storage Layer - phase 1 on the Multi-Content-Revisions board.May 8 2018, 12:55 PM

CCicalese_WMF edited projects, added Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1); removed Multi-Content-Revisions.

CCicalese_WMF moved this task from Backlog to In Progress on the Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1) board.May 8 2018, 1:07 PM

Change 432053 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Prepare newNullRevision for MCR.

https://gerrit.wikimedia.org/r/432053

Change 422443 abandoned by Daniel Kinzler:
MCR: RevisionStore: test old and intermediate schema.

Reason:
replaced by I239572f75bebbc9c731a3e3860c4eff179dc15e4

https://gerrit.wikimedia.org/r/422443

daniel mentioned this in T194729: Allow Wikibase Entities to be stored in alternative slots [MCR].May 15 2018, 8:38 AM

daniel added a subtask: T187586: Installer fails in RevisionStore.May 15 2018, 11:30 AM

CCicalese_WMF moved this task from In Progress to Blocked on Review on the Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1) board.May 31 2018, 5:19 PM

Addshore closed subtask T188741: MCR Scheme change - Make rev_text_id DEFAULT 0 as Resolved.Jun 6 2018, 8:50 AM

Addshore moved this task from Back Burner 🏛️ to Watching 👀 on the User-Addshore board.Jun 6 2018, 8:53 AM

CCicalese_WMF added a subtask: T196653: Test MCR Storage Layer Patches.Jun 7 2018, 4:46 PM

Change 406595 merged by jenkins-bot:
[mediawiki/core@master] [MCR] RevisionStore, enable insertions for new schema

https://gerrit.wikimedia.org/r/406595

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)).Jun 14 2018, 3:00 PM

Change 432053 merged by jenkins-bot:
[mediawiki/core@master] Prepare newNullRevision for MCR.

https://gerrit.wikimedia.org/r/432053

Change 416465 merged by jenkins-bot:
[mediawiki/core@master] MCR RevisionStore, multi content mode..

https://gerrit.wikimedia.org/r/416465

This is now implemented. Note however that the new features are still disabled per default.

At some point, we'll still have to change $wgMultiContentRevisionSchemaMigrationStage to MIGRATION_NEW.

daniel closed subtask T196653: Test MCR Storage Layer Patches as Resolved.Jun 14 2018, 3:59 PM

Krinkle mentioned this in T197271: PHPUnit fails on PHP 7.1 and HHVM 3.18 (1 failure: McrRevisionStoreDbTest).Jun 14 2018, 9:21 PM

CCicalese_WMF moved this task from Blocked on Review to Done on the Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1) board.Jun 15 2018, 3:35 AM

Addshore moved this task from Watching 👀 to Closing ✔️ on the User-Addshore board.Jun 15 2018, 7:32 AM

• Vvjjkkii reopened subtask T196653: Test MCR Storage Layer Patches as Open.Jul 1 2018, 1:05 AM

CommunityTechBot closed subtask T196653: Test MCR Storage Layer Patches as Resolved.Jul 2 2018, 1:29 PM

CCicalese_WMF removed a project: Patch-For-Review.Jul 10 2018, 3:24 AM

CCicalese_WMF removed a project: MediaWiki-Platform-Team-Archived (MWPT-Q4-Apr-Jun-2018).Jul 11 2018, 10:46 PM

Change 455630 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Fix undeletion write-both/read-old mode.

https://gerrit.wikimedia.org/r/455630

gerritbot added a project: Patch-For-Review.Aug 27 2018, 7:53 PM

Change 455630 merged by jenkins-bot:
[mediawiki/core@master] Fix undeletion write-both/read-old mode.