Page MenuHomePhabricator
Create Task
Maniphest T174025

Implement MCR revision retrieval legacy version
Closed, ResolvedPublic
Actions

Description

Implement the new MCR revision retrieval interface on top of the old database schema. Only the main slot is supported.

Details

SubjectRepoBranchLines +/-
MCR: Deprecate and gut Revision classmediawiki/coremaster+717 -1 K
Fix unexpected null return value in Revision::getCommentmediawiki/coremaster+1 -1
Fix documentation for Revision::getComment and WikiPage::getCommentmediawiki/coremaster+5 -6
Fix documentation for RevisionRecord::$mPageIdmediawiki/coremaster+1 -1
[MCR] Break Revision into RevisionRecord and RevisionStoremediawiki/coremaster+5 K -0
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolveddanielT174024 Implement MCR revision retrieval interface
OpenNoneT174032 Make relevant API modules aware of MCR
ResolveddanielT174025 Implement MCR revision retrieval legacy version
· · ·

Event Timeline

daniel created this task.Aug 24 2017, 2:21 PM
daniel updated the task description. (Show Details)Aug 24 2017, 2:55 PM
daniel renamed this task from Implement MCR revision retrieval legacy dummy to Implement MCR revision retrieval legacy version.Aug 24 2017, 4:19 PM
daniel claimed this task.Aug 24 2017, 4:24 PM
daniel moved this task from Inbox to Future on the MediaWiki-Platform-Team-Archived board.
CCicalese_WMF moved this task from Future to MWPT-Q1-Jul-Sep-2017 on the MediaWiki-Platform-Team-Archived board.Oct 13 2017, 6:26 PM
CCicalese_WMF edited projects, added MediaWiki-Platform-Team-Archived (MWPT-Q1-Jul-Sep-2017); removed MediaWiki-Platform-Team-Archived.
CCicalese_WMF moved this task from Ready to In Progress on the MediaWiki-Platform-Team-Archived (MWPT-Q1-Jul-Sep-2017) board.Oct 13 2017, 6:29 PM
CCicalese_WMF moved this task from MWPT-Q1-Jul-Sep-2017 to MWPT-Q2-Oct-Dec-2017 on the MediaWiki-Platform-Team-Archived board.Oct 19 2017, 9:31 PM
CCicalese_WMF edited projects, added MediaWiki-Platform-Team-Archived (MWPT-Q2-Oct-Dec-2017); removed MediaWiki-Platform-Team-Archived (MWPT-Q1-Jul-Sep-2017).
CCicalese_WMF moved this task from Ready to In Progress on the MediaWiki-Platform-Team-Archived (MWPT-Q2-Oct-Dec-2017) board.Oct 19 2017, 9:34 PM
• Ramsey-WMF moved this task from Backlog to Continuous tasks / Epics on the SDC General board.Nov 17 2017, 5:37 PM
daniel added a project: Multi-Content-Revisions.Nov 20 2017, 7:31 PM
daniel moved this task from Inbox to Done on the Multi-Content-Revisions board.Nov 20 2017, 7:41 PM
thiemowmde triaged this task as Medium priority.Dec 11 2017, 4:04 PM
gerritbot subscribed.Dec 14 2017, 10:50 PM

Change 374077 merged by jenkins-bot:
[mediawiki/core@master] [MCR] Break Revision into RevisionRecord and RevisionStore

https://gerrit.wikimedia.org/r/374077

Lydia_Pintscher moved this task from incoming to consider for next sprint on the Wikidata board.Dec 18 2017, 3:24 PM
Lydia_Pintscher moved this task from consider for next sprint to monitoring on the Wikidata board.
gerritbot added a comment.Dec 19 2017, 1:17 PM

Change 399174 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Deprecate and gut Revision class [DNM].

https://gerrit.wikimedia.org/r/399174

gerritbot added a project: Patch-For-Review.Dec 19 2017, 1:17 PM
CCicalese_WMF moved this task from MWPT-Q2-Oct-Dec-2017 to MWPT-Q3-Jan-Mar-2018 on the MediaWiki-Platform-Team-Archived board.Dec 21 2017, 4:20 PM
CCicalese_WMF edited projects, added MediaWiki-Platform-Team-Archived (MWPT-Q3-Jan-Mar-2018); removed MediaWiki-Platform-Team-Archived (MWPT-Q2-Oct-Dec-2017).
gerritbot added a comment.Dec 21 2017, 6:40 PM

Change 399174 merged by jenkins-bot:
[mediawiki/core@master] MCR: Deprecate and gut Revision class

https://gerrit.wikimedia.org/r/399174

daniel added a parent task: T174032: Make relevant API modules aware of MCR.Dec 21 2017, 7:01 PM
CCicalese_WMF moved this task from MWPT-Q3-Jan-Mar-2018 to Watching on the MediaWiki-Platform-Team-Archived board.Jan 2 2018, 4:05 PM
CCicalese_WMF edited projects, added MediaWiki-Platform-Team-Archived; removed MediaWiki-Platform-Team-Archived (MWPT-Q3-Jan-Mar-2018).
Abit subscribed.Mar 6 2018, 1:35 AM

@daniel, the MCR wiki shows this task as complete, but here it is still open. Which is correct?

daniel closed this task as Resolved.Apr 19 2018, 6:29 PM

It's done and deployed.

CCicalese_WMF moved this task from Watching to Closed on the MediaWiki-Platform-Team-Archived board.May 1 2018, 12:15 AM
CCicalese_WMF moved this task from Done to MCR-SDC Storage Layer - phase 1 on the Multi-Content-Revisions board.May 10 2018, 4:15 PM
CCicalese_WMF edited projects, added Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1); removed Multi-Content-Revisions.
CCicalese_WMF moved this task from Backlog to Done on the Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1) board.May 10 2018, 4:18 PM
CCicalese_WMF removed a project: Patch-For-Review.May 10 2018, 4:41 PM
Anomie mentioned this in T195692: Attempt to undelete page causes error: Fatal exception of type IncompleteRevisionException: user_text field must not be ''!.May 28 2018, 6:08 PM
gerritbot added a comment.Jan 9 2019, 3:58 PM

Change 483158 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/core@master] Fix unexpected null return value in Revision::getComment

https://gerrit.wikimedia.org/r/483158

gerritbot added a project: Patch-For-Review.Jan 9 2019, 3:58 PM
gerritbot added a comment.Jan 15 2019, 1:42 PM

Change 484424 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/core@master] Fix documentation for Revision::getComment and WikiPage::getComment

https://gerrit.wikimedia.org/r/484424

gerritbot added a comment.Jan 15 2019, 1:46 PM

Change 484425 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/core@master] Fix documentation for RevisionRecord::$mPageId

https://gerrit.wikimedia.org/r/484425

gerritbot added a comment.Jan 31 2019, 11:59 AM

Change 484425 merged by jenkins-bot:
[mediawiki/core@master] Fix documentation for RevisionRecord::$mPageId

https://gerrit.wikimedia.org/r/484425

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.16; 2019-02-05).Jan 31 2019, 12:00 PM
gerritbot added a comment.Feb 16 2019, 10:59 AM

Change 484424 merged by jenkins-bot:
[mediawiki/core@master] Fix documentation for Revision::getComment and WikiPage::getComment

https://gerrit.wikimedia.org/r/484424

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.18; 2019-02-19); removed MW-1.33-notes (1.33.0-wmf.16; 2019-02-05).Feb 16 2019, 11:00 AM
gerritbot added a comment.Feb 20 2019, 5:20 PM

Change 483158 abandoned by Thiemo Kreuz (WMDE):
Fix unexpected null return value in Revision::getComment

https://gerrit.wikimedia.org/r/483158

DannyS712 mentioned this in T246284: Hard deprecate the Revision class.Feb 26 2020, 8:02 PM
DannyS712 mentioned this in T249384: ParserOptions' currentRevisionCallback uses Revision objects.Apr 9 2020, 3:33 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL