Steps to reproduce:
- Open VE
- Make an edit
- Reload the editor with unsaved changes
- Click on "Publish Changes"
Observe that the labels for Minor edit and Watch page checkboxes are missing on the save page dialog.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Remember 'checkboxesMessages' when storing document state | mediawiki/extensions/VisualEditor | master | +2 -0 |
Related Objects
Related Objects
- Duplicates Merged Here
- T189394: watchthis displays key instead of message
Event Timeline
Comment Actions
Change 419955 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Remember 'checkboxesMessages' when storing document state
Comment Actions
Change 419955 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Remember 'checkboxesMessages' when storing document state
Comment Actions
Still present (on English Wikipedia, which is on wmf/1.31.0-wmf.26, which is shown to have that commit).
Changes were recovered in the editor.
But the change might have been saved before the fix (though it would be good to do at least 'watchthis' and 'minoredit' from core)
Comment Actions
@Mattflaschen-Personal Right, the text of the messages to use is saved in session storage, together with the document and changes to recover, so they would still be missing for changes autosaved before we the fix was deployed. This is a bit unfortunate, but since session storage (and autosaved changes) is cleared anyway when closing the browser tab/window, I think this has already become a non-issue after a few days have passed since the deployment.