Page MenuHomePhabricator
Create Task
Maniphest T188826

Old log actions do not appear when performer is specified
Closed, ResolvedPublic
Actions

Description

Log actions (such as deletions, protections, blocks, etc.) that were performed prior to 2009 do not appear on [[Special:Log]] when the user who has performed the action is specified.

To reproduce this issue:

  1. Go to [[Special:Log]] on any wiki.
  2. In the "Performer" box above, type a user name who performed any log action before 2009, and then click the "Show" button.
  3. Click the "oldest" link to see the oldest log entries. For some reason, the log does not show actions that were performed before 2009 (usually September 2009).

Details

SubjectRepoBranchLines +/-
Don't target log_user_text for registered usersmediawiki/coremaster+2 -6
Customize query in gerrit

Related Objects

Event Timeline

Guycn2 created this task.Mar 3 2018, 3:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 3 2018, 3:01 PM
IKhitron subscribed.Mar 3 2018, 3:26 PM
Schniggendiller subscribed.Mar 3 2018, 8:32 PM
Guycn2 updated the task description. (Show Details)Mar 3 2018, 9:49 PM
matmarex merged a task: T188996: unable to view logs by user in some cases.Mar 6 2018, 2:35 PM
matmarex added a subscriber: Graham87.
matmarex edited projects, added Regression, MediaWiki-Logevents; removed MediaWiki-General.Mar 6 2018, 2:42 PM
matmarex added subscribers: Anomie, matmarex.

This seems to be a regression from rMW27c61fb1e94d: Add `actor` table and code to start using it. Among other things, it changed the query generated by LogPager.php to always use the 'log_user_text' field for filtering (containing the username or IP), instead of 'log_user_text' for anonymous users and 'log_user' (containing user ID) for registered users. Unfortunately, some history digging reveals that the 'log_user_text' field was only added to MediaWiki in 2009 (rSVN53408), while 'log_user' has existed since 2004 (rSVN4919); looks like the missing values for these five years were never filled in.

The fix for this might be as simple as changing 'false' to 'true' in LogPager::limitPerformer() to allow it to use ids for querying. I don't know if there is any reason why this was disabled, though.

Jdforrester-WMF subscribed.Mar 6 2018, 3:08 PM
gerritbot subscribed.Mar 6 2018, 4:21 PM

Change 416710 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] Don't target log_user_text for logged-in users

https://gerrit.wikimedia.org/r/416710

gerritbot added a project: Patch-For-Review.Mar 6 2018, 4:21 PM
gerritbot added a comment.Mar 6 2018, 5:11 PM

Change 416710 merged by jenkins-bot:
[mediawiki/core@master] Don't target log_user_text for registered users

https://gerrit.wikimedia.org/r/416710

Xaosflux subscribed.Mar 6 2018, 5:56 PM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)).Mar 6 2018, 6:00 PM
GTrang subscribed.Mar 6 2018, 7:01 PM

This could also be fixed by running the populateLogUsertext.php script. It seems that that script has never been run for old log entries prior to September 2009.

GTrang mentioned this in T189043: Run populateLogUsertext.php on Wikimedia wikis.Mar 6 2018, 7:04 PM

The request to run the script has been created as T189043.

matmarex closed this task as Resolved.Mar 7 2018, 11:33 PM
matmarex assigned this task to Anomie.
matmarex removed a project: Patch-For-Review.

This has been fixed and the fix is being deployed to Wikimedia wikis with MediaWiki version 1.31.0-wmf.24, per the usual schedule (https://www.mediawiki.org/wiki/MediaWiki_1.31/Roadmap).

Guycn2 added a comment.Mar 9 2018, 7:49 PM

Thanks for fixing.

Ruthven added a subtask: T212578: Special:Log doesn't search for old entries.Dec 23 2018, 6:45 PM
Melos closed subtask T212578: Special:Log doesn't search for old entries as Invalid.Dec 23 2018, 7:14 PM
Ruthven removed a subtask: T212578: Special:Log doesn't search for old entries.Dec 23 2018, 7:16 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL