Page MenuHomePhabricator

Disable the collection of private information on abusefilter log for Beta Cluster wikis
Closed, ResolvedPublic

Description

Given the way userrights are managed there, prevent abusefilter to collect private data to avoid non-NDA people to get access to it.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 416346 had a related patch set (by MarcoAurelio) published:
[operations/mediawiki-config@master] Disable abusefilter from collecting private data on Beta

https://gerrit.wikimedia.org/r/416346

MarcoAurelio moved this task from Intake to Doing on the Privacy board.

I don't think this will actually prevent people without NDAs from accessing it as they can just get shell access and put some other logging in

afaics that variable will prevent abusefilter from collecting that data so even with shell, afl_ip fields on abuse_filter_log should be empty.

sure but they could turn it back on, or dig up IPs etc. some other way

It is unrealistic to assume that only people with an NDA get access to private Beta Cluster data (and the exact point of Beta is to be able to test code without red tape like that). If something gives that impression, we should work on correcting that, instead.

CheckUser was removed from Beta for the same reasons. Prevent people messing with private data. The 'abusefilter-private' is checkuser by the back door. It should go as well.

Change 416346 merged by jenkins-bot:
[operations/mediawiki-config@master] beta: disable abusefilter from collecting user IP addresses

https://gerrit.wikimedia.org/r/416346

There seems to be a problem with how I implemented this:

-----------------------------------------------------------------
deploymentwiki
-----------------------------------------------------------------
PHP Notice:  Undefined variable: wmgUseAbuseFilter in /srv/mediawiki/wmf-config/                                                                                                                                  CommonSettings-labs.php on line 63
Notice: Undefined variable: wmgUseAbuseFilter in /srv/mediawiki/wmf-config/Commo                                                                                                                                  nSettings-labs.php on line 63
deploymentwiki:  Purging old IP Address data from abuse_filter_log...
deploymentwiki:  47
deploymentwiki:  47 rows.
deploymentwiki:  Done.

@demon Any idea why it is failing at that (PHP Notice: Undefined variable: wmgUseAbuseFilter in /srv/mediawiki/wmf-config/ CommonSettings-labs.php on line 63)? Thanks.

The patch that implemented this got reverted per my message above. Wondering if it'll work if we removed the if (wmgUseAbuseFilter) thing from it.

Change 421864 had a related patch set (by MarcoAurelio) published:
[operations/mediawiki-config@master] Disable AbuseFilter from collecting IP addresses on Beta

https://gerrit.wikimedia.org/r/421864

Change 421864 merged by jenkins-bot:
[operations/mediawiki-config@master] Disable AbuseFilter from collecting IP addresses on Beta

https://gerrit.wikimedia.org/r/421864