Page MenuHomePhabricator
Create Task
Maniphest T189744

Add hints parameter to wbsearchentities
Open, LowPublic
Actions

Description

In order to allow wbsearchentities to accept more than just one search term, we may want to add additional parameter that would describe how search results may be filtered.

We will also add an argument to EntitySearchHelper API which will allow to restrict or modify results.

Potential use cases:
For Lexeme search:

  • Specify language for Lexeme as Q-id
  • Specify lexical category for Lexeme as Q-id (T195440)
  • Specify grammatical features for Forms as Q-id (T201821)

For Item search:

Details

SubjectRepoBranchLines +/-
Allow passing arbitrary options to search helpermediawiki/extensions/Wikibasemaster+88 -42
Customize query in gerrit

Related Objects
Search...

Event Timeline

Smalyshev created this task.Mar 14 2018, 8:52 PM
Smalyshev added a project: User-Smalyshev.Mar 27 2018, 8:30 PM
Smalyshev moved this task from Backlog to Next on the User-Smalyshev board.Apr 3 2018, 12:54 AM
Smalyshev moved this task from Next to Backlog on the User-Smalyshev board.Apr 12 2018, 8:37 PM
Smalyshev moved this task from Backlog to Next on the User-Smalyshev board.May 3 2018, 2:49 AM
Smalyshev claimed this task.May 3 2018, 3:06 AM
Smalyshev triaged this task as Medium priority.May 3 2018, 5:36 PM
gerritbot subscribed.May 3 2018, 8:23 PM

Change 430793 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[mediawiki/extensions/Wikibase@master] Allow passing arbitrary options to search helper

https://gerrit.wikimedia.org/r/430793

gerritbot added a project: Patch-For-Review.May 3 2018, 8:23 PM
Smalyshev added a project: Discovery-Search (Current work).May 3 2018, 10:35 PM
Smalyshev moved this task from Next to In review on the User-Smalyshev board.
Smalyshev moved this task from Incoming to Needs review on the Discovery-Search (Current work) board.
EBernhardson moved this task from Needs review to Waiting on the Discovery-Search (Current work) board.Jul 30 2018, 11:20 PM
EBernhardson subscribed.

I'm not really sure how to move this forward, moving to waiting/blocked to match reality.

Smalyshev added a comment.Jul 31 2018, 12:11 AM

We need to discuss it with Wikidata folks, since this is an infrastructure for some more advanced features but I'm not sure when/if we will do these features. Will raise it on Wed meeting.

Smalyshev moved this task from In review to Waiting/Blocked on the User-Smalyshev board.Jul 31 2018, 12:12 AM
Smalyshev mentioned this in T199672: Improve constraint property item suggestions for property constraint values (one-of).Aug 1 2018, 6:27 PM
Smalyshev updated the task description. (Show Details)
• Jonas mentioned this in T200995: Improve constraint property item suggestions for property constraint values (value type).Aug 2 2018, 10:33 AM
• Jonas subscribed.

Yes, I have created another ticket for that.
T200995: Improve constraint property item suggestions for property constraint values (value type)

Smalyshev mentioned this in T97566: Provide another way to surface usage instructions besides tacking them onto descriptions.Aug 12 2018, 7:50 AM
Smalyshev updated the task description. (Show Details)
Lydia_Pintscher added a comment.EditedAug 27 2018, 4:35 PM

@Jonas Would your current way of doing this also be possible for the language, lexical category and grammatical features on Lexeme pages as well as units for quantity values? I'm asking because these are not attached to a property and I'm not sure how that could be done there. Or do we need to go with the hints parameter as suggested in this ticket for those cases?

Lydia_Pintscher updated the task description. (Show Details)Aug 27 2018, 5:00 PM
Lydia_Pintscher mentioned this in T195440: Special:NewLexeme - improve suggestions for "Lexical category".
Lydia_Pintscher mentioned this in T201821: Entity selector for grammatical feature should suggest grammatical features mostly.Aug 27 2018, 5:02 PM
• Jonas added a comment.Aug 28 2018, 9:46 AM
In T189744#4535126, @Lydia_Pintscher wrote:

@Jonas Would your current way of doing this also be possible for the language, lexical category and grammatical features on Lexeme pages as well as units for quantity values? I'm asking because these are not attached to a property and I'm not sure how that could be done there. Or do we need to go with the hints parameter as suggested in this ticket for those cases?

@Lydia_Pintscher please see discussion in T200995: Improve constraint property item suggestions for property constraint values (value type) not sure if we need the hints parameter or if we could just use something like haswbstatement:P31=Unit

It is true that we cannot use the constraints definition as we don't have a property.
The hook that we have introduced could be used.

Smalyshev added a comment.Aug 28 2018, 4:52 PM

we could just use something like haswbstatement:P31=Unit

We couldn't use that because keywords are not supported for wbsearchentities. While it is possible they'll be in the future, it's not a near future I think.

• Jonas added a comment.Aug 28 2018, 6:20 PM
In T189744#4539080, @Smalyshev wrote:

we could just use something like haswbstatement:P31=Unit

We couldn't use that because keywords are not supported for wbsearchentities. While it is possible they'll be in the future, it's not a near future I think.

Couldn't we use ?action=query&format=json&list=search&srsearch= ?

Smalyshev added a comment.Aug 28 2018, 8:04 PM

Yes, you could use fulltext search, but that would be in a different format that wbsearchentities. If it's ok to move the UI from using wbsearchentities to using fulltext search then it'd work. But note that fulltext search is not a completion search. There's OpenSearch API that is completion search but I'm not sure how well it works with Wikidata now (see T55652).

• Nuria subscribed.Feb 5 2019, 6:41 PM

Not actively working on this now.

Smalyshev removed Smalyshev as the assignee of this task.Feb 11 2019, 6:50 PM
Smalyshev edited projects, added Discovery-Search; removed Discovery-Search (Current work), Patch-For-Review.Feb 26 2019, 6:23 PM
Smalyshev moved this task from needs triage to Wikibase Search on the Discovery-Search board.
Smalyshev lowered the priority of this task from Medium to Low.Jun 4 2019, 6:51 AM
Smalyshev removed a project: User-Smalyshev.Jul 3 2019, 7:17 PM
gerritbot added a comment.Jun 5 2020, 11:04 PM

Change 430793 abandoned by Addshore:
Allow passing arbitrary options to search helper

https://gerrit.wikimedia.org/r/430793

So9q subscribed.Feb 1 2021, 10:56 AM
MPhamWMF closed this task as Declined.Aug 1 2022, 9:20 PM
MPhamWMF subscribed.

Closing out low/est priority tasks over 6 months old with no activity within last 6 months in order to clean out the backlog of tickets we will not be addressing in the near term. Please feel free to reopen if you think a ticket is important, but bare in mind that given current priorities and resourcing, it is unlikely for the Search team to pick up these tasks for the indefinite future. We hope that the requested changes have either been addressed by or made irrelevant by work the team has done or is doing -- e.g. upgrading Elasticsearch to a newer version will solve various ES-related problems -- or will be subsumed by future work in a more generalized way.

thiemowmde reopened this task as Open.Aug 2 2022, 7:50 AM
thiemowmde subscribed.

Wikidata is not owned by Search. Please try to be more careful.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL