Page MenuHomePhabricator

Notifications popup: Remain with header/footer size or amend?
Closed, ResolvedPublic

Description

With T97631 in, we need to revisit Notifications popup.


While on normal interfaces/Desktop/Vector/WikimediaUI theme we now have 32px height as button sizing, OOUI dialogs, especially confirmation dialogs feature 44px, which is sufficient for touch and pointer devices on height alone.

Should we stay with the current 50px height here, or can we go for 44px to be harmonious with surrounding interface elements when re-aligning elements in the popup?
For the harmonious reasons, I'd personally be in favor of 44px, here's a take:

Please ignore the wrong preferences icon, already filed and patched under T190175

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

I think shrinking down to 44px for consistency makes sense.

I think shrinking down to 44px for consistency makes sense.

Agree. That would also avoid the footer to be larger than the header of the panel, bringing more balance to the visual hierarchy.

Change 421840 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Echo@master] Align Notifications popup header/footer with OOUI's default size

https://gerrit.wikimedia.org/r/421840

Change 421840 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Align Notifications popup header/footer with OOUI's default size

https://gerrit.wikimedia.org/r/421840

Looks good in betalabs (checked for IE too)

Change 619277 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Echo@master] Fix notification popup header always showing a scrollbar

https://gerrit.wikimedia.org/r/619277

Change 619277 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Fix notification popup header always showing a scrollbar

https://gerrit.wikimedia.org/r/619277