Maniphest T191322

Constraint icons now smaller
Closed, ResolvedPublic
Actions

Description

The constraint violation icons have shrunk in size on the page. I suspect this is due to a recent OOui change (see this email).

Details

	Subject	Repo	Branch	Lines +/-
	Replace constraint violation icons	mediawiki/extensions/WikibaseQualityConstraints	master	+6 -12
	Replace constraint violation icons	mediawiki/extensions/WikibaseQualityConstraints	master	+7 -12

Customize query in gerrit

Event Timeline

Lucas_Werkmeister_WMDE created this task.Apr 3 2018, 5:31 PM

Restricted Application added a project: Design. · View Herald TranscriptApr 3 2018, 5:31 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Lydia_Pintscher moved this task from incoming to Features/bugs for next release on the Wikibase-Quality-Constraints board.Apr 6 2018, 2:28 PM

I can adjust the size of the icons rather quickly-ish. How urgent do you think this is?

Not sure, but some users have already started to point out the different size. I guess “normal”?

Charlie_WMDE moved this task from Incoming to Incoming WD on the WMDE-Design board.May 7 2018, 3:14 PM

@Lucas_Werkmeister_WMDE We have newly sized icons ready, we need to find out how you want them to be exported to be of use.

They should be SVG files, though I might tweak them a bit before uploading them to Gerrit. (The current SVGs were, if I recall correctly, mostly hand-written by me to avoid auto-generated cruft, but of course based on the coordinates and objects in the SVG files I got from Hanna.)

Change 486087 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Replace constraint violation icons

https://gerrit.wikimedia.org/r/486087

gerritbot added a project: Patch-For-Review.Jan 23 2019, 3:34 PM

Lucas_Werkmeister_WMDE added a project: Wikidata-Campsite.Jan 23 2019, 3:34 PM

Lucas_Werkmeister_WMDE moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.

Addshore moved this task from Ready to estimate to Needs Work on the Wikidata-Campsite board.Jan 29 2019, 2:22 PM

Change 493449 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Replace constraint violation icons

https://gerrit.wikimedia.org/r/493449

Change 486087 abandoned by Lucas Werkmeister (WMDE):
Replace constraint violation icons

Reason:
replaced by I27d13eed55

https://gerrit.wikimedia.org/r/486087

Change 493449 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Replace constraint violation icons

https://gerrit.wikimedia.org/r/493449

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.22; 2019-03-19).Mar 17 2019, 12:03 AM

• Greta_Doci_WMDE closed this task as Resolved.Mar 28 2019, 10:27 AM

• Greta_Doci_WMDE claimed this task.

• Greta_Doci_WMDE removed • Greta_Doci_WMDE as the assignee of this task.

• Greta_Doci_WMDE subscribed.