Page MenuHomePhabricator
Create Task
Maniphest T191454

Watchlist missing logic is broken and hits the API multiple times unnecessarily on load
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To
ABorbaWMF
Authored By
Jdlrobson
Apr 4 2018, 7:01 PM
Tags
Referenced Files
F17601611: image.png
May 2 2018, 6:14 PM
F17601630: image.png
May 2 2018, 6:14 PM
F17601602: image.png
May 2 2018, 6:14 PM
F17601653: image.png
May 2 2018, 6:14 PM
F17601643: image.png
May 2 2018, 6:14 PM
Subscribers
Aklapper
gerritbot
Jdlrobson
• Niedzielski
ovasileva

Description

Use testing criteria from https://phabricator.wikimedia.org/T189066
Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:EditWatchlist

Open the network tab - many API requests are made (one for each missing page). o_O
Not only that.. but for pages that do not exist (red links) the watchstar is unfilled and it's impossible to remove the item from the watchlist.

Expected: No API call should be necessary on this page.

Acceptance criteria

  • On the Watchlist, for pages loaded via PHP, no API call for watch status should be necessary. They are on the watchlist so we know they are watched!
  • Infinite scroll should trigger 1 API request (as it does currently)
  • Watch stars for missing links should be filled
  • Hygiene patches should be merged.

Testing criteria

Use testing criteria from https://phabricator.wikimedia.org/T189066
Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:EditWatchlist

  • Verify that you can add/remove items from your watchlist (including red links)
  • Verify that you watch articles on pages via the top page actions menu.
  • Verify that you can watch articles on Special:Nearby and that refreshing the page continues to show the pages as watched
  • Verify that you can watch/unwatch articles while making a search

Details

SubjectRepoBranchLines +/-
Hygiene: rename InfiniteScroll to ScrollEndEmittermediawiki/extensions/MobileFrontendmaster+59 -58
Hygiene: rename and symbolize InfiniteScroll eventmediawiki/extensions/MobileFrontendmaster+20 -16
Fix: limit WatchlistGateway to 50 not 51 resultsmediawiki/extensions/MobileFrontendmaster+3 -16
Fix: bugs in watchstarsmediawiki/extensions/MobileFrontendmaster+235 -114
Hygiene: upgrade WatchstarGateway to formatversion v2mediawiki/extensions/MobileFrontendmaster+40 -37
Hygiene: remove unused styles in Watchlistmediawiki/extensions/MobileFrontendmaster+0 -15
Hygiene: trim unused PageListItem template tagmediawiki/extensions/MobileFrontendmaster+1 -1
Fix: TypeError at end of watchlistmediawiki/extensions/MobileFrontendmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Apr 4 2018, 7:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 4 2018, 7:01 PM
Jdlrobson triaged this task as High priority.Apr 4 2018, 7:01 PM
Jdlrobson moved this task from Needs Prioritization to Triaged but Future on the Web-Team-Backlog board.
Jdlrobson mentioned this in T191456: [Bug] Not possible to unwatch red links in Watchlist.Apr 4 2018, 7:05 PM
Jdlrobson mentioned this in T189066: Watchlist should not show wikidata descriptions, it should show last modified timestamp.
ovasileva moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Apr 9 2018, 11:47 AM
Jdlrobson updated the task description. (Show Details)Apr 10 2018, 4:19 PM
Jdlrobson renamed this task from Watchlist hits the API multiple times unnecessarily on load to Watchlist missing logic is broken and hits the API multiple times unnecessarily on load.Apr 10 2018, 4:23 PM
• Niedzielski subscribed.Apr 10 2018, 4:23 PM

In short: don't make a watchlist request for pages that are known to be missing.

Jdlrobson updated the task description. (Show Details)Apr 10 2018, 4:24 PM
ovasileva set the point value for this task to 5.Apr 10 2018, 4:27 PM
ovasileva added a project: Readers-Web-Kanbanana-Board-Old.
ovasileva moved this task from Upcoming to 2017-18 Q4 on the Web-Team-Backlog board.
• Niedzielski claimed this task.Apr 12 2018, 6:07 PM
• Niedzielski moved this task from To Do to Doing on the Readers-Web-Kanbanana-Board-Old board.
gerritbot subscribed.Apr 16 2018, 7:28 PM

Change 426974 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@master] Fix: TypeError at end of watchlist

https://gerrit.wikimedia.org/r/426974

gerritbot added a project: Patch-For-Review.Apr 16 2018, 7:28 PM
gerritbot added a comment.Apr 16 2018, 8:29 PM

Change 426974 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Fix: TypeError at end of watchlist

https://gerrit.wikimedia.org/r/426974

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)).Apr 16 2018, 9:00 PM
gerritbot added a comment.Apr 18 2018, 8:23 PM

Change 427531 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@master] WIP: Fix: don't request watch status with unknown IDs

https://gerrit.wikimedia.org/r/427531

gerritbot added a comment.Apr 19 2018, 12:27 PM

Change 427394 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@master] Hygiene: trim unused PageListItem template tag

https://gerrit.wikimedia.org/r/427394

gerritbot added a comment.Apr 19 2018, 6:51 PM

Change 427747 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@master] Hygiene: remove unused styles in Watchlist

https://gerrit.wikimedia.org/r/427747

gerritbot added a comment.Apr 19 2018, 11:20 PM

Change 427394 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Hygiene: trim unused PageListItem template tag

https://gerrit.wikimedia.org/r/427394

gerritbot added a comment.Apr 19 2018, 11:22 PM

Change 427747 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Hygiene: remove unused styles in Watchlist

https://gerrit.wikimedia.org/r/427747

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)).Apr 20 2018, 12:00 AM
Jdlrobson moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Apr 20 2018, 12:43 AM
Jdlrobson moved this task from Needs Code Review to Doing on the Readers-Web-Kanbanana-Board-Old board.
Jdlrobson removed a project: Patch-For-Review.
• Niedzielski removed • Niedzielski as the assignee of this task.Apr 20 2018, 4:38 AM
• Niedzielski moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.
• Niedzielski claimed this task.Apr 23 2018, 5:06 PM
• Niedzielski moved this task from Needs Code Review to Needs More Work on the Readers-Web-Kanbanana-Board-Old board.
gerritbot added a comment.Apr 24 2018, 9:55 PM

Change 428846 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@master] Hygiene: upgrade WatchstarGateway to formatversion v2

https://gerrit.wikimedia.org/r/428846

gerritbot added a project: Patch-For-Review.Apr 24 2018, 9:55 PM
gerritbot added a comment.Apr 24 2018, 10:02 PM

Change 428847 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/skins/MinervaNeue@master] Hygiene: replace calledOnce / Twice w/ callCount

https://gerrit.wikimedia.org/r/428847

gerritbot added a comment.Apr 24 2018, 10:04 PM

Change 428848 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/Popups@master] Hygiene: replace calledOnce / Twice w/ callCount

https://gerrit.wikimedia.org/r/428848

gerritbot added a comment.Apr 25 2018, 7:17 PM

Change 428986 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@master] Hygiene: rename and symbolize InfiniteScroll event

https://gerrit.wikimedia.org/r/428986

• Niedzielski moved this task from Needs More Work to Doing on the Readers-Web-Kanbanana-Board-Old board.Apr 25 2018, 10:43 PM
gerritbot added a comment.Apr 26 2018, 3:57 PM

Change 429226 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@master] Hygiene: rename InfiniteScroll to ScrollEndEmitter

https://gerrit.wikimedia.org/r/429226

gerritbot added a comment.Apr 26 2018, 9:35 PM

Change 428846 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Hygiene: upgrade WatchstarGateway to formatversion v2

https://gerrit.wikimedia.org/r/428846

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)); removed MW-1.32-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)).Apr 26 2018, 10:00 PM
Jdlrobson added a comment.Apr 27 2018, 7:00 PM

I'd like to get https://gerrit.wikimedia.org/r/427531 which fixes the bug out into the next train. I suggest we get that wrapped up and then focus on the hygiene patches.

gerritbot added a comment.May 1 2018, 12:53 AM

Change 430015 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@master] Fix: limit WatchlistGateway to 50 not 51 results

https://gerrit.wikimedia.org/r/430015

• Niedzielski removed • Niedzielski as the assignee of this task.May 1 2018, 4:59 AM
• Niedzielski moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.
• Niedzielski assigned this task to Jdlrobson.May 1 2018, 5:03 AM

Ready for review @Jdlrobson.

gerritbot added a comment.May 1 2018, 11:04 PM

Change 427531 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Fix: bugs in watchstars

https://gerrit.wikimedia.org/r/427531

Jdlrobson moved this task from Needs Code Review to Needs QA on the Readers-Web-Kanbanana-Board-Old board.May 1 2018, 11:08 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson reassigned this task from Jdlrobson to ABorbaWMF.May 1 2018, 11:10 PM

Skipping design review as a bug.
Anthony can you take a look at the testing steps on the beta cluster?

Side note: There are some hygiene patches - I'll look at those in parallel.

ABorbaWMF moved this task from Needs QA to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.May 2 2018, 6:14 PM

Looking good to me on a variety of devices/browsers

image.png (1×720 px, 245 KB)

image.png (984×540 px, 217 KB)

image.png (1×720 px, 234 KB)

image.png (960×540 px, 187 KB)

image.png (1×1 px, 172 KB)

Jdlrobson updated the task description. (Show Details)May 2 2018, 6:18 PM
gerritbot added a comment.May 2 2018, 9:26 PM

Change 430015 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Fix: limit WatchlistGateway to 50 not 51 results

https://gerrit.wikimedia.org/r/430015

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)); removed MW-1.32-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)).May 2 2018, 10:00 PM
ovasileva subscribed.May 3 2018, 10:14 AM

Looks good from my side. @Jdlrobson - one more checkbox in the acceptance criteria. Could you take a look and sign off?

Jdlrobson closed this task as Resolved.May 3 2018, 10:21 PM
Jdlrobson updated the task description. (Show Details)

I think we reached a good place. There are more hygiene patches but only loosely tied to this change.

gerritbot added a comment.May 3 2018, 11:04 PM

Change 428986 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Hygiene: rename and symbolize InfiniteScroll event

https://gerrit.wikimedia.org/r/428986

gerritbot added a comment.May 3 2018, 11:05 PM

Change 429226 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Hygiene: rename InfiniteScroll to ScrollEndEmitter

https://gerrit.wikimedia.org/r/429226

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL