Page MenuHomePhabricator
Create Task
Maniphest T191666

Define varargs in \IContextSource::msg() in a way phan can understand it
Closed, ResolvedPublic
Actions

Description

Running phan (0.12.5) on some extensions I see often:

<error line="" severity="info" message="Call with 2 arg(s) to \IContextSource::msg() which only takes 1 arg(s) defined at ../languages\MessageLocalizer.php:41" source="PhanParamTooMany"/>

I have never seen this for wfMessage and both are defined the same for the second param (@param mixed $params,...). Maybe phan sees the func_get_args and is happy, but that does not possible on interface declaration.

https://gerrit.wikimedia.org/g/mediawiki/core/+/master/languages/MessageLocalizer.php#28
https://gerrit.wikimedia.org/g/mediawiki/core/+/master/includes/GlobalFunctions.php#1412

I have no idea how to fix this for phan. Maybe this is a upstrem issue?.
Doing things only for a static analyzer is not nice, but the tool is helpful to find other mistakes.
Maybe it needs an own Plugin to declare the varargs on runtime inside phan

Details

SubjectRepoBranchLines +/-
Use varargs for MessageLocalizer::msg and similarmediawiki/coreREL1_34+33 -43
Use varargs for MessageLocalizer::msg and similarmediawiki/coremaster+33 -43
Customize query in gerrit

Related Objects

Event Timeline

Umherirrender created this task.Apr 6 2018, 8:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 6 2018, 8:39 PM
Umherirrender mentioned this in T191668: Define varargs in \IDatabase::buildLike() in a way phan can understand it.Apr 6 2018, 9:17 PM

Similar to T191668

gerritbot subscribed.Jun 8 2018, 8:35 PM

Change 439305 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] Document varargs for MessageLocalizer::msg and similar

https://gerrit.wikimedia.org/r/439305

gerritbot added a project: Patch-For-Review.Jun 8 2018, 8:35 PM
kostajh added projects: PHP 7.2 support, HHVM.Feb 24 2019, 6:45 PM
kostajh subscribed.

Not sure if these were the right tags to add, but bumping this since I just encountered this in T216964

Daimona subscribed.Mar 5 2019, 10:03 AM
Krinkle moved this task from Untriaged to MediaWiki core on the PHP 7.2 support board.Apr 16 2019, 12:35 AM
Umherirrender added a project: phan.May 19 2019, 7:40 PM
gerritbot added a comment.Jun 29 2019, 2:59 PM

Change 439305 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] Document varargs for MessageLocalizer::msg and similar

https://gerrit.wikimedia.org/r/439305

Daimona mentioned this in T228563: Phan rejects variadic calls to BagOStuff::makeKey().Jul 20 2019, 1:56 PM
Krinkle mentioned this in T228695: Phan now (wrongly) complains about code using variadic parameters.Jul 22 2019, 8:34 PM
gerritbot added a comment.Sep 4 2019, 6:14 PM

Change 439305 abandoned by Umherirrender:
Document varargs for MessageLocalizer::msg and similar

Reason:
there are some similar patch out there

https://gerrit.wikimedia.org/r/439305

Krinkle closed this task as Resolved.Sep 4 2019, 6:18 PM
Krinkle claimed this task.
Krinkle subscribed.

Looks like the builds have been passing for a while with various workarounds in place. The general issue is blocked on the HHVM migration and covered by T228695.

gerritbot added a comment.Oct 4 2019, 10:06 AM

Change 439305 restored by Umherirrender:
Document varargs for MessageLocalizer::msg and similar

Reason:
Fresh try

https://gerrit.wikimedia.org/r/439305

gerritbot added a comment.Oct 5 2019, 6:14 PM

Change 439305 merged by jenkins-bot:
[mediawiki/core@master] Use varargs for MessageLocalizer::msg and similar

https://gerrit.wikimedia.org/r/439305

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.1; 2019-10-08).Oct 5 2019, 7:00 PM
gerritbot added a comment.Oct 18 2019, 8:15 PM

Change 544252 had a related patch set uploaded (by Reedy; owner: Umherirrender):
[mediawiki/core@REL1_34] Use varargs for MessageLocalizer::msg and similar

https://gerrit.wikimedia.org/r/544252

gerritbot added a comment.Oct 18 2019, 8:30 PM

Change 544252 merged by jenkins-bot:
[mediawiki/core@REL1_34] Use varargs for MessageLocalizer::msg and similar

https://gerrit.wikimedia.org/r/544252

ReleaseTaggerBot added a project: MW-1.34-notes.Oct 18 2019, 9:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits