Page MenuHomePhabricator
Create Task
Maniphest T191668

Define varargs in \IDatabase::buildLike() in a way phan can understand it
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Running phan (0.12.5) on some extensions I see often:

<error line="" severity="info" message="Call with 2 arg(s) to \Wikimedia\Rdbms\IDatabase::buildLike() which only takes 0 arg(s) defined at ../includes\libs\rdbms\database\IDatabase.php:1138" source="PhanParamTooMany"/>

https://gerrit.wikimedia.org/g/mediawiki/core/+/master/includes/libs/rdbms/database/IDatabase.php#1138

I would say it needs @param string|LikeMatch,...

I have no idea how to fix this for phan.
Doing things only for a static analyzer is not nice, but the tool is helpful to find other mistakes.
Maybe it needs an own Plugin to declare the varargs on runtime inside phan

Details

ProjectBranchLines +/-Subject
mediawiki/coreREL1_33+19 -31Backport NameTableStoreTest::getCallCheckingDb simplification
mediawiki/coreREL1_32+16 -28Backport NameTableStoreTest::getCallCheckingDb simplification
mediawiki/coremaster+32 -50rdbms: Document varargs for IDatabase::buildLike
mediawiki/coremaster+3 -4Use varargs for IDatabase::buildLike
mediawiki/coremaster+2 -1rdbms: Type IDatabase::buildLike param as variadic to Phan (really)
mediawiki/coremaster+9 -0rdbms: Use @phan-param to simulate variadic argument
Customize query in gerrit

Related Objects

Event Timeline

Umherirrender created this task.Apr 6 2018, 9:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 6 2018, 9:16 PM
Umherirrender added a comment.Apr 6 2018, 9:17 PM

Similar to T191666

Umherirrender mentioned this in T191666: Define varargs in \IContextSource::msg() in a way phan can understand it.Apr 6 2018, 9:17 PM
Krinkle moved this task from Untriaged to Rdbms library on the Wikimedia-Rdbms board.Apr 10 2018, 3:42 PM
gerritbot added a subscriber: gerritbot.Jun 8 2018, 8:17 PM

Change 439303 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] Document varargs for IDatabase::buildLike

https://gerrit.wikimedia.org/r/439303

gerritbot added a project: Patch-For-Review.Jun 8 2018, 8:17 PM
Daimona added a subscriber: Daimona.Mar 5 2019, 10:01 AM
gerritbot added a comment.Apr 7 2019, 4:57 PM

Change 439303 had a related patch set uploaded (by Krinkle; owner: Umherirrender):
[mediawiki/core@master] Document varargs for IDatabase::buildLike

https://gerrit.wikimedia.org/r/439303

gerritbot added a comment.Apr 7 2019, 7:20 PM

Change 502019 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] rdbms: Use @phan-param to simulate variadic argument

https://gerrit.wikimedia.org/r/502019

Krinkle triaged this task as High priority.Apr 13 2019, 7:02 PM
Krinkle added a project: Wikimedia-production-error (ARCHIVED -- Shared Build Failure).
Krinkle edited projects, added Performance-Team; removed MediaWiki-extensions-General.
Krinkle claimed this task.Apr 15 2019, 7:56 PM
kchapman moved this task from Inbox to Blocked or Needs-CR on the Performance-Team board.Apr 15 2019, 7:56 PM
Krinkle moved this task from Untriaged to In progress on the Wikimedia-production-error (ARCHIVED -- Shared Build Failure) board.Apr 16 2019, 1:20 AM
gerritbot added a comment.Apr 16 2019, 1:21 AM

Change 502019 abandoned by Krinkle:
rdbms: Use @phan-param to simulate variadic argument

Reason:
Superseded by I4b8f2b8a8b

https://gerrit.wikimedia.org/r/502019

Krinkle reassigned this task from Krinkle to aaron.Apr 23 2019, 5:33 PM
Krinkle moved this task from Blocked or Needs-CR to Doing on the Performance-Team board.
Krinkle added a subscriber: Krinkle.
Umherirrender added a project: phan.May 19 2019, 7:39 PM
aaron moved this task from Doing to Blocked or Needs-CR on the Performance-Team board.May 21 2019, 9:06 PM
Krinkle added a comment.EditedJun 17 2019, 10:03 PM

Copied here from code review (https://gerrit.wikimedia.org/r/439303) for easy reference:

Fatal error: Parameter $params is variadic and has a type constraint (array); variadic params with type constraints are not supported in non-Hack files in /workspace/src/vendor/phpunit/phpunit-mock-objects/src/Framework/MockObject/Generator.php(290)(4aa354d35306d0068dd7cfe6fa0b0a25) : eval()'d code on line 1726

Comes from PHPUnit, which is wrongly inferring it from.. something.
Looks like this is due to a bug in HHVM's implementation of ReflectorClass/ReflectorParameter

https://3v4l.org/1spSX

On HHVM 1.13+, a variadic parameter is considered as having a type of 'array'. This makes some sense in that the lexical binding will indeed hold an array. But, it's a problem for the way PHPUnit reads it, because it uses that information to build a to-be-eval()'ed signature having the type "array", like "function( array ....$params )" which is not valid syntax in PHP 5.6 mode on HHVM. Because it does not support type-hinted splatted parameters.

So, the only issue is that PHPUnit 4 on HHVM is unable to create a mock object for this kind of signature.

gerritbot added a comment.Jun 18 2019, 2:47 PM

Change 439303 merged by jenkins-bot:
[mediawiki/core@master] rdbms: Document varargs for IDatabase::buildLike

https://gerrit.wikimedia.org/r/439303

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).Jun 18 2019, 3:01 PM
aaron closed this task as Resolved.Jun 18 2019, 3:28 PM
Krinkle removed a project: Patch-For-Review.Jun 18 2019, 8:24 PM
Krinkle reopened this task as Open.Jul 5 2019, 6:41 PM
Krinkle merged a task: T226223: Definition of IDatabase::buildLike doesn't match Database::buildLike.
Krinkle added a subscriber: Reedy.
gerritbot added a comment.Jul 5 2019, 6:42 PM

Change 519728 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] rdbms: Type IDatabase::buildLike param as variadic to Phan (really)

https://gerrit.wikimedia.org/r/519728

gerritbot added a project: Patch-For-Review.Jul 5 2019, 6:42 PM
Krinkle added a comment.Jul 5 2019, 6:42 PM
In T226223#5292195, @Reedy wrote:

This is still failing on the same JADE patch...

https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Jade/+/511080/
https://integration.wikimedia.org/ci/job/mwext-php72-phan-docker/995/console

14:09:11 <?xml version="1.0" encoding="ISO-8859-15"?>
14:09:11 <checkstyle version="6.5">
14:09:11   <file name="maintenance/CleanJudgmentLinks.php">
14:09:11     <error line="171" severity="info" message="Call with 2 arg(s) to \Wikimedia\Rdbms\IDatabase::buildLike() which only takes 1 arg(s) defined at ../../includes/libs/rdbms/database/IDatabase.php:1234" source="PhanParamTooMany"/>
14:09:11   </file>
14:09:11 </checkstyle>
Krinkle removed a project: MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).Jul 5 2019, 6:42 PM
Daimona mentioned this in T228563: Phan rejects variadic calls to BagOStuff::makeKey().Jul 20 2019, 1:56 PM
Krinkle mentioned this in T228695: Phan now (wrongly) complains about code using variadic parameters.Jul 22 2019, 8:34 PM
gerritbot added a comment.Jul 30 2019, 2:28 PM

Change 519728 abandoned by Krinkle:
rdbms: Type IDatabase::buildLike param as variadic to Phan (really)

https://gerrit.wikimedia.org/r/519728

Restricted Application added a project: Platform Engineering. · View Herald TranscriptJul 30 2019, 2:28 PM
CCicalese_WMF removed a project: Platform Engineering.Jul 30 2019, 5:07 PM
Krinkle closed this task as Resolved.Aug 15 2019, 4:38 PM

Looks like the Jade repo is no longer affected. And gated extensions are also fine. Closing for now.

mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM
Daimona mentioned this in T231710: Recommend PHP7-only features after dropping HHVM support.Sep 24 2019, 11:58 AM
gerritbot added a comment.Oct 4 2019, 9:38 AM

Change 540830 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] Use varargs for IDatabase::buildLike

https://gerrit.wikimedia.org/r/540830

gerritbot added a comment.Oct 4 2019, 11:59 AM

Change 540830 merged by jenkins-bot:
[mediawiki/core@master] Use varargs for IDatabase::buildLike

https://gerrit.wikimedia.org/r/540830

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.1; 2019-10-08).Oct 4 2019, 12:00 PM
gerritbot added a comment.Oct 10 2019, 10:42 PM

Change 542248 had a related patch set uploaded (by Reedy; owner: Umherirrender):
[mediawiki/core@REL1_33] rdbms: Document varargs for IDatabase::buildLike

https://gerrit.wikimedia.org/r/542248

gerritbot added a comment.Oct 10 2019, 10:56 PM

Change 542249 had a related patch set uploaded (by Reedy; owner: Umherirrender):
[mediawiki/core@REL1_32] rdbms: Document varargs for IDatabase::buildLike

https://gerrit.wikimedia.org/r/542249

gerritbot added a comment.Oct 11 2019, 1:15 AM

Change 542249 abandoned by Reedy:
Backport NameTableStoreTest::getCallCheckingDb simplification

https://gerrit.wikimedia.org/r/542249

gerritbot added a comment.Oct 11 2019, 1:16 AM

Change 542248 abandoned by Reedy:
Backport NameTableStoreTest::getCallCheckingDb simplification

https://gerrit.wikimedia.org/r/542248

gerritbot added a comment.May 28 2020, 2:01 PM

Change 542248 restored by Reedy:
Backport NameTableStoreTest::getCallCheckingDb simplification

https://gerrit.wikimedia.org/r/542248

gerritbot added a comment.May 28 2020, 3:51 PM

Change 542248 merged by jenkins-bot:
[mediawiki/core@REL1_33] Backport NameTableStoreTest::getCallCheckingDb simplification

https://gerrit.wikimedia.org/r/542248

ReleaseTaggerBot added a project: MW-1.33-notes.May 28 2020, 4:00 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL