Page MenuHomePhabricator
Create Task
Maniphest T191699

AbuseLog entries associated with revdel'd revisions are hidden from administrators
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  • Be a sysop.
  • Find a revdel'd revision which also triggered some filter(s) (eg. a tagged one).
  • Try to find an AbuseLog entry for the edit.

If you don't have abusefilter-hidden-log right, you won't succeed. I think this doesn't make sense (unless the entry is hidden as well, otherwise you need special rights). If I can see the text that was hidden, why cannot I see the log entry, which reveals nothing I don't know?

Giving live examples would be pointless because logs are usually hidden from ordinary users.

Details

SubjectRepoBranchLines +/-
Show AF logs for a revdeled revision if the user can see the revisionmediawiki/extensions/AbuseFiltermaster+20 -5
Customize query in gerrit

Related Objects

Event Timeline

matej_suchanek created this task.Apr 7 2018, 2:54 PM
Restricted Application added subscribers: • OldUser02, Aklapper. · View Herald TranscriptApr 7 2018, 2:54 PM
MarcoAurelio subscribed.Apr 7 2018, 7:55 PM

Please note that abusefilter-hidden-log and abusefilter-hide-log are Oversight-level permissions that must not be granted to non OS people.

Huji subscribed.Apr 17 2018, 12:23 AM

@MarcoAurelio That is not relevant. abusefilter-hidden-log and abusefilter-hide-log are about the abuse logs. This issue is about when a page (e.g. an article) has a revision that triggered a filter and then was revdel'ed.

matej_suchanek merged a task: T197480: Revdel'd edits do not show up in AbuseLog, even for admins.Jun 15 2018, 4:38 PM
matej_suchanek added a subscriber: MusikAnimal.
MusikAnimal added a comment.Jun 15 2018, 4:44 PM

Thanks for closing the duplicate, mateg! I searched the board and couldn't find an existing task.

Copying over some points from T197480:

Daimona claimed this task.Jul 13 2018, 10:28 PM
Daimona subscribed.

I'm looking at this, it's quite a simple fix focused on avoiding a string to bool conversion. However, this could make another problem appear, i.e. T44734 for revdel'ed revisions. I'm seizing the opportunity to fix both.

gerritbot subscribed.Jul 13 2018, 10:38 PM

Change 445727 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Show AF logs for a revdeled revision if the user can see the revision

https://gerrit.wikimedia.org/r/445727

gerritbot added a project: Patch-For-Review.Jul 13 2018, 10:38 PM
Huji closed this task as Resolved.Jul 18 2018, 1:40 AM
Huji removed a project: Patch-For-Review.

@Daimona should we also close T44734 now that this is merged?

gerritbot added a comment.Jul 18 2018, 2:04 AM

Change 445727 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Show AF logs for a revdeled revision if the user can see the revision

https://gerrit.wikimedia.org/r/445727

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)).Jul 18 2018, 5:01 AM
Daimona added a comment.Jul 18 2018, 7:12 AM

@Huji No, I've been too optimistic while saying that I would have tried to fix both. Per my comment on that task (and the other before), it won't be easy at all.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL