Maniphest T192191

[BUG] Delete and share buttons disappear if you swipe individual reading list cell while downloads are in progress
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Mhurd
	Apr 14 2018, 1:39 AM

Description

How many times were you able to reproduce it?

Every time

Steps to reproduce

Use reading list danger zone to add some articles to each reading list
Tap "Saved" icon
Tap "Reading lists"
Select a reading list
Swipe on one of the article cells

Expected results

Share and Delete buttons remain

Actual results

They disappear

Screenshots

Tap image for animation

Environments observed

App version:
5.8

OS versions:
All

Device model:
All

Device language:
All

Revisions and Commits

rAPIOS The official Wikipedia iOS application
	rAPIOS215b4e57fa6c Merge pull request #2265 from wikimedia/T192191

Related Objects

Mentioned In: rAPIOS8240c3fb0577: fix swipe state configuration on cell reload T192191

Event Timeline

Mhurd created this task.Apr 14 2018, 1:39 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 14 2018, 1:39 AM

• JMinor triaged this task as Low priority.Apr 17 2018, 5:38 PM

• JMinor added a project: iOS-app-v5.8.0-Manatee-On-A-Skateboard.

• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.

• JMinor moved this task from Tasks from Product Backlog to Ready for Development on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 17 2018, 6:15 PM

Mhurd claimed this task.Apr 18 2018, 8:53 PM

Mhurd moved this task from Ready for Development to Doing on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.

Mhurd removed Mhurd as the assignee of this task.Apr 18 2018, 10:30 PM

Mhurd moved this task from Doing to Ready for Development on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.

Note: be sure to add at least one Hebrew article to the list used for testing. I was seeing the image jump left such that the edit radio button overlayed it.

LGoto edited projects, added iOS-app-v5.8.1-Manatee-On-A-Scootscoot; removed iOS-app-v5.8.0-Manatee-On-A-Skateboard.Apr 19 2018, 6:53 PM

• JMinor moved this task from Tasks from Product Backlog to Ready for Development on the iOS-app-v5.8.1-Manatee-On-A-Scootscoot board.Apr 19 2018, 11:30 PM

Mhurd claimed this task.Apr 27 2018, 5:48 PM

Mhurd moved this task from Ready for Development to Doing on the iOS-app-v5.8.1-Manatee-On-A-Scootscoot board.

Mhurd removed Mhurd as the assignee of this task.Apr 27 2018, 11:48 PM

Mhurd moved this task from Doing to Ready for Development on the iOS-app-v5.8.1-Manatee-On-A-Scootscoot board.

JoeWalsh claimed this task.Apr 30 2018, 4:21 PM

JoeWalsh moved this task from Ready for Development to Doing on the iOS-app-v5.8.1-Manatee-On-A-Scootscoot board.

https://github.com/wikimedia/wikipedia-ios/pull/2265

JoeWalsh moved this task from Doing to Needs Code Review on the iOS-app-v5.8.1-Manatee-On-A-Scootscoot board.Apr 30 2018, 4:51 PM

JoeWalsh mentioned this in rAPIOS8240c3fb0577: fix swipe state configuration on cell reload T192191.Apr 30 2018, 4:54 PM

• NHarateh_WMF closed this task as Resolved by committing rAPIOS215b4e57fa6c: Merge pull request #2265 from wikimedia/T192191.Apr 30 2018, 6:06 PM

• NHarateh_WMF added a commit: rAPIOS215b4e57fa6c: Merge pull request #2265 from wikimedia/T192191.

No idea why Phab decided to close it when I merged the PR

• NHarateh_WMF moved this task from Waiting for Build to Needs Design Review on the iOS-app-v5.8.1-Manatee-On-A-Scootscoot board.May 2 2018, 10:47 AM

Working for me! Thanks @JoeWalsh!

Looks good to me on 5.8.1 (1400)

• JMinor closed this task as Resolved.May 8 2018, 2:26 AM

[BUG] Delete and share buttons disappear if you swipe individual reading list cell while downloads are in progressClosed, ResolvedPublicActions