Maniphest T192420

[BUG] Popover panel close button doesn't respect device lang direction
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Mhurd
	Apr 18 2018, 12:02 AM

Description

How many times were you able to reproduce it?

All

Steps to reproduce

set device lang to Hebrew
clean install app
tap through welcome screens until you get to Explore
log in
you should see a popup panel similar to the screenshot

Expected results

Close button at top of panel would be on the left

Actual results

Close button at top of panel is on the right

Screenshots

Screen Shot 2018-04-17 at 5.00.20 PM.png (1×862 px, 151 KB)

Environments observed

App version:
5.8
OS versions:
10.3.1
Device model:
All
Device language:
Hebrew

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Mhurd	T191862 Audit new reading list bits for RTL
		Resolved		Mhurd	T192420 [BUG] Popover panel close button doesn't respect device lang direction

Event Timeline

Mhurd created this task.Apr 18 2018, 12:02 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 18 2018, 12:02 AM

Mhurd added a parent task: T191862: Audit new reading list bits for RTL.Apr 18 2018, 12:03 AM

https://github.com/wikimedia/wikipedia-ios/pull/2228

Mhurd claimed this task.Apr 18 2018, 12:09 AM

Mhurd added a project: iOS-app-v5.8.0-Manatee-On-A-Skateboard.

Mhurd moved this task from Tasks from Product Backlog to Needs Code Review on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.

Diffusion mentioned this in rAPIOSfd525d8cf66a: Merge branch 'develop' into fix/panel-close-button-rtl/T192420.Apr 18 2018, 12:11 AM

Diffusion mentioned this in rAPIOS40097f0fc000: Merge branch 'develop' into fix/panel-close-button-rtl/T192420.Apr 18 2018, 12:41 AM

Diffusion mentioned this in rAPIOSd3b4872e9901: Merge branch 'develop' into fix/panel-close-button-rtl/T192420.Apr 18 2018, 1:01 AM

• NHarateh_WMF moved this task from Needs Code Review to Waiting for Build on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 18 2018, 2:53 PM

• NHarateh_WMF mentioned this in rAPIOS0604ae2eb8b3: Merge pull request #2228 from wikimedia/fix/panel-close-button-rtl/T192420.Apr 18 2018, 2:54 PM

• JMinor triaged this task as Low priority.Apr 18 2018, 5:16 PM

Mhurd moved this task from Waiting for Build to Needs Design Review on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 18 2018, 11:43 PM

Restricted Application added a project: Product-Analytics. · View Herald TranscriptApr 18 2018, 11:43 PM

• Phabricator_maintenance removed a project: Product-Analytics.Apr 19 2018, 12:24 AM

cmadeo moved this task from Needs Design Review to Needs QA on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 19 2018, 4:58 PM

LGoto moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 23 2018, 8:38 PM

LGoto moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.Apr 23 2018, 9:01 PM

• JMinor closed this task as Resolved.Apr 23 2018, 11:14 PM

	F17058584: Screen Shot 2018-04-17 at 5.00.20 PM.png
	Apr 18 2018, 12:02 AM

[BUG] Popover panel close button doesn't respect device lang directionClosed, ResolvedPublicActions