Page MenuHomePhabricator
Create Task
Maniphest T192534

Missing Save this article bookmark on "Read more" section of article footer
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
Sharvaniharan
Authored By
RHo
Apr 19 2018, 9:57 AM
Tags
Referenced Files
F18601247: readingList.png
May 29 2018, 7:24 PM
F18601246: history.png
May 29 2018, 7:24 PM
F18601238: savedToList.png
May 29 2018, 7:24 PM
F18601241: removedFromList.png
May 29 2018, 7:24 PM
F18601236: bottomsheet.png
May 29 2018, 7:24 PM
F18601257: pageBottomContent.png
May 29 2018, 7:24 PM
F18492884: image.png
May 23 2018, 4:56 PM
F17124206: image.png
Apr 19 2018, 9:57 AM
View All 9 Files
Subscribers
ABorbaWMF
Aklapper
• Charlotte
Dbrant
gerritbot
RHo

Description

Missed that this was not included as part of the work on T116841: Standardize footer across mobile apps with addition of an "About this article" footer menu

Expected:

image.png (516×628 px, 80 KB)
image.png (1×784 px, 128 KB)
  • Each article listed in the "Read more" footer section of an article should have an RHS action to save it to a reading list
  • Read more card is full width of the screen
  • Each list item in the "About this article and "Read more" sections of the footer should have a separator (color: Material theme borders and rules; height 0.5dp) with a left-margin that is aligned with the start of the text)

Actual:

image.png (1×1 px, 247 KB)

  • No bookmark icon to save articles to a reading list
  • Read more card is not full width
  • Separator lines start from the icon/thumb

Details

SubjectRepoBranchLines +/-
Add bookmark on "Read more" section of article footerapps/android/wikipediamaster+172 -85
Customize query in gerrit

Related Objects

Event Timeline

RHo created this task.Apr 19 2018, 9:57 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 19 2018, 9:57 AM
RHo mentioned this in T116841: Standardize footer across mobile apps with addition of an "About this article" footer menu.Apr 19 2018, 7:06 PM
Dbrant removed a project: wikimedia-page-library.Apr 23 2018, 2:07 PM
Sharvaniharan claimed this task.Apr 25 2018, 7:40 PM
• Charlotte subscribed.EditedApr 27 2018, 2:48 PM

Hey @Sharvaniharan - if you're going to pick up this (admittedly small) task please move it to the release board as well. :)

• Charlotte edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly); removed Wikipedia-Android-App-Backlog.Apr 27 2018, 2:55 PM
Dbrant subscribed.Apr 27 2018, 2:57 PM

Note: it's by no means clear that this is a small task. This should be properly estimated and prioritized.

• Charlotte added a comment.Apr 27 2018, 2:58 PM

Interesting. So if this isn't a small task then @Sharvaniharan I would recommend picking up one of the bugs or tiny bits of UX debt instead if you are waiting or have nothing much to do.

• Charlotte edited projects, added Wikipedia-Android-App-Backlog; removed Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly).Apr 27 2018, 2:59 PM
Sharvaniharan added a comment.Apr 27 2018, 3:58 PM

Will leave it in backlog until we triage. @Charlotte @Dbrant

Sharvaniharan set the point value for this task to 3.May 15 2018, 4:49 PM
Sharvaniharan moved this task from Needs Triage to Android-app-release-v2.7.25x-J-Jaffa-Cake on the Wikipedia-Android-App-Backlog board.
Sharvaniharan edited projects, added Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake); removed Wikipedia-Android-App-Backlog.
Sharvaniharan moved this task from Backlog to Ready for dev on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.May 15 2018, 5:15 PM
RHo updated the task description. (Show Details)May 23 2018, 4:54 PM
RHo updated the task description. (Show Details)
Sharvaniharan added a comment.May 24 2018, 3:51 PM

@RHo is there a Zeplin mock for this? also, what happens when the bookmark is clicked? UI-wise, should it open a bottom sheet like 'Featured Article'?

gerritbot subscribed.May 24 2018, 3:56 PM

Change 434943 had a related patch set uploaded (by Sharvaniharan; owner: Sharvaniharan):
[apps/android/wikipedia@master] [WIP] Add bookmark on "Read more" section of article footer

https://gerrit.wikimedia.org/r/434943

gerritbot added a project: Patch-For-Review.May 24 2018, 3:56 PM
RHo added a comment.May 24 2018, 5:03 PM
In T192534#4229023, @Sharvaniharan wrote:

@RHo is there a Zeplin mock for this? also, what happens when the bookmark is clicked? UI-wise, should it open a bottom sheet like 'Featured Article'?

Hi @Sharvaniharan - here's a link to the updated Zeplin: https://zpl.io/2ZdQlEa
And yes, tapping on the save/unsave article should be as per the behavior as doing so on the "Featured article" in the feed. Thanks!

Sharvaniharan added a comment.May 29 2018, 7:24 PM

@RHo this is ready for review here : https://gerrit.wikimedia.org/r/#/c/434943/

Few screenshots:
Bottomsheet for saving to list:

bottomsheet.png (1×720 px, 103 KB)

Added:

savedToList.png (1×720 px, 94 KB)

Removed from list:

removedFromList.png (1×720 px, 93 KB)

Page Bottom content:

pageBottomContent.png (1×720 px, 98 KB)

The same component is used in ReadingList and History list, so here are screenshots of those:

readingList.png (1×720 px, 710 KB)

history.png (1×720 px, 159 KB)

Sharvaniharan moved this task from Ready for dev to Code Review on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.May 29 2018, 7:32 PM
gerritbot added a comment.Jun 19 2018, 3:39 PM

Change 434943 merged by jenkins-bot:
[apps/android/wikipedia@master] Add bookmark on "Read more" section of article footer

https://gerrit.wikimedia.org/r/434943

Dbrant added a comment.Jun 20 2018, 3:28 PM

@RHo Quick question of consistency:
In the "read more" items, it looks like the bookmark icon has a color of Black54, whereas the overflow icons in the reading list items currently has a color of Black38. Are these meant to be different colors, or can we standardize it to be a single color?

RHo added a comment.Jun 20 2018, 3:42 PM

hi @Dbrant - yes, we made the change to overflow icons on article list items a while back to be the lighter color so that they were less prominent when a whole list of articles list were on the screen (eg in the trending card). The overflow on light theme in toolbars and cards are meant to be the darker Black@54% color.

Dbrant moved this task from Code Review to Design signoff on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.Jun 22 2018, 5:02 PM
RHo moved this task from Design signoff to QA signoff on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.Aug 2 2018, 4:55 PM

LGTM on Wikipedia v2.7.239-alpha-2018-08-02, using Pixel 2 (8.1).
Moving to QA for adding checks

ABorbaWMF moved this task from QA signoff to Ready for signoff on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.Aug 6 2018, 7:02 PM
ABorbaWMF subscribed.

Looks good on 2.7.239-alpha-2018-08-06

Dbrant closed this task as Resolved.Nov 1 2018, 5:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL