Page MenuHomePhabricator
Create Task
Maniphest T192776

Extract language validation logic out of LemmaChangeOpDeserializer
Closed, ResolvedPublic
Actions

Description

LemmaChangeOpDeserializer contains logic for validating the lemma language. This should be extracted for reuse when validating form representations.

Details

SubjectRepoBranchLines +/-
Fix and extract lemma language validationmediawiki/extensions/WikibaseLexememaster+137 -25
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jakob_WMDE triaged this task as High priority.Apr 23 2018, 12:56 PM
Jakob_WMDE created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 23 2018, 12:56 PM
gerritbot subscribed.Apr 23 2018, 2:23 PM

Change 428341 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Fix and extract lemma language validation

https://gerrit.wikimedia.org/r/428341

gerritbot added a project: Patch-For-Review.Apr 23 2018, 2:23 PM
Jakob_WMDE mentioned this in rEWLE55fe2a782585: Fix and extract lemma language validation.Apr 23 2018, 2:25 PM
Jakob_WMDE mentioned this in rEWLE0c967902205e: Fix and extract lemma language validation.Apr 23 2018, 3:00 PM
Jakob_WMDE mentioned this in rEWLE217ebe3969c6: Fix and extract lemma language validation.Apr 23 2018, 3:21 PM
Lydia_Pintscher moved this task from incoming to other stuff on the Wikidata Lexicographical data board.Apr 23 2018, 7:57 PM
Jakob_WMDE mentioned this in rEWLE70bb233bad19: Fix and extract lemma language validation.Apr 25 2018, 12:38 PM
Jakob_WMDE mentioned this in rEWLE0e305536fd1a: Fix and extract lemma language validation.Apr 26 2018, 8:40 AM
Addshore mentioned this in rEWLEe1f0bc0ef6be: Fix and extract lemma language validation.Apr 27 2018, 11:27 AM
Jakob_WMDE mentioned this in rEWLE0242bff5cc27: Fix and extract lemma language validation.Apr 27 2018, 12:29 PM
Addshore mentioned this in rEWLEfa667388a88e: Fix and extract lemma language validation.Apr 30 2018, 11:44 AM
Addshore added a project: Wikidata-Turtles-Sprint#4.Apr 30 2018, 11:45 AM
Addshore moved this task from To Do to Peer Review on the Wikidata-Turtles-Sprint#4 board.
gerritbot added a comment.Apr 30 2018, 11:54 AM

Change 428341 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Fix and extract lemma language validation

https://gerrit.wikimedia.org/r/428341

Addshore moved this task from Peer Review to Test (Product Review) on the Wikidata-Turtles-Sprint#4 board.Apr 30 2018, 11:55 AM
Addshore merged a task: T193010: Extract language code validation for use with lemmas and representations.Apr 30 2018, 3:31 PM
Addshore added subscribers: WMDE-leszek, Addshore, Lydia_Pintscher.
Jakob_WMDE moved this task from Test (Product Review) to Done on the Wikidata-Turtles-Sprint#4 board.Apr 30 2018, 4:08 PM
Jakob_WMDE closed this task as Resolved.May 2 2018, 8:51 AM
Mainframe98 merged a task: T193010: Extract language code validation for use with lemmas and representations.Jul 1 2018, 8:07 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits