Maniphest T194120

Layout of edit mode switcher in old wikitext editor broken in Monobook skin
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Schnark
	May 8 2018, 7:21 AM

Description

In the old wikitext editor in Monobook skin, the layout of the edit mode switcher is broken:

The active area of the switcher extends over it's visible area too far below, and when the menu is open it is placed too far below by the same amount.

This doesn't happen in VE, nor does it happen in other skins, so it seems like a problem specific for Monobook/Apex and the WikiEditor toolbar.

Details

	Subject	Repo	Branch	Lines +/-
	ve.init.MWVESwitchConfirmDialog: Fix gap above dropdown on MonoBook	mediawiki/extensions/VisualEditor	master	+1 -4

Customize query in gerrit

Related Objects

Mentioned In: T199752: Toolbar menu positioning broken when zoom level > 100%

Event Timeline

Schnark created this task.May 8 2018, 7:21 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 8 2018, 7:21 AM

• Vvjjkkii renamed this task from Layout of edit mode switcher in old wikitext editor broken in Monobook skin to 3edaaaaaaa.Jul 1 2018, 1:11 AM

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed a subscriber: Aklapper.

CommunityTechBot renamed this task from 3edaaaaaaa to Layout of edit mode switcher in old wikitext editor broken in Monobook skin.Jul 1 2018, 3:46 PM

CommunityTechBot raised the priority of this task from High to Needs Triage.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added a subscriber: Aklapper.

Schnark mentioned this in T199752: Toolbar menu positioning broken when zoom level > 100%.Jul 17 2018, 7:27 AM

I accidentally discovered why this is broken while working on another task.

Change 460969 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.init.MWVESwitchConfirmDialog: Fix gap above dropdown on MonoBook

https://gerrit.wikimedia.org/r/460969

gerritbot added a project: Patch-For-Review.Sep 17 2018, 8:23 PM

matmarex moved this task from Incoming to QA on the VisualEditor (Current work) board.Sep 17 2018, 9:44 PM

Change 460969 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.init.MWVESwitchConfirmDialog: Fix gap above dropdown on MonoBook

https://gerrit.wikimedia.org/r/460969

Jdforrester-WMF removed a project: Patch-For-Review.Sep 17 2018, 9:47 PM

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 17 2018, 10:00 PM

Ryasmeen added a project: Verified.Sep 20 2018, 3:13 AM

Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.

• Deskana closed this task as Resolved.Sep 28 2018, 12:22 PM

• Deskana triaged this task as Medium priority.