Page MenuHomePhabricator
Create Task
Maniphest T194177

Make copyright.html usable for non-Wikidata installations
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Problem:
copyright.html is currently specific to the Wikidata Query Service. It specifies Wikidata, its license and other things that do not apply to other installations. This should somehow be configurable without changing the revision-controlled file.

https://query.wikidata.org/copyright.html

BDD
GIVEN a 3rd party Wikibase installations
AND different licensing conditions of that installation
THEN it should be possible to change the licensing text without touching a file under revision control

Acceptance criteria:

  • a 3rd party installation can easily change the licensing information to fit their project

Details

SubjectRepoBranchLines +/-
Merging from e0923f891b09dcdf400ffcbf259f77b529bf4cda:wikidata/query/gui-deployproduction+4 -5
Drop copyright.html and link to wikidata insteadwikidata/query/guimaster+4 -81
Move copyright to config.jswikidata/query/guimaster+9 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.May 8 2018, 4:27 PM
• Vvjjkkii renamed this task from Make copyright.html usable for non-Wikidata installations to iddaaaaaaa.Jul 1 2018, 1:11 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from iddaaaaaaa to Make copyright.html usable for non-Wikidata installations.Jul 1 2018, 3:27 PM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: Aklapper.
Lydia_Pintscher added a project: Wikidata-Campsite.Dec 10 2018, 10:06 AM
Lydia_Pintscher updated the task description. (Show Details)Dec 10 2018, 10:12 AM
Lydia_Pintscher moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.
Lucas_Werkmeister_WMDE added a subscriber: Smalyshev.Dec 11 2018, 3:32 PM

Our decision during story time is to move this information to a page on Wikidata, and put the link to that page in config.js so that other installations can easily change it to point somewhere else (e. g. a page on their own wiki).

(This would also resolve T211123: copyright.html is missing style sheets, because it would completely get rid of copyright.html.)

@Smalyshev does that sound okay to you?

Lucas_Werkmeister_WMDE moved this task from Ready to estimate to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Dec 11 2018, 3:32 PM
Lucas_Werkmeister_WMDE edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Lucas_Werkmeister_WMDE set the point value for this task to 5.
Smalyshev added a comment.Dec 11 2018, 6:00 PM

Sounds good to me.

Addshore triaged this task as Medium priority.Dec 12 2018, 12:23 PM
gerritbot subscribed.Dec 18 2018, 11:18 PM

Change 480669 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[wikidata/query/gui@master] Move copyright to config.js

https://gerrit.wikimedia.org/r/480669

gerritbot added a project: Patch-For-Review.Dec 18 2018, 11:18 PM
Ladsgroup mentioned this in rWDQG3659dc6b3945: Move copyright to config.js.Dec 18 2018, 11:19 PM
Ladsgroup claimed this task.Dec 18 2018, 11:20 PM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptDec 18 2018, 11:20 PM
Ladsgroup mentioned this in rWDQG3a0dea785d97: Move copyright to config.js.Dec 18 2018, 11:24 PM
gerritbot added a comment.Dec 19 2018, 12:49 AM

Change 480682 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[wikidata/query/gui@master] Drop copyright.html and link to wikidata instead

https://gerrit.wikimedia.org/r/480682

gerritbot added a comment.Dec 19 2018, 12:50 AM

Change 480669 abandoned by Ladsgroup:
Move copyright to config.js

Reason:
In favor of I39e16dff1e4d98a165acf14848c2dca3cb668a1b

https://gerrit.wikimedia.org/r/480669

Ladsgroup mentioned this in rWDQGe0923f891b09: Drop copyright.html and link to wikidata instead.Dec 19 2018, 12:51 AM
Smalyshev added a subscriber: Gehel.Dec 19 2018, 1:07 AM

I see https://www.wikidata.org/wiki/Wikidata:SPARQL_query_service/Copyright was created, which is nice. But myself and probably other people from WDQS team (at least @Gehel, maybe also @Lucas_Werkmeister_WMDE and others) should be able to edit it. Right now it's not the case.

Ladsgroup added a comment.Dec 19 2018, 1:12 AM
In T194177#4833166, @Smalyshev wrote:

I see https://www.wikidata.org/wiki/Wikidata:SPARQL_query_service/Copyright was created, which is nice. But myself and probably other people from WDQS team (at least @Gehel, maybe also @Lucas_Werkmeister_WMDE and others) should be able to edit it. Right now it's not the case.

Done. Sorry for the issue.

Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 19 2018, 1:20 AM
gerritbot added a comment.Dec 19 2018, 1:21 AM

Change 480682 merged by jenkins-bot:
[wikidata/query/gui@master] Drop copyright.html and link to wikidata instead

https://gerrit.wikimedia.org/r/480682

gerritbot added a comment.Dec 19 2018, 1:24 AM

Change 480684 had a related patch set uploaded (by WDQSGuiBuilder; owner: WDQSGuiBuilder):
[wikidata/query/gui-deploy@production] Merging from e0923f891b09dcdf400ffcbf259f77b529bf4cda:

https://gerrit.wikimedia.org/r/480684

gerritbot added a comment.Dec 19 2018, 6:02 AM

Change 480684 merged by Smalyshev:
[wikidata/query/gui-deploy@production] Merging from e0923f891b09dcdf400ffcbf259f77b529bf4cda:

https://gerrit.wikimedia.org/r/480684

Addshore moved this task from incoming to in progress on the Wikidata board.Dec 19 2018, 12:47 PM
Addshore closed this task as Resolved.Jan 7 2019, 5:47 PM
Addshore moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Addshore subscribed.

Also made a PR for making this more easily configurable in the docker image

https://github.com/wmde/wikibase-docker/pull/56

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL