Maniphest T194371

Special:RedirectEntity "non empty item" i18n message doesn't make sense for other entity types
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Addshore
	May 10 2018, 9:56 AM

Description

Special:RedirectEntity can be tried for all entities (it is not specific to items)
However when testing with 2 lexeme IDs I get an odd error message specifying that they are not empty items.

The i18n message needs to be updated to switch from the word "item" to "entity"

Screenshot:

BDD
GIVEN I am on Special:RedirectEntity
AND I try to merge two Lexemes
THEN I should get the error message "Error: Can't create redirect on non empty entity L1234."

Details

	Subject	Repo	Branch	Lines +/-
	Internationalise messages from RedirectCreationException	mediawiki/extensions/Wikibase	master	+95 -24

Customize query in gerrit

Event Timeline

Addshore created this task.May 10 2018, 9:56 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 10 2018, 9:56 AM

Addshore renamed this task from Special:RedirectEntity "non empty item" i18n message doesn't make sense for Lexemes to Special:RedirectEntity "non empty item" i18n message doesn't make sense for other entity types.May 10 2018, 9:57 AM

Lydia_Pintscher moved this task from incoming to features/bugs for next release (editor experience improvements) on the Wikidata Lexicographical data board.May 14 2018, 8:05 PM

Lydia_Pintscher triaged this task as Low priority.May 27 2018, 3:55 PM

Lydia_Pintscher added a project: patch-welcome.

• Pablo-WMDE set the point value for this task to 1.Jun 12 2018, 12:40 PM

Lydia_Pintscher updated the task description. (Show Details)Jun 24 2018, 10:05 AM

• Pablo-WMDE added a project: Wikidata-Editor-Experience-Improvements-Iteration2.Jun 27 2018, 9:40 AM

• Pablo-WMDE removed a project: patch-welcome.

• Vvjjkkii renamed this task from Special:RedirectEntity "non empty item" i18n message doesn't make sense for other entity types to 47caaaaaaa.Jul 1 2018, 1:10 AM

• Vvjjkkii raised the priority of this task from Low to High.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed the point value for this task.

• Vvjjkkii removed a subscriber: Aklapper.

CommunityTechBot renamed this task from 47caaaaaaa to Special:RedirectEntity "non empty item" i18n message doesn't make sense for other entity types.Jul 2 2018, 4:51 AM

CommunityTechBot lowered the priority of this task from High to Low.

CommunityTechBot set the point value for this task to 1.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added a subscriber: Aklapper.

Tarrow claimed this task.Jul 10 2018, 7:45 AM

Tarrow moved this task from To Do to Doing on the Wikidata-Editor-Experience-Improvements-Iteration2 board.

Change 445086 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] Change hardcoded RedirectionCreation i18 exception messsage

https://gerrit.wikimedia.org/r/445086

gerritbot added a project: Patch-For-Review.Jul 11 2018, 7:47 AM

Tarrow moved this task from Doing to Peer Review on the Wikidata-Editor-Experience-Improvements-Iteration2 board.Jul 11 2018, 7:47 AM

• RazShuty added a project: Wikidata-Editor-Experience-Improvements-Iteration3.Jul 11 2018, 9:27 AM

• RazShuty moved this task from To Do to Peer Review on the Wikidata-Editor-Experience-Improvements-Iteration3 board.

Tarrow moved this task from Peer Review to Doing on the Wikidata-Editor-Experience-Improvements-Iteration3 board.Jul 12 2018, 6:48 AM

• Pablo-WMDE claimed this task.Jul 16 2018, 2:40 PM

• Pablo-WMDE added a subscriber: Tarrow.

• Pablo-WMDE removed • Pablo-WMDE as the assignee of this task.Jul 17 2018, 8:48 AM

• Pablo-WMDE moved this task from Doing to Test (Product Review) on the Wikidata-Editor-Experience-Improvements-Iteration3 board.

• Pablo-WMDE moved this task from Test (Product Review) to Peer Review on the Wikidata-Editor-Experience-Improvements-Iteration3 board.

• Pablo-WMDE subscribed.