Page MenuHomePhabricator

VisualDiff: Re-consider using converter's "clipboard mode" to speed up rendering
Closed, ResolvedPublic8 Estimated Story Points

Description

We currently using "clipboard mode", instead of "parsoid mode" for rendering the visual diff, as the former produces full view HTML, however it also generates (at some expense) data model information that is not really required for view-only modes (such as the visual diff, or previews), in particular reference nodes can be particular slow, especially when the converter is invoked multiple times, as is the case in the visual diff.

We should introduce a "preview mode" to the converter so that nodes can quickly render view-only HTML. This would also allow us to fix the issue with some nodes not rendering anything meaningful (T170134/T170107).

Event Timeline

Deskana triaged this task as Medium priority.
Vvjjkkii renamed this task from VisualDiff: Re-consider using converter's "clipboard mode" to speed up rendering to 16caaaaaaa.Jul 1 2018, 1:10 AM
Vvjjkkii reopened this task as Open.
Vvjjkkii removed Esanders as the assignee of this task.
Vvjjkkii raised the priority of this task from Medium to High.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed the point value for this task.
Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from 16caaaaaaa to VisualDiff: Re-consider using converter's "clipboard mode" to speed up rendering.Jul 2 2018, 3:15 PM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to Esanders.
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot set the point value for this task to 8.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot added a subscriber: Aklapper.