Maniphest T194544

Italicized titles can get clipped on mobile
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	kaldari
	May 11 2018, 9:37 PM

Description

The title can get clipped if it extends beyond the box for the heading-holder. See the edge of the 'J' in the screenshot:

This is caused by:
heading-holder { overflow: hidden; }

=== Replication steps
Visit https://en.m.wikipedia.org/wiki/Jane_and_the_Dragon with Chrome. Note J is clipped.

==== Developer notes
The affecting style is located in `skins.minerva.base.styles` module. 
The problem is that the title is italicized. The following CSS will make it go away:

h1 i {

padding-left: 1px;

}

Alternatively, we can remove the overflow:hdidden on heading-holder

Details

	Subject	Repo	Branch	Lines +/-
	Fix: don't truncate the article title	mediawiki/skins/MinervaNeue	master	+0 -1

Customize query in gerrit

Event Timeline

kaldari created this task.May 11 2018, 9:37 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 11 2018, 9:37 PM

@kaldari - could you share the device/os/browser that you are using? I tried some titles on my machine and it works well (Debian + Chrome 66)

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.May 29 2018, 3:25 PM

Can reproduce on https://en.m.wikipedia.org/wiki/Jane_and_the_Dragon (OSX Chrome). The italic tag is the problem.

Jdlrobson renamed this task from Title can get clipped on mobile to Italicized titles can get clipped on mobile.May 29 2018, 4:09 PM

Jdlrobson updated the task description. (Show Details)May 29 2018, 4:28 PM

pmiazga set the point value for this task to 2.May 29 2018, 4:30 PM

We'll need to do some code archeology to determine whether the overflow hidden can be removed but there's two easy fixes here.

• alexhollender_WMF subscribed.May 29 2018, 4:37 PM

I think this problem is affecting non-italicized titles containing the letter J as well. I'm seeing the following on both Chrome and Safari on https://en.m.wikipedia.org/wiki/Jailhouse_Rock:

current	width 2px padding-left on h1

Jdlrobson moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.May 29 2018, 5:19 PM

ovasileva triaged this task as Medium priority.May 30 2018, 2:21 PM

• Niedzielski awarded a token.Jun 6 2018, 2:43 PM

ovasileva added a project: Readers-Web-Kanbanana-Board-Old.Jun 6 2018, 5:10 PM

ovasileva moved this task from Upcoming to 2017-18 Q4 on the Web-Team-Backlog board.

• Niedzielski claimed this task.Jun 13 2018, 2:04 PM

• Niedzielski moved this task from To Do to Doing on the Readers-Web-Kanbanana-Board-Old board.

• Niedzielski removed • Niedzielski as the assignee of this task.Jun 13 2018, 2:31 PM

• Niedzielski moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.

• Niedzielski subscribed.

Jdlrobson moved this task from Backlog to Bugs on the MinervaNeue board.Jun 13 2018, 3:55 PM

Is there a patch? I don't see one...

Change 440182 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/skins/MinervaNeue@master] Fix: don't truncate the article title

https://gerrit.wikimedia.org/r/440182

gerritbot added a project: Patch-For-Review.Jun 13 2018, 6:51 PM

Is that all you care about? Patches?

Jdlrobson moved this task from Needs Code Review to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.Jun 13 2018, 6:52 PM

Change 440182 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Fix: don't truncate the article title

https://gerrit.wikimedia.org/r/440182

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)).Jun 13 2018, 8:00 PM

Live on both staging and the beta cluster. I've created https://en.m.wikipedia.beta.wmflabs.org/wiki/Italic_title to aid testing.

Macro farmer: farm fresh

• alexhollender_WMF reassigned this task from • alexhollender_WMF to ovasileva.Jun 14 2018, 5:07 PM

• alexhollender_WMF moved this task from Needs Design Review to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.

all done, also tested https://en.m.wikipedia.beta.wmflabs.org/wiki/Jjjjjj

• Vvjjkkii renamed this task from Italicized titles can get clipped on mobile to b3caaaaaaa.Jul 1 2018, 1:10 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii removed ovasileva as the assignee of this task.

• Vvjjkkii raised the priority of this task from Medium to High.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed the point value for this task.

• Vvjjkkii edited subscribers, added: ovasileva; removed: gerritbot, Aklapper.

TerraCodes renamed this task from b3caaaaaaa to Italicized titles can get clipped on mobile.Jul 1 2018, 2:38 AM

TerraCodes closed this task as Resolved.

TerraCodes assigned this task to ovasileva.

TerraCodes lowered the priority of this task from High to Medium.

TerraCodes removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

TerraCodes updated the task description. (Show Details)

TerraCodes set the point value for this task to 2.

TerraCodes edited subscribers, added: Aklapper, gerritbot; removed: ovasileva.

	F18598622: Screen Shot 2018-05-29 at 12.34.06 PM.png
	May 29 2018, 4:40 PM

	F18598619: Screen Shot 2018-05-29 at 12.34.29 PM.png
	May 29 2018, 4:40 PM

	F18173805: Screen Shot 2018-05-11 at 1.57.30 PM.png
	May 11 2018, 9:37 PM

Italicized titles can get clipped on mobileClosed, ResolvedPublic2 Estimated Story PointsActions

Description

Details

Event Timeline

Italicized titles can get clipped on mobile
Closed, ResolvedPublic2 Estimated Story Points
Actions