Page MenuHomePhabricator
Create Task
Maniphest T194771

Add "mis" language code to the list of language code options on Special:NewLexeme
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Problem:
We allow editors to use mis as a language code for entering languages we don't have in our list. However we only allow this on the Lexeme page, not when creating a new Lexeme via Special:NewLexeme. This should be possible there too.

BDD

GIVEN I am on Special:NewLexeme page
AND   I pick a language item without the language code property set
WHEN  I open the lemma language dropdown
THEN  There is a "Other (mis)" option in the list

Note: this does not include extended language codes such as mis-x-Q321

Details

SubjectRepoBranchLines +/-
NewLexeme: allow lexeme creation with 'mis' languagemediawiki/extensions/WikibaseLexememaster+341 -40
selenium: test creation of new lexemesmediawiki/extensions/WikibaseLexememaster+185 -19
selenium: ComponentInteraction mixin, convenient way to addmediawiki/extensions/Wikibasemaster+34 -0
selenium: use util method to create test stringsmediawiki/extensions/WikibaseLexememaster+5 -11
Customize query in gerrit

Related Objects

Mentioned In
T199991: Suggester for language of lemma shows not translated language names
rEWLE0fd45a0fbb04: NewLexeme: allow lexeme creation with 'mis' language
rEWLE150a7402c9fe: NewLexeme: allow lexeme creation with 'mis' language
rEWLEd218dd7f7e1b: NewLexeme: allow lexeme creation with 'mis' language
rEWLEe402cc87bbc4: NewLexeme: allow lexeme creation with 'mis' language
rEWLEcd1977974beb: NewLexeme: allow lexeme creation with 'mis' language
rEWLE32a957fa6e35: NewLexeme: allow lexeme creation with 'mis' language
rEWLE756a845ae762: NewLexeme: allow lexeme creation with 'mis' language
rEWLEe4ba59fffe9d: selenium: test creation of new lexemes
rEWLE49be5ae7cda2: NewLexeme: allow lexeme creation with 'mis' language
rEWLE71be4af191eb: NewLexeme: allow lexeme creation with 'mis' language
rEWLE6f9c1d06e2d6: NewLexeme: allow lexeme creation with 'mis' language
rEWLE48f8ee2a1884: selenium: test creation of new lexemes
rEWLEe1242a926fee: selenium: test creation of new lexemes
rEWLE23f2a37f925c: selenium: test creation of new lexemes
rEWLE6cc62929a357: NewLexeme: allow lexeme creation with 'mis' language
rEWLE439efe31b71b: NewLexeme: allow lexeme creation with 'mis' language
rEWLE9ae956d56218: selenium: test creation of new lexemes
rEWLEebc9060b3647: selenium: test creation of new lexemes
rEWLEfe5695bc82f7: NewLexeme: allow lexeme creation with 'mis' language
rEWLEafffbf1a9dfe: NewLexeme: allow lexeme creation with 'mis' language
rEWLE0114096b8c20: NewLexeme: allow lexeme creation with 'mis' language
rEWLE01ee7763b4bd: NewLexeme: allow lexeme creation with 'mis' language
rEWLEdf61e10127d8: selenium: test creation of new lexemes
rEWLE30a8a82e1acc: selenium: test creation of new lexemes
rEWLE65ad9d5f589f: selenium: test creation of new lexemes
rEWLEe985fa327f43: NewLexeme: allow lexeme creation with 'mis' language
rEWLEdb1d952b82e3: selenium: test creation of new lexemes
rEWLE68c0537c44bb: selenium: test creation of new lexemes
rEWLE17fe29762040: selenium: test creation of new lexemes
rEWLE62b0688a63f3: selenium: test creation of new lexemes
rEWLE862bf593077c: selenium: use util method to create test strings
Mentioned Here
T194347: [Bug] Language of Lemma Box doesn't appear after failed submit of Special:NewLexeme
T124758: [Story] Show all available languages in monolingual text value's suggester

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 15 2018, 3:25 PM
WMDE-leszek triaged this task as High priority.May 15 2018, 3:25 PM
WMDE-leszek set the point value for this task to 5.
WMDE-leszek moved this task from incoming to features/bugs for next release (editor experience improvements) on the Wikidata Lexicographical data board.
WMDE-leszek renamed this task from Add "mis" language code to the list of lemma language code options on Special:NewLexeme to Add "mis" language code to the list of language code options on Special:NewLexeme.May 15 2018, 3:30 PM
Lydia_Pintscher updated the task description. (Show Details)Jun 24 2018, 10:22 AM
Jakob_WMDE updated the task description. (Show Details)Jun 25 2018, 1:06 PM
Lydia_Pintscher updated the task description. (Show Details)Jun 25 2018, 1:40 PM
• Pablo-WMDE added a project: Wikidata-Editor-Experience-Improvements-Iteration2.Jun 27 2018, 9:38 AM
• Pablo-WMDE updated the task description. (Show Details)Jun 27 2018, 10:33 AM
• Pablo-WMDE added subscribers: Lydia_Pintscher, • Pablo-WMDE.Jun 27 2018, 10:46 AM
  • Use WikibaseLexemeTermLanguages service in SpecialNewLexeme,
  • inject into HTMLContentLanguageField somehow - consider making our own version of it
  • provide translation for "mis" language code <- @Lydia_Pintscher What should this even read? And in which language? (user language)
• Vvjjkkii renamed this task from Add "mis" language code to the list of language code options on Special:NewLexeme to 0wcaaaaaaa.Jul 1 2018, 1:09 AM
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed the point value for this task.
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from 0wcaaaaaaa to Add "mis" language code to the list of language code options on Special:NewLexeme.Jul 2 2018, 6:52 AM
CommunityTechBot set the point value for this task to 5.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: Aklapper.
Lydia_Pintscher added a comment.Jul 2 2018, 10:17 AM
In T194771#4318748, @Pablo-WMDE wrote:
  • provide translation for "mis" language code <- @Lydia_Pintscher What should this even read? And in which language? (user language)

This is the language code and afaik they are not translated. de is de anywhere for example.

Lydia_Pintscher updated the task description. (Show Details)Jul 2 2018, 10:17 AM
• Pablo-WMDE added a comment.Jul 2 2018, 10:21 AM

So "other" (and the translation of "other" in all languages) is to be used as the name of the language - as shown in BDD.

• Greta_Doci_WMDE moved this task from incoming to ready to go on the Wikidata board.Jul 4 2018, 8:56 AM
• Pablo-WMDE added a comment.Jul 5 2018, 8:30 AM

I shall mention T124758 and this code now that I found it.

• Pablo-WMDE claimed this task.Jul 5 2018, 10:02 AM
• Pablo-WMDE moved this task from To Do to Doing on the Wikidata-Editor-Experience-Improvements-Iteration2 board.
gerritbot subscribed.Jul 5 2018, 10:30 AM

Change 443938 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] selenium: use util method to create test strings

https://gerrit.wikimedia.org/r/443938

gerritbot added a project: Patch-For-Review.Jul 5 2018, 10:30 AM
• Pablo-WMDE mentioned this in rEWLE862bf593077c: selenium: use util method to create test strings.Jul 5 2018, 10:30 AM
gerritbot added a comment.Jul 5 2018, 1:35 PM

Change 443938 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] selenium: use util method to create test strings

https://gerrit.wikimedia.org/r/443938

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jul 5 2018, 2:00 PM
gerritbot added a comment.Jul 5 2018, 3:28 PM

Change 444000 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] selenium: test creation of new lexemes

https://gerrit.wikimedia.org/r/444000

• Pablo-WMDE mentioned this in rEWLE62b0688a63f3: selenium: test creation of new lexemes.Jul 5 2018, 3:30 PM
• Pablo-WMDE mentioned this in rEWLE17fe29762040: selenium: test creation of new lexemes.Jul 6 2018, 10:15 AM
• Pablo-WMDE mentioned this in rEWLE68c0537c44bb: selenium: test creation of new lexemes.Jul 6 2018, 11:12 AM
• Pablo-WMDE mentioned this in rEWLEdb1d952b82e3: selenium: test creation of new lexemes.Jul 6 2018, 1:51 PM
gerritbot added a comment.Jul 6 2018, 3:26 PM

Change 444244 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] NewLexeme: allow lexeme creation with 'mis' language

https://gerrit.wikimedia.org/r/444244

• Pablo-WMDE mentioned this in rEWLEe985fa327f43: NewLexeme: allow lexeme creation with 'mis' language.Jul 6 2018, 3:27 PM
• Pablo-WMDE mentioned this in rEWLE65ad9d5f589f: selenium: test creation of new lexemes.Jul 9 2018, 10:46 AM
• Pablo-WMDE mentioned this in rEWLE30a8a82e1acc: selenium: test creation of new lexemes.Jul 9 2018, 10:51 AM
• Pablo-WMDE mentioned this in rEWLEdf61e10127d8: selenium: test creation of new lexemes.Jul 9 2018, 11:56 AM
• Pablo-WMDE mentioned this in rEWLE01ee7763b4bd: NewLexeme: allow lexeme creation with 'mis' language.Jul 9 2018, 12:15 PM
• Pablo-WMDE added a comment.Jul 9 2018, 2:13 PM

@Lydia_Pintscher There exists code to support the assumption that on Special:NexLexeme the lemma language field is supposed to have a default value (infered from the form object, presumably userlang). Is that a known/required feature? It does not appear to be working (fully), e.g. "en" is selected from the start if you look at the dropdown but one can not submit the form like that.
Now we are working very close by and have to decide to fix (and test) or drop it.

Lydia_Pintscher added a comment.Jul 10 2018, 7:59 AM

Let's remove it. In most cases people shouldn't be asked to fill in the Lemma language. In the few cases where they are asked they are probably working with some special language and the uselang might not be the right thing.

• Pablo-WMDE mentioned this in rEWLE0114096b8c20: NewLexeme: allow lexeme creation with 'mis' language.Jul 10 2018, 8:19 AM
• Pablo-WMDE mentioned this in rEWLEafffbf1a9dfe: NewLexeme: allow lexeme creation with 'mis' language.Jul 10 2018, 8:29 AM
• Pablo-WMDE mentioned this in rEWLEfe5695bc82f7: NewLexeme: allow lexeme creation with 'mis' language.Jul 10 2018, 8:33 AM
• Pablo-WMDE added a comment.Jul 10 2018, 8:42 AM

@Lydia_Pintscher Thanks for the previous answer. Another question. Given we add an option (mis) to the list of languages - is there a specification on how the languages should be ordered (in the dropdown)? Alphabetically? By key or translation? <- devs should have asked this question earlier!

Lydia_Pintscher added a comment.Jul 10 2018, 9:41 AM

Doh! Good question ;-) Let's add it at the end.

gerritbot added a comment.Jul 10 2018, 10:29 AM

Change 444836 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] selenium: form widget mixin, convenient way to add

https://gerrit.wikimedia.org/r/444836

• Pablo-WMDE mentioned this in rEWLEebc9060b3647: selenium: test creation of new lexemes.Jul 10 2018, 10:35 AM
• Pablo-WMDE mentioned this in rEWLE9ae956d56218: selenium: test creation of new lexemes.Jul 10 2018, 10:46 AM
• Pablo-WMDE mentioned this in rEWLE439efe31b71b: NewLexeme: allow lexeme creation with 'mis' language.Jul 10 2018, 10:50 AM
• Pablo-WMDE mentioned this in rEWLE6cc62929a357: NewLexeme: allow lexeme creation with 'mis' language.Jul 10 2018, 2:48 PM
• RazShuty added a project: Wikidata-Editor-Experience-Improvements-Iteration3.Jul 11 2018, 9:25 AM
• RazShuty moved this task from To Do to Doing on the Wikidata-Editor-Experience-Improvements-Iteration3 board.
• Pablo-WMDE mentioned this in rEWLE23f2a37f925c: selenium: test creation of new lexemes.Jul 11 2018, 1:38 PM
• Pablo-WMDE mentioned this in rEWLEe1242a926fee: selenium: test creation of new lexemes.Jul 11 2018, 1:56 PM
• Pablo-WMDE mentioned this in rEWLE48f8ee2a1884: selenium: test creation of new lexemes.Jul 11 2018, 2:05 PM
• Pablo-WMDE mentioned this in rEWLE6f9c1d06e2d6: NewLexeme: allow lexeme creation with 'mis' language.Jul 11 2018, 2:09 PM
• Pablo-WMDE mentioned this in rEWLE71be4af191eb: NewLexeme: allow lexeme creation with 'mis' language.
gerritbot added a comment.Jul 11 2018, 2:31 PM

Change 444836 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] selenium: ComponentInteraction mixin, convenient way to add

https://gerrit.wikimedia.org/r/444836

• Pablo-WMDE added a comment.Jul 11 2018, 2:33 PM

T194347 will not be resolved by this!

• Pablo-WMDE mentioned this in rEWLE49be5ae7cda2: NewLexeme: allow lexeme creation with 'mis' language.Jul 11 2018, 2:36 PM
ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jul 11 2018, 3:00 PM
• Pablo-WMDE mentioned this in rEWLEe4ba59fffe9d: selenium: test creation of new lexemes.Jul 12 2018, 9:43 AM
gerritbot added a comment.Jul 12 2018, 10:00 AM

Change 444000 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] selenium: test creation of new lexemes

https://gerrit.wikimedia.org/r/444000

• Pablo-WMDE mentioned this in rEWLE756a845ae762: NewLexeme: allow lexeme creation with 'mis' language.Jul 12 2018, 1:44 PM
• Pablo-WMDE mentioned this in rEWLE32a957fa6e35: NewLexeme: allow lexeme creation with 'mis' language.Jul 13 2018, 10:50 AM
• Pablo-WMDE mentioned this in rEWLEcd1977974beb: NewLexeme: allow lexeme creation with 'mis' language.Jul 13 2018, 10:57 AM
• Pablo-WMDE mentioned this in rEWLEe402cc87bbc4: NewLexeme: allow lexeme creation with 'mis' language.Jul 13 2018, 11:03 AM
• Pablo-WMDE mentioned this in rEWLEd218dd7f7e1b: NewLexeme: allow lexeme creation with 'mis' language.Jul 13 2018, 11:28 AM
• Pablo-WMDE mentioned this in rEWLE150a7402c9fe: NewLexeme: allow lexeme creation with 'mis' language.Jul 13 2018, 11:34 AM
• Pablo-WMDE mentioned this in rEWLE0fd45a0fbb04: NewLexeme: allow lexeme creation with 'mis' language.Jul 13 2018, 11:38 AM
• Pablo-WMDE removed • Pablo-WMDE as the assignee of this task.Jul 13 2018, 11:53 AM
• Pablo-WMDE moved this task from Doing to Peer Review on the Wikidata-Editor-Experience-Improvements-Iteration3 board.
Lydia_Pintscher moved this task from ready to go to in progress on the Wikidata board.Jul 13 2018, 1:15 PM
Jakob_WMDE moved this task from Peer Review to Test (Product Review) on the Wikidata-Editor-Experience-Improvements-Iteration3 board.Jul 16 2018, 4:05 PM
gerritbot added a comment.Jul 16 2018, 4:12 PM

Change 444244 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] NewLexeme: allow lexeme creation with 'mis' language

https://gerrit.wikimedia.org/r/444244

• Pablo-WMDE mentioned this in T199991: Suggester for language of lemma shows not translated language names.Jul 19 2018, 1:49 PM
WMDE-leszek added a project: Wikidata-Editor-Experience-Improvements-Iteration4.Jul 25 2018, 9:38 AM
WMDE-leszek moved this task from To Do to Test (Product Review) on the Wikidata-Editor-Experience-Improvements-Iteration4 board.Jul 25 2018, 9:41 AM
Lydia_Pintscher closed this task as Resolved.Jul 26 2018, 4:09 PM
Lydia_Pintscher claimed this task.
Lydia_Pintscher moved this task from Test (Product Review) to Done on the Wikidata-Editor-Experience-Improvements-Iteration4 board.

\o/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits