Page MenuHomePhabricator
Create Task
Maniphest T195323

Visual Editor changes dialog hangs when clicking on preview on pages without categories
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

On hu.wiktionary the summary window hangs when clicking on preview. The traceback from the console seems to explain it pretty well:

This page is using the deprecated ResourceLoader module "jquery.ui.widget".
load.php:31:942
This page is using the deprecated ResourceLoader module "jquery.ui.core".
Please use OOUI instead.
load.php:1:80
TypeError: $.Deferred.resolve is not a function[Learn More]
load.php:668:454
ve.ui.MWSaveDialog.prototype.showPreview
https://hu.wiktionary.org/w/load.php:668:454
ve.init.mw.ArticleTarget.prototype.onSaveDialogPreview/<
https://hu.wiktionary.org/w/load.php:630:164
fire
https://hu.wiktionary.org/w/load.php:46:599
fireWith
https://hu.wiktionary.org/w/load.php:47:824
Deferred/</deferred[tuple[0]]
https://hu.wiktionary.org/w/load.php:51:312
ajax/xhr<
https://hu.wiktionary.org/w/load.php:501:398
fire
https://hu.wiktionary.org/w/load.php:46:599
fireWith
https://hu.wiktionary.org/w/load.php:47:824
done
https://hu.wiktionary.org/w/load.php:126:165
callback/<

Details

SubjectRepoBranchLines +/-
MWSaveDialog: Fix typo in no-categories branchmediawiki/extensions/VisualEditorwmf/1.32.0-wmf.4+1 -1
MWSaveDialog: Fix typo in no-categories branchmediawiki/extensions/VisualEditorwmf/1.32.0-wmf.5+1 -1
MWSaveDialog: Fix typo in no-categories branchmediawiki/extensions/VisualEditormaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Tobias1984 created this task.May 22 2018, 7:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 22 2018, 7:19 PM
Schnark subscribed.May 23 2018, 7:12 AM

According to the code (https://phabricator.wikimedia.org/diffusion/EVED/browse/master/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js;5330e42dc7ae09abf505a2494e22c6e1768331ad$277) this only happens on pages without categories, but when it happens it is really annoying.

gerritbot subscribed.May 23 2018, 10:19 AM

Change 434657 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] MWSaveDialog: Fix typo in no-categories branch

https://gerrit.wikimedia.org/r/434657

gerritbot added a project: Patch-For-Review.May 23 2018, 10:19 AM
• Esanders claimed this task.May 23 2018, 10:19 AM
• Esanders triaged this task as High priority.
• Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.
• Esanders set the point value for this task to 1.
• Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.
Jdforrester-WMF renamed this task from Visual Editor changes dialog hangs when clicking on previw to Visual Editor changes dialog hangs when clicking on previw on pages without categories.May 23 2018, 4:45 PM
Jdforrester-WMF added a project: VisualEditor-MediaWiki.
gerritbot added a comment.May 23 2018, 4:52 PM

Change 434657 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] MWSaveDialog: Fix typo in no-categories branch

https://gerrit.wikimedia.org/r/434657

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)).May 23 2018, 5:00 PM
gerritbot added a comment.May 23 2018, 5:21 PM

Change 434745 had a related patch set uploaded (by Jforrester; owner: Esanders):
[mediawiki/extensions/VisualEditor@wmf/1.32.0-wmf.5] MWSaveDialog: Fix typo in no-categories branch

https://gerrit.wikimedia.org/r/434745

gerritbot added a comment.May 23 2018, 5:22 PM

Change 434746 had a related patch set uploaded (by Jforrester; owner: Esanders):
[mediawiki/extensions/VisualEditor@wmf/1.32.0-wmf.4] MWSaveDialog: Fix typo in no-categories branch

https://gerrit.wikimedia.org/r/434746

Stryn mentioned this in T195394: Previewing an edit makes the page unresponsive?.May 23 2018, 6:16 PM
• Esanders renamed this task from Visual Editor changes dialog hangs when clicking on previw on pages without categories to Visual Editor changes dialog hangs when clicking on preview on pages without categories.May 23 2018, 7:16 PM
gerritbot added a comment.May 23 2018, 11:18 PM

Change 434745 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.32.0-wmf.5] MWSaveDialog: Fix typo in no-categories branch

https://gerrit.wikimedia.org/r/434745

Stashbot subscribed.May 23 2018, 11:45 PM

Mentioned in SAL (#wikimedia-operations) [2018-05-23T23:45:01Z] <ebernhardson@tin> Synchronized php-1.32.0-wmf.5/extensions/VisualEditor/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js: SWAT: T195323: MWSaveDialog: Fix typo in no-categories branch (duration: 01m 08s)

gerritbot added a comment.May 23 2018, 11:55 PM

Change 434746 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.32.0-wmf.4] MWSaveDialog: Fix typo in no-categories branch

https://gerrit.wikimedia.org/r/434746

Stashbot added a comment.May 24 2018, 12:00 AM

Mentioned in SAL (#wikimedia-operations) [2018-05-24T00:00:37Z] <ebernhardson@tin> Synchronized php-1.32.0-wmf.4/extensions/VisualEditor/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js: SWAT: T195323: MWSaveDialog: Fix typo in no-categories branch (duration: 01m 07s)

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)); removed MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)).May 24 2018, 12:01 AM
Jdforrester-WMF removed a project: Patch-For-Review.May 24 2018, 12:08 AM
Jdforrester-WMF subscribed.

Now hot-deployed to production's wmf.4 and wmf.5 branches.

• Deskana closed this task as Resolved.May 24 2018, 8:45 AM
• Deskana moved this task from Code review to Product owner review on the VisualEditor (Current work) board.
• Deskana merged a task: T195394: Previewing an edit makes the page unresponsive?.
• Deskana added subscribers: • Elitre, Stryn, • Deskana.
• Elitre awarded a token.May 24 2018, 9:51 AM
• Vvjjkkii renamed this task from Visual Editor changes dialog hangs when clicking on preview on pages without categories to ohcaaaaaaa.Jul 1 2018, 1:08 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed • Esanders as the assignee of this task.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed the point value for this task.
• Vvjjkkii edited subscribers, added: • Esanders; removed: gerritbot, Aklapper.
CommunityTechBot renamed this task from ohcaaaaaaa to Visual Editor changes dialog hangs when clicking on preview on pages without categories.Jul 2 2018, 1:37 PM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to • Esanders.
CommunityTechBot set the point value for this task to 1.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot edited subscribers, added: gerritbot, Aklapper; removed: • Esanders.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits