Page MenuHomePhabricator
Create Task
Maniphest T195485

Don’t select term_entity_type in TermSqlIndex
Closed, ResolvedPublic
Actions

Description

Some queries of TermSqlIndex::getMatchingTerms() are still selecting the term_entity_type even though it should no longer be used, and this seems to negatively affect SQL performance.

Details

SubjectRepoBranchLines +/-
Stop selecting term_entity_typemediawiki/extensions/Wikibasemaster+0 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE triaged this task as High priority.May 24 2018, 1:47 PM
Lucas_Werkmeister_WMDE created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 24 2018, 1:47 PM
gerritbot subscribed.May 24 2018, 2:06 PM

Change 434919 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Stop selecting term_entity_type

https://gerrit.wikimedia.org/r/434919

gerritbot added a project: Patch-For-Review.May 24 2018, 2:06 PM
gerritbot added a comment.May 30 2018, 1:42 PM

Change 434919 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Stop selecting term_entity_type

https://gerrit.wikimedia.org/r/434919

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)).May 30 2018, 5:02 PM
• Vvjjkkii renamed this task from Don’t select term_entity_type in TermSqlIndex to 6ccaaaaaaa.Jul 1 2018, 1:08 AM
• Vvjjkkii removed Lucas_Werkmeister_WMDE as the assignee of this task.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from 6ccaaaaaaa to Don’t select term_entity_type in TermSqlIndex.Jul 2 2018, 1:28 PM
CommunityTechBot assigned this task to Lucas_Werkmeister_WMDE.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
Ladsgroup subscribed.Dec 3 2018, 10:36 PM

Isn't this done?

Lucas_Werkmeister_WMDE closed this task as Resolved.Dec 4 2018, 10:43 AM

I think so, yes.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL