Maniphest T195512

link in diff with statement linking to Form
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Statements with datatype Form in diffs should link to the referenced Form.

Given I am on a diff page
AND the change that was made includes a statement linking to a Form
THEN the Form should be linked to the Form

Info:

LexemeDiffVisualizerIntegrationTest might be a start

Details

	Subject	Repo	Branch	Lines +/-
	Hamcrest integration: avoid risky tests	mediawiki/extensions/WikibaseLexeme	master	+17 -25
	Use FormIdHtmlFormatter if format is 'text/html; disposition=diff'	mediawiki/extensions/WikibaseLexeme	master	+54 -1

Customize query in gerrit

Related Objects

Mentioned In: rEWLE817c58739218: Use FormIdHtmlFormatter if format is 'text/html; disposition=diff'

Event Timeline

Lydia_Pintscher created this task.May 24 2018, 5:14 PM

Restricted Application added a project: Wikidata. · View Herald TranscriptMay 24 2018, 5:14 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Lydia_Pintscher triaged this task as Medium priority.May 27 2018, 3:58 PM

• Pablo-WMDE set the point value for this task to 3.Jun 6 2018, 1:57 PM

• Pablo-WMDE updated the task description. (Show Details)

Tarrow claimed this task.Jun 7 2018, 11:36 AM

Tarrow added a project: Wikidata-Editor-Experience-Improvements-Iteration0.

Tarrow moved this task from To Do to Doing on the Wikidata-Editor-Experience-Improvements-Iteration0 board.

Change 438266 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/WikibaseLexeme@master] Use FormIdHtmlFormatter if format is 'text/html; disposition=diff'

https://gerrit.wikimedia.org/r/438266

gerritbot added a project: Patch-For-Review.Jun 8 2018, 3:30 PM

Tarrow mentioned this in rEWLE817c58739218: Use FormIdHtmlFormatter if format is 'text/html; disposition=diff'.Jun 8 2018, 3:32 PM

Tarrow moved this task from Doing to Peer Review on the Wikidata-Editor-Experience-Improvements-Iteration0 board.Jun 11 2018, 8:24 AM

Change 439549 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Hamcrest integration: avoid risky tests

https://gerrit.wikimedia.org/r/439549

Tarrow moved this task from Peer Review to Test (Product Review) on the Wikidata-Editor-Experience-Improvements-Iteration0 board.Jun 11 2018, 3:12 PM

Change 438266 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Use FormIdHtmlFormatter if format is 'text/html; disposition=diff'

https://gerrit.wikimedia.org/r/438266

Change 439549 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Hamcrest integration: avoid risky tests

https://gerrit.wikimedia.org/r/439549

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)).Jun 11 2018, 4:00 PM

Jakob_WMDE added a project: Wikidata-Editor-Experience-Improvements-Iteration1.Jun 13 2018, 9:18 AM

• Pablo-WMDE moved this task from To Do to Test (Product Review) on the Wikidata-Editor-Experience-Improvements-Iteration1 board.Jun 13 2018, 9:25 AM

\o/
Tested here: https://wikidata.beta.wmflabs.org/w/index.php?title=Lexeme:L1&diff=1031259&oldid=1028024

@Lea_Lacroix_WMDE FYI

• Vvjjkkii renamed this task from link in diff with statement linking to Form to fccaaaaaaa.Jul 1 2018, 1:09 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii removed Tarrow as the assignee of this task.

• Vvjjkkii raised the priority of this task from Medium to High.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed the point value for this task.

• Vvjjkkii edited subscribers, added: Tarrow; removed: gerritbot, Aklapper.

CommunityTechBot renamed this task from fccaaaaaaa to link in diff with statement linking to Form.Jul 2 2018, 4:28 AM

CommunityTechBot closed this task as Resolved.

CommunityTechBot assigned this task to Tarrow.

CommunityTechBot lowered the priority of this task from High to Medium.

CommunityTechBot set the point value for this task to 3.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot edited subscribers, added: gerritbot, Aklapper; removed: Tarrow.

	F18511199: Screenshot_20180524_191046.png
	May 24 2018, 5:14 PM

link in diff with statement linking to FormClosed, ResolvedPublic3 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

link in diff with statement linking to Form
Closed, ResolvedPublic3 Estimated Story Points
Actions