Page MenuHomePhabricator
Create Task
Maniphest T196480

[NSFileRepo] QUnit test "mediawiki.Title fails
Closed, ResolvedPublic
Actions

Description

With NSFileRepo and Lockdown extensions installed, a QUnit test is failling:

SUMMARY:
✔ 418 tests completed
✖ 1 test failed

FAILED TESTS:
  mediawiki.Title
    ✖ newFromFileName
      HeadlessChrome 0.0.0 (Linux 0.0.0)
    [Carrying namespace] Filename matches original
    Expected: "File-Sample"
    Actual: "Sample"
        at Object.<anonymous>
        at runTest (node_modules/qunit/qunit/qunit.js:1530:30)
        at Test.run (node_modules/qunit/qunit/qunit.js:1516:6)
        at node_modules/qunit/qunit/qunit.js:1728:12
        at advanceTaskQueue (node_modules/qunit/qunit/qunit.js:1129:6)
        at advance (node_modules/qunit/qunit/qunit.js:1110:4)

Details

SubjectRepoBranchLines +/-
layout: [mediawiki/extension/NSFileRepo] Restore tests now they're fixedintegration/configmaster+2 -1
tests: qunit newFromFileName respect config for ':' replacementmediawiki/coremaster+10 -4
Mark NSFileRepo as brokenintegration/configmaster+1 -2
tests: mediawiki.Title.newFromFileName: exception for ':' replacementmediawiki/coremaster+11 -6
Customize query in gerrit

Related Objects

Event Timeline

hashar created this task.Jun 5 2018, 4:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 5 2018, 4:56 PM
• Vvjjkkii renamed this task from [NSFileRepo] QUnit test "mediawiki.Title fails to jlbaaaaaaa.Jul 1 2018, 1:06 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from jlbaaaaaaa to [NSFileRepo] QUnit test "mediawiki.Title fails.Jul 1 2018, 8:43 PM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: Aklapper.
gerritbot subscribed.Aug 24 2018, 2:45 PM

Change 455175 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Mark NSFileRepo as broken

https://gerrit.wikimedia.org/r/455175

gerritbot added a project: Patch-For-Review.Aug 24 2018, 2:45 PM
gerritbot added a comment.Aug 24 2018, 3:30 PM

Change 455175 merged by jenkins-bot:
[integration/config@master] Mark NSFileRepo as broken

https://gerrit.wikimedia.org/r/455175

Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 2:48 PM
matmarex subscribed.Nov 25 2019, 3:13 PM

The test fails because NSFileRepo overrides wgIllegalFileChars to remove the : character from it.

Possibly the test should be skipped or something when that config option is overridden.

Pwirth subscribed.Nov 25 2019, 3:18 PM

ah, thank you, i could not identify the actual issue yet.
However when i type the following into the console:

mw.Title.newFromFileName( 'File:File-Sample.png' ).getNameText()

The result is:

"File-Sample"

But the current expected value in the qunit test is:

"File:Sample.png"
Pwirth added a comment.Nov 25 2019, 3:28 PM

oh, the ":" gets replaced with a "-" by default. I did not guess that. Ill abandon the change, thanks

gerritbot added a comment.Nov 25 2019, 3:36 PM

Change 552806 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/core@master] mediawiki.Title.newFromFileName: Fix expected fileName in qunit

https://gerrit.wikimedia.org/r/552806

gerritbot added a project: Patch-For-Review.Nov 25 2019, 3:36 PM

Change 552806 abandoned by Pwirth:
mediawiki.Title.newFromFileName: Fix expected fileName in qunit

Reason:
Test is correct. Illegal char ":" is replaced with "-" by default

https://gerrit.wikimedia.org/r/552806

Maintenance_bot removed a project: Patch-For-Review.Nov 26 2019, 11:47 AM
gerritbot added a comment.Jan 16 2020, 8:05 AM

Change 552806 restored by Pwirth:
mediawiki.Title.newFromFileName: Fix expected fileName in qunit

https://gerrit.wikimedia.org/r/552806

gerritbot added a comment.Jan 17 2020, 12:51 AM

Change 552806 merged by jenkins-bot:
[mediawiki/core@master] tests: mediawiki.Title.newFromFileName: exception for ':' replacement

https://gerrit.wikimedia.org/r/552806

matmarex added a comment.Jan 17 2020, 12:53 AM

It should pass with that patch! What now, should we revert https://gerrit.wikimedia.org/r/c/integration/config/+/455175?

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.16; 2020-01-21).Jan 17 2020, 1:00 AM
Pwirth added a comment.Jan 18 2020, 5:58 AM

@matmarex yes, that would be nice.

gerritbot added a comment.Jan 28 2020, 8:01 PM

Change 567724 had a related patch set uploaded (by Bartosz Dziewoński; owner: Pwirth):
[mediawiki/core@master] tests: qunit newFromFileName respect config for ':' replacement

https://gerrit.wikimedia.org/r/567724

gerritbot added a project: Patch-For-Review.Jan 28 2020, 8:01 PM
gerritbot added a comment.Jan 28 2020, 8:16 PM

Change 567724 merged by jenkins-bot:
[mediawiki/core@master] tests: qunit newFromFileName respect config for ':' replacement

https://gerrit.wikimedia.org/r/567724

gerritbot added a comment.Jan 28 2020, 8:16 PM

Change 568031 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[integration/config@master] Revert "Mark NSFileRepo as broken"

https://gerrit.wikimedia.org/r/568031

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.18; 2020-02-04); removed MW-1.35-notes (1.35.0-wmf.16; 2020-01-21).Jan 28 2020, 9:01 PM
gerritbot added a comment.Jan 29 2020, 12:03 AM

Change 568031 merged by jenkins-bot:
[integration/config@master] layout: [mediawiki/extension/NSFileRepo] Restore tests now they're fixed

https://gerrit.wikimedia.org/r/568031

Stashbot added a comment.Jan 29 2020, 12:05 AM

Mentioned in SAL (#wikimedia-releng) [2020-01-29T00:05:18Z] <James_F> layout: [mediawiki/extension/NSFileRepo] Restore tests now they're fixed T196480

Jdforrester-WMF closed this task as Resolved.Jan 29 2020, 12:08 AM
Jdforrester-WMF assigned this task to Pwirth.
Jdforrester-WMF subscribed.

Repo now passes. Congratulations.

matmarex added a comment.Jan 29 2020, 1:54 AM

Thanks for fixing up the patch @Jdforrester-WMF, I really have no idea what I'm doing when it comes to the continuous integration repos.

cscott mentioned this in T343046: Parsoid's title library does not support $wgIllegalFileChars.Jul 28 2023, 8:50 PM
cscott mentioned this in T343047: mediawiki-title package (likely) does not support $wgIllegalFileChars.Jul 28 2023, 8:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL