Maniphest T197828

Fix "score_schema" -- invalid JSON Schema
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Halfak
	Jun 20 2018, 8:47 PM

Tags

Referenced Files

None

Subscribers

Description

See

"probability": {
  "description": "A mapping of probabilities onto each of the potential output labels",
  "properties": {
    "false": "number",
    "true": "number"
  },
  "type": "object"
}

This should have:

"false": {"type": "number"},
"true": {"type": "number"}

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T209611 [Epic] Make ORES scores for wikidata available as a dump
		Resolved		None	T209731 Choose HDFS paths and partitioning for ORES scores
		Open		None	T209732 Wire ORES recent_score events into Hadoop
		Resolved		Ladsgroup	T195979 Invalid field names in ORES models causing downstream Hive ingestion to fail
		Resolved		Ottomata	T197000 Modify revision-score schema so that model probabilities won't conflict
		Resolved		awight	T201518 ORES deployment (Early August)
		Resolved		Halfak	T197828 Fix "score_schema" -- invalid JSON Schema

Event Timeline

Halfak created this task.Jun 20 2018, 8:47 PM

Halfak triaged this task as High priority.

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptJun 20 2018, 8:47 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Any other issues?

OO true! ok

Ottomata moved this task from Incoming to Data Quality on the Analytics board.Jun 21 2018, 4:40 PM

https://github.com/wiki-ai/revscoring/pull/404

Halfak claimed this task.Jun 25 2018, 8:36 PM

Halfak moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.

awight moved this task from Review to Pending deployment on the Machine-Learning-Team (Active Tasks) board.Jun 26 2018, 12:04 PM

• Vvjjkkii renamed this task from Fix "score_schema" -- invalid JSON Schema to 3jaaaaaaaa.Jul 1 2018, 1:02 AM

• Vvjjkkii removed Halfak as the assignee of this task.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed a subscriber: Aklapper.

MacFan4000 renamed this task from 3jaaaaaaaa to Fix "score_schema" -- invalid JSON Schema.Jul 2 2018, 4:38 PM

MacFan4000 assigned this task to Halfak.

MacFan4000 removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

MacFan4000 updated the task description. (Show Details)

MacFan4000 added a subscriber: Aklapper.

Halfak added a parent task: T201518: ORES deployment (Early August).Aug 8 2018, 2:38 PM

awight moved this task from Pending deployment to Completed on the Machine-Learning-Team (Active Tasks) board.Aug 9 2018, 6:04 PM

We'll be re-doing the schema as part of T197000, so I'll merge this with that ticket.

Ottomata closed this task as a duplicate of T197000: Modify revision-score schema so that model probabilities won't conflict.Aug 15 2018, 5:15 PM

Undo! Undo! We already fixed and deployed this! :P

Halfak changed the task status from Duplicate to Resolved.Aug 16 2018, 10:21 AM