Page MenuHomePhabricator
Create Task
Maniphest T198111

CX2: Translation saving fails after adding new category
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. Start translation with CX2
  2. Add new category.
  3. Watch console and error message shown to user.

Error log:

[CX] Saving Failed. Error code: internal_api_error_DBQueryError
(anonymous) @ VM452:510
fire @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:46
fireWith @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:47
process @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:50
(anonymous) @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:50
mightThrow @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:49
process @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:50
setTimeout (async)
(anonymous) @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:50
fire @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:46
fireWith @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:47
fire @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:47
fire @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:46
fireWith @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:47
process @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:50
(anonymous) @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:50
mightThrow @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:49
process @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:50
setTimeout (async)
(anonymous) @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:50
fire @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:46
add @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:47
(anonymous) @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:50
jQuery.Deferred @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:150
then @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:50
mightThrow @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:49
process @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:50
setTimeout (async)
(anonymous) @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:50
fire @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:46
fireWith @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:47
fire @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:47
fire @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:46
fireWith @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:47
deferred.(anonymous function) @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:51
(anonymous) @ VM452:28
fire @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:46
fireWith @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:47
done @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:126
(anonymous) @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:129
load (async)
send @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:129
ajax @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:125
jQuery.ajax @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:143
ajax @ VM452:27
post @ VM452:26
(anonymous) @ VM452:29
mightThrow @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:49
process @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:50
setTimeout (async)
(anonymous) @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:50
fire @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:46
add @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:47
(anonymous) @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:50
jQuery.Deferred @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:150
then @ load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=18kdz1s:50
postWithToken @ VM452:28
mw.cx.TranslationController.processSaveQueue @ VM452:510
run @ load.php?debug=false&lang=gu&modules=ext.visualEditor.core|mw.config.values.wbSiteDetails|oojs-ui-core&skin=vector&version=0j942ve:972
setTimeout (async)
(anonymous) @ load.php?debug=false&lang=gu&modules=ext.visualEditor.core|mw.config.values.wbSiteDetails|oojs-ui-core&skin=vector&version=0j942ve:972
mw.cx.TranslationController.onTargetCategoriesChange @ VM452:516
oo.EventEmitter.emit @ VM452:62
mw.cx.dm.Translation.setTargetCategories @ VM452:90
mw.cx.ui.Categories.onTargetCategoriesChange @ VM452:862
oo.EventEmitter.emit @ VM452:62
OO.ui.mixin.GroupElement.addItems @ load.php?debug=false&lang=gu&modules=ext.visualEditor.core|mw.config.values.wbSiteDetails|oojs-ui-core&skin=vector&version=0j942ve:997
mw.cx.ui.CategoryMultiselectWidget.addTag @ VM452:858
mw.cx.ui.CategoryMultiselectWidget.onInputChoose @ VM452:858
oo.EventEmitter.emit @ VM452:62
mw.loader.implement.ve.ui.MWCategoryInputWidget.onLookupMenuItemChoose @ VM452:808
mw.cx.ui.CategoryInputWidget.onLookupMenuItemChoose @ VM452:855
oo.EventEmitter.emit @ VM452:62
OO.ui.SelectWidget.chooseItem @ load.php?debug=false&lang=gu&modules=ext.visualEditor.core|mw.config.values.wbSiteDetails|oojs-ui-core&skin=vector&version=0j942ve:1057
OO.ui.MenuSelectWidget.chooseItem @ load.php?debug=false&lang=gu&modules=ext.visualEditor.core|mw.config.values.wbSiteDetails|oojs-ui-core&skin=vector&version=0j942ve:1064
OO.ui.SelectWidget.onMouseUp @ load.php?debug=false&lang=gu&modules=ext.visualEditor.core|mw.config.values.wbSiteDetails|oojs-ui-core&skin=vector&version=0j942ve:1049

Details

SubjectRepoBranchLines +/-
Run category query with FOR UPDATE on master DBmediawiki/extensions/ContentTranslationmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

KartikMistry created this task.Jun 25 2018, 2:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 25 2018, 2:37 PM
Nikerabbit subscribed.Jun 25 2018, 3:00 PM
  1. Which instance/wiki?
  2. Can you get the actual query error from PHP logs/logstash?
KartikMistry added a comment.Jun 25 2018, 4:05 PM
  1. en -> gu. Production.
  1. Getting more info, with debug enabled,
mw.Api error:  internal_api_error_DBQueryError {error: {…}, servedby: "mw1287"}
error:
 code: "internal_api_error_DBQuery Error"
 info: "[WzEPAwpAEDQAAJNFjJQAAACS] Database query error."

Nothing useful in logstash.

KartikMistry mentioned this in T198118: CX2: Adding category fails with "this.categoryWidget.getCategories is not a function" error.Jun 25 2018, 4:09 PM
Nikerabbit added a comment.EditedJun 25 2018, 8:12 PM

I am seeing this in Logstash that looks related:

ContentTranslation\CategoriesStorageManager::exists	10.64.48.19	1290	The MariaDB server is running with the --read-only option so it cannot execute this statement (10.64.48.19)	SELECT  cxc_content  FROM `cx_corpora`    WHERE cxc_translation_id = '496574' AND cxc_section_id = 'CX_CATEGORY_METADATA'   FOR UPDATE

https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2018.06.25/mediawiki?id=AWQ4jz6R8VFZOIjHFOo2&_g=h@e8b7b86

Nikerabbit added subscribers: • jcrespo, Marostegui.Jun 25 2018, 8:18 PM
Marostegui added a comment.Jun 25 2018, 8:24 PM

10.64.48.19 is db1064 which is a slave. So it is correct to have read_only there.
Are you trying to insert on a slave??

gerritbot subscribed.Jun 25 2018, 8:28 PM

Change 441976 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/ContentTranslation@master] Run category query with FOR UPDATE on master DB

https://gerrit.wikimedia.org/r/441976

gerritbot added a project: Patch-For-Review.Jun 25 2018, 8:29 PM
gerritbot added a comment.Jun 25 2018, 8:52 PM

Change 441976 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Run category query with FOR UPDATE on master DB

https://gerrit.wikimedia.org/r/441976

• Petar.petkovic removed a project: Patch-For-Review.Jun 25 2018, 10:08 PM
KartikMistry added a project: Language-2018-Apr-June.Jun 26 2018, 2:12 AM
KartikMistry moved this task from Backlog to QA on the Language-2018-Apr-June board.
• Petar.petkovic assigned this task to Nikerabbit.Jun 26 2018, 8:07 AM
Pginer-WMF triaged this task as Medium priority.Jun 27 2018, 7:10 AM
Etonkovidova closed this task as Resolved.Jun 28 2018, 1:19 AM
• Petar.petkovic moved this task from QA to Done on the Language-2018-Apr-June board.Jun 28 2018, 6:40 AM
• Petar.petkovic removed a subscriber: gerritbot.
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 4:02 PM
• Vvjjkkii renamed this task from CX2: Translation saving fails after adding new category to 8baaaaaaaa.Jul 1 2018, 1:02 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed Nikerabbit as the assignee of this task.
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from 8baaaaaaaa to CX2: Translation saving fails after adding new category.Jul 2 2018, 10:05 AM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to Nikerabbit.
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: Aklapper.
Pginer-WMF mentioned this in T242613: User-provided categories added to the translation are ignored when published.Jan 13 2020, 4:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits