Steps to replicate:
- Open VE on Firefox.
- Click on Edit Source now.
It does not switch to the source editor.
There is no error in the console though.
Steps to replicate:
It does not switch to the source editor.
There is no error in the console though.
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
DesktopArticleTarget: consolidate edit tab behavior | mediawiki/extensions/VisualEditor | master | +23 -27 |
This is bad... but, so far, cannot be reproduced.
Here's the steps I took:
Both the expected and actual output were seeing the "Switching to source editing" modal, then seeing the editor switch to source mode.
Am I missing something?
No, I missed a step while trying to replicate it.
You need to save an edit first and then from second attempt onwards it won't switch.
Here are the exact steps:
Also, this is not Firefox specific, happening on Chrome too.
Change 442750 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] ArticleTarget switchToWikitextSection make sure switch happens
QA note: when merged this patch has a chance of regressing T157755, so double-check behavior with single/multi edit tabs on pages with __NEWSECTIONLINK__.
Change 442750 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget: consolidate edit tab behavior
The original issue is fixed. Also checked for regressions with both single and multi tabs by switching between different tabs in different orders and such. No new regressions found.