Page MenuHomePhabricator
Create Task
Maniphest T198618

TOC processing should strip contents of <style> tags
Closed, ResolvedPublic
Actions

Description

If a <style> tag is present in a section header, e.g. from a <templatestyles> tag, the parser is stripping the tag but leaving the content in place.

Original report

A severe bug from using TemplateStyles in inline templates: https://ru.wikipedia.org/?oldid=93704275

Details

SubjectRepoBranchLines +/-
Add a test for <script> in TOCmediawiki/services/parsoidmaster+21 -0
Strip <style> / <script> tags in TOCmediawiki/services/parsoidmaster+7 -5
Sync parserTests with coremediawiki/services/parsoidmaster+30 -4
Parser: Remove style and script tags' content from TOCmediawiki/coremaster+28 -0
Customize query in gerrit

Related Objects

Event Timeline

stjn created this task.Jul 2 2018, 11:38 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 2 2018, 11:38 AM
stjn added a project: MediaWiki-User-Interface.Jul 2 2018, 11:39 AM
Anomie renamed this task from TemplateStyles should be ignored in table of contents to TOC processing should strip contents of <style> tags.Jul 2 2018, 2:30 PM
Anomie claimed this task.
Anomie edited projects, added MediaWiki-Parser; removed MediaWiki-User-Interface.
Anomie updated the task description. (Show Details)
gerritbot subscribed.Jul 2 2018, 3:19 PM

Change 443440 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] Parser: Remove style and script tags' content from TOC

https://gerrit.wikimedia.org/r/443440

gerritbot added a project: Patch-For-Review.Jul 2 2018, 3:19 PM
Anomie added a project: MediaWiki-Platform-Team-Archived (MWPT-Q1-Jul-Sep-2018).Jul 2 2018, 3:21 PM
Anomie moved this task from Ready to Waiting for Review on the MediaWiki-Platform-Team-Archived (MWPT-Q1-Jul-Sep-2018) board.
• ggellerman triaged this task as Medium priority.Jul 3 2018, 6:09 PM
• ggellerman moved this task from Backlog to Doing on the TemplateStyles board.
CCicalese_WMF added a project: Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018).Jul 10 2018, 12:54 AM
CCicalese_WMF moved this task from Backlog to Waiting for Review on the Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018) board.
CCicalese_WMF removed a project: MediaWiki-Platform-Team-Archived (MWPT-Q1-Jul-Sep-2018).Jul 11 2018, 9:17 PM
gerritbot added a comment.Jul 17 2018, 3:23 AM

Change 443440 merged by jenkins-bot:
[mediawiki/core@master] Parser: Remove style and script tags' content from TOC

https://gerrit.wikimedia.org/r/443440

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)).Jul 17 2018, 4:00 AM
Anomie closed this task as Resolved.Jul 17 2018, 1:29 PM

This should be deployed to Wikimedia sites with 1.32.0-wmf.13 or later.

CCicalese_WMF moved this task from Waiting for Review to Closed on the Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018) board.Jul 31 2018, 12:49 AM
• Deskana moved this task from Doing to Done on the TemplateStyles board.Aug 9 2018, 11:40 AM
gerritbot added a comment.Oct 9 2018, 5:16 PM

Change 465454 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] Sync parserTests with core

https://gerrit.wikimedia.org/r/465454

gerritbot added a comment.Oct 9 2018, 5:31 PM

Change 465454 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Sync parserTests with core

https://gerrit.wikimedia.org/r/465454

• ggellerman added a subscriber: • Deskana.Oct 11 2018, 2:33 PM
gerritbot added a comment.Oct 19 2018, 3:38 AM

Change 465460 had a related patch set uploaded (by Arlolra; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] Strip <style> / <script> tags in TOC

https://gerrit.wikimedia.org/r/465460

gerritbot added a comment.Oct 19 2018, 2:07 PM

Change 465460 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Strip <style> / <script> tags in TOC

https://gerrit.wikimedia.org/r/465460

gerritbot added a comment.Oct 19 2018, 8:20 PM

Change 468668 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Add a test for <script> in TOC

https://gerrit.wikimedia.org/r/468668

gerritbot added a comment.Oct 19 2018, 8:39 PM

Change 468668 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Add a test for <script> in TOC

https://gerrit.wikimedia.org/r/468668

Stashbot mentioned this in T100841: Support for dynamically enabling new wikis.Oct 29 2018, 8:45 PM
Stashbot mentioned this in T186965: Output HTML should not contain `<p><style>...</style></p>`.
Stashbot mentioned this in T167349: Tidy on WMF sites removes `<style>` tags.
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2018-10-29T20:45:28Z] <arlolra> Updated Parsoid to b9fa661 (T100841, T186965, T167349, T198618, T206040, T207956)

Stashbot mentioned this in T206040: Timeout parsing largish page.Oct 29 2018, 8:45 PM
Stashbot mentioned this in T207956: Token stream patcher table start retokenizing doesn't handle non-string tokens in table attribute position.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits