Page MenuHomePhabricator
Create Task
Maniphest T198681

Template replacements are made 1 revision too early
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

This edit https://commons.wikimedia.org/wiki/Special:Diff/309221779 holds the summary line "Imported with FileImporter from …". Technically, this is supposed to be a null edit with no changes, only with this summary line. But it contains two changes: The HTML comment <!--This file was moved here using FileImporter from …--> is added to the top, and the template replacements are made.

The next edit https://commons.wikimedia.org/wiki/Special:Diff/309221781 holds the summary line "Replaced 1 template names with Wikimedia Commons template names".

Reported at T194505#4391840.

Another worst-case example: In http://mwfileimport.wmflabs.org/wiki/index.php?title=File:Stolperstein_f%C3%BCr_Lina_Speiser,_Br%C3%BCckenstrasse_11,_Bad_Cannstatt,_Stuttgart.JPG&curid=105&action=history the summary line "Replaced … template names with … template names" got lost entirely, because the edit was empty (the user did not made additional edits).

TODO:

  • The template replacements must be made in the next revision.
  • The summary line should not get lost.
  • The HTML comment should also be added in the next revision.
  • The null revision should only contain the title change (if one was made).

Details

SubjectRepoBranchLines +/-
Bring back initial null revision and move all changes to the next revisionmediawiki/extensions/FileImportermaster+169 -15
Customize query in gerrit

Related Objects
Search...

Event Timeline

thiemowmde created this task.Jul 3 2018, 7:56 AM
thiemowmde added a parent task: T194505: Map templates to Commons templates whenever possible.
• Lea_WMDE moved this task from Backlog to Tickets in preparation/investigation on the Move-Files-To-Commons board.Jul 3 2018, 10:30 AM
thiemowmde updated the task description. (Show Details)Jul 3 2018, 12:50 PM
• Lea_WMDE renamed this task from Template replacements are made 1 revision to early to Template replacements are made 1 revision too early.Jul 3 2018, 12:52 PM
• Lea_WMDE triaged this task as Medium priority.
• Lea_WMDE set the point value for this task to 3.
thiemowmde updated the task description. (Show Details)Jul 3 2018, 12:55 PM
• Lea_WMDE added a project: WMDE-QWERTY-Sprint-2018-07-03.Jul 3 2018, 1:12 PM
• Lea_WMDE moved this task from Tickets in preparation/investigation to Tickets ready for pickup on the Move-Files-To-Commons board.
• Lea_WMDE moved this task from Tickets ready for pickup to Tickets in sprint on the Move-Files-To-Commons board.Jul 3 2018, 1:26 PM
• MichaelSchoenitzer_WMDE subscribed.Jul 3 2018, 1:57 PM
Andrew-WMDE claimed this task.Jul 5 2018, 7:48 AM
gerritbot subscribed.Jul 5 2018, 10:09 AM

Change 443934 had a related patch set uploaded (by Andrew-WMDE; owner: Andrew-WMDE):
[mediawiki/extensions/FileImporter@master] Bring back initial null revision and move all changes to the next revision

https://gerrit.wikimedia.org/r/443934

gerritbot added a project: Patch-For-Review.Jul 5 2018, 10:09 AM
Andrew-WMDE mentioned this in rEFLI9d365109daca: Bring back initial null revision and move all changes to the next revision.Jul 5 2018, 10:10 AM
Andrew-WMDE mentioned this in rEFLI34a4898ef2d4: Bring back initial null revision and move all changes to the next revision.Jul 5 2018, 10:14 AM
Andrew-WMDE moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2018-07-03 board.Jul 5 2018, 10:20 AM
Andrew-WMDE moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2018-07-03 board.
Andrew-WMDE mentioned this in rEFLI43cd87c9c34f: Bring back initial null revision and move all changes to the next revision.Jul 5 2018, 2:53 PM
Andrew-WMDE mentioned this in rEFLI9fbaf27a8631: Bring back initial null revision and move all changes to the next revision.Jul 5 2018, 2:59 PM
thiemowmde mentioned this in rEFLI106a124835fe: Bring back initial null revision and move all changes to the next revision.Jul 6 2018, 7:44 AM
gerritbot added a comment.Jul 6 2018, 9:45 AM

Change 444179 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] [WIP] Update ImporterComponentTest to use NullRevisionCreator

https://gerrit.wikimedia.org/r/444179

thiemowmde mentioned this in rEFLI65bb762039bd: [WIP] Update ImporterComponentTest to use NullRevisionCreator.Jul 6 2018, 9:48 AM
thiemowmde mentioned this in rEFLI1ee4ca8a03a9: [WIP] Update ImporterComponentTest to use NullRevisionCreator.Jul 6 2018, 10:09 AM
thiemowmde moved this task from Incoming to Move files to Commons on the TCB-Team (now WMDE-TechWish) board.Jul 9 2018, 1:31 PM
WMDE-Fisch moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2018-07-03 board.Jul 10 2018, 2:01 PM
WMDE-Fisch mentioned this in rEFLI45d72b36d392: Bring back initial null revision and move all changes to the next revision.Jul 10 2018, 2:07 PM
gerritbot added a comment.Jul 10 2018, 2:14 PM

Change 443934 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Bring back initial null revision and move all changes to the next revision

https://gerrit.wikimedia.org/r/443934

WMDE-Fisch added a comment.Jul 10 2018, 2:45 PM

Can for example be tested together with https://phabricator.wikimedia.org/T198606#4412119 on https://mwfileimport.wmflabs.org/wiki/index.php/Special:ImportFile with any allowed file.

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)).Jul 11 2018, 1:02 AM
WMDE-Fisch updated the task description. (Show Details)Jul 11 2018, 10:42 AM
• Lea_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2018-07-03 board.Jul 13 2018, 7:58 AM
thiemowmde mentioned this in rEFLIc0ee86e39f24: Add missing expected function argument in ImporterComponentTest.Jul 15 2018, 8:56 AM
WMDE-Fisch mentioned this in rEFLI5b34e2d33a87: Add missing expected function argument in ImporterComponentTest.Jul 16 2018, 10:18 AM
WMDE-Fisch mentioned this in rEFLI95c18cc5fcb3: Add missing expected function argument in ImporterComponentTest.Jul 16 2018, 10:39 AM
• Lea_WMDE closed this task as Resolved.Jul 18 2018, 3:51 PM
thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 2:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits