Page MenuHomePhabricator
Create Task
Maniphest T198930

It should be possible to specify a ResourceLoaderImage module without data uris
Closed, ResolvedPublic
Actions

Description

In the mobile site, we have various icons that we would like to load without needing JavaScript. When loaded as data uris these bloat the size of the render blocking stylesheet (on mobile this is currently 8kb)

It could be possible in a module definition using the ResourceLoaderImage module to request data uris are not used. This gives full control to the engineer in how their styles are loaded.

On mobile, this would reduce the size of the render blocking CSS by 1.6kb after gzipping.

It appears, ResourceLoaderImage module can already handle shipping assets as URIs so the proposed change would be quite simple: a flag in ResourceLoader that allows the module to opt in.

Data-uris are usually preferable.. so this would remain the default.

Related:

Details

SubjectRepoBranchLines +/-
Reduce render blocking styles by deferring loading of iconsmediawiki/skins/MinervaNeuemaster+3 -0
registration: Document ResourceLoaderImageModule's useDataURI optionmediawiki/coremaster+6 -0
Allow ResourceLoaderImage modules without data URIsmediawiki/coremaster+5 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Jul 5 2018, 11:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 5 2018, 11:51 PM
gerritbot subscribed.Jul 5 2018, 11:52 PM

Change 444142 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Allow ResourceLoaderImage modules without data URIs

https://gerrit.wikimedia.org/r/444142

gerritbot added a project: Patch-For-Review.Jul 5 2018, 11:52 PM

Change 444143 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Reduce render blocking styles by deferring loading of icons

https://gerrit.wikimedia.org/r/444143

Krinkle added a project: MediaWiki-ResourceLoader.Jul 6 2018, 12:03 AM
Krinkle updated the task description. (Show Details)
Restricted Application added a project: Performance-Team. · View Herald TranscriptJul 6 2018, 12:03 AM
Krinkle subscribed.Jul 6 2018, 12:04 AM

I've linked some related tasks from the description:

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.Jul 6 2018, 12:27 AM
Jdlrobson added a parent task: T182648: [EPIC] Review, rearrange and remove unnecessary CSS in the mobile site.Jul 6 2018, 7:54 PM
Jdlrobson mentioned this in T182648: [EPIC] Review, rearrange and remove unnecessary CSS in the mobile site.
Jdlrobson edited projects, added User-Jdlrobson, Web-Team-Backlog (Tracking); removed Web-Team-Backlog.Jul 6 2018, 9:24 PM
Jdlrobson moved this task from Untriaged to Move to Backlog on the Web-Team-Backlog (Tracking) board.
gerritbot added a comment.Jul 9 2018, 2:24 PM

Change 444142 merged by jenkins-bot:
[mediawiki/core@master] Allow ResourceLoaderImage modules without data URIs

https://gerrit.wikimedia.org/r/444142

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jul 9 2018, 3:00 PM
Jdlrobson added a comment.Jul 9 2018, 3:22 PM

Patch was merged but i wanted to make sure everyone was happy with the idea and the proposed opt in method (per module not per icon). If so i will submit a patch to allow usage in skins/extensions (right now it's not going to validate as i didn't update the docs)

• Imarlier assigned this task to Krinkle.Jul 9 2018, 8:05 PM
• Imarlier moved this task from Inbox, needs triage to Doing (old) on the Performance-Team board.
Krinkle closed this task as Resolved.Jul 9 2018, 11:23 PM

Thanks.

Krinkle removed a project: Patch-For-Review.Jul 9 2018, 11:23 PM
gerritbot added a comment.Jul 9 2018, 11:26 PM

Change 444764 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Allow extensions/skins to use useDataURI option

https://gerrit.wikimedia.org/r/444764

gerritbot added a project: Patch-For-Review.Jul 9 2018, 11:26 PM
gerritbot added a comment.Jul 10 2018, 1:15 AM

Change 444764 merged by jenkins-bot:
[mediawiki/core@master] registration: Document ResourceLoaderImageModule's useDataURI option

https://gerrit.wikimedia.org/r/444764

gerritbot added a comment.Jul 11 2018, 4:31 PM

Change 444143 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Reduce render blocking styles by deferring loading of icons

https://gerrit.wikimedia.org/r/444143

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jul 11 2018, 5:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits