Page MenuHomePhabricator
Create Task
Maniphest T199244

Add support for deserializing senses
Closed, ResolvedPublic
Actions

Description

We already have some support for serializing senses in StorageLexemeSerializer (though perhaps it should be extracted into a separate SenseSerializer), but LexemeDeserializer doesn’t support senses yet.

Details

SubjectRepoBranchLines +/-
Use SenseDeserializer in LexemeDeserializermediawiki/extensions/WikibaseLexememaster+108 -1
Add SenseDeserializermediawiki/extensions/WikibaseLexememaster+217 -0
Extract SenseSerializermediawiki/extensions/WikibaseLexememaster+191 -20
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jul 10 2018, 4:10 PM
gerritbot subscribed.Jul 10 2018, 4:36 PM

Change 444913 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Extract SenseSerializer

https://gerrit.wikimedia.org/r/444913

gerritbot added a project: Patch-For-Review.Jul 10 2018, 4:36 PM
Lucas_Werkmeister_WMDE mentioned this in rEWLE8e3b6eed2cee: Extract SenseSerializer.Jul 10 2018, 4:38 PM
Lucas_Werkmeister_WMDE mentioned this in rEWLE4b8b09db9fad: Extract SenseSerializer.Jul 10 2018, 4:54 PM
gerritbot added a comment.Jul 10 2018, 5:34 PM

Change 444923 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Add SenseDeserializer

https://gerrit.wikimedia.org/r/444923

Lucas_Werkmeister_WMDE mentioned this in rEWLE52285a4b65d7: Extract SenseSerializer.Jul 10 2018, 5:35 PM
Lucas_Werkmeister_WMDE mentioned this in rEWLE75d40ac87043: Add SenseDeserializer.
Lucas_Werkmeister_WMDE mentioned this in rEWLEb986f7da3519: Extract SenseSerializer.Jul 10 2018, 5:47 PM
Lucas_Werkmeister_WMDE mentioned this in rEWLE761daceb515f: Add SenseDeserializer.
Lucas_Werkmeister_WMDE mentioned this in rEWLEb5c704543b3b: Extract SenseSerializer.Jul 10 2018, 5:50 PM
Lucas_Werkmeister_WMDE mentioned this in rEWLEaf119a8c97bd: Add SenseDeserializer.
Lydia_Pintscher moved this task from incoming to other stuff on the Wikidata Lexicographical data board.Jul 11 2018, 8:58 AM
Lucas_Werkmeister_WMDE mentioned this in rEWLEf3b0fc31ba14: Add SenseDeserializer.Jul 11 2018, 10:40 AM
Lucas_Werkmeister_WMDE mentioned this in rEWLEaf3516347557: Extract SenseSerializer.
Addshore mentioned this in rEWLEda9c129bd9ee: Extract SenseSerializer.Jul 12 2018, 9:01 AM
Addshore mentioned this in rEWLEcd17fc94c935: Add SenseDeserializer.Jul 12 2018, 9:08 AM
gerritbot added a comment.Jul 12 2018, 9:13 AM

Change 444913 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Extract SenseSerializer

https://gerrit.wikimedia.org/r/444913

Addshore mentioned this in rEWLEebe20624aaed: Add SenseDeserializer.Jul 12 2018, 9:29 AM
gerritbot added a comment.Jul 12 2018, 9:46 AM

Change 444923 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add SenseDeserializer

https://gerrit.wikimedia.org/r/444923

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)).Jul 12 2018, 10:00 AM
Addshore moved this task from To Do to Doing on the Wikidata-Senses-Iteration1 board.Jul 12 2018, 11:42 AM
gerritbot added a comment.Jul 16 2018, 11:51 AM

Change 445985 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Use SenseDeserializer in LexemeDeserializer

https://gerrit.wikimedia.org/r/445985

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Senses-Iteration1 board.Jul 16 2018, 11:51 AM
Lucas_Werkmeister_WMDE mentioned this in rEWLE6479e65fdc42: Use SenseDeserializer in LexemeDeserializer.Jul 16 2018, 11:53 AM
Lucas_Werkmeister_WMDE claimed this task.Jul 16 2018, 11:55 AM
Lucas_Werkmeister_WMDE mentioned this in rEWLE389f50802ed3: Use SenseDeserializer in LexemeDeserializer.Jul 16 2018, 12:31 PM
Lucas_Werkmeister_WMDE mentioned this in T198198: Load/show stored senses when loading a lexeme page.Jul 16 2018, 1:16 PM
hoo closed this task as Resolved.Jul 16 2018, 6:07 PM
hoo moved this task from Peer Review to Done on the Wikidata-Senses-Iteration1 board.
hoo removed a project: Patch-For-Review.
gerritbot added a comment.Jul 16 2018, 6:21 PM

Change 445985 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Use SenseDeserializer in LexemeDeserializer

https://gerrit.wikimedia.org/r/445985

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits