Page MenuHomePhabricator
Create Task
Maniphest T199474

Rebuildrecentchanges.php does not work correctly in MediaWiki 1.31 and later
Closed, ResolvedPublic
Actions

Description

In MediaWiki 1.31 and later, when running rebuildrecentchanges.php, all edits by registered users will have the rc_patrolled field equal to 1 regardless of whether the user has autopatrol rights or not. The problem occurs regardless of whether one has the actor table migration enabled or not. The script should be fixed to correctly leave rc_patrolled as 0 for edits by registered users without autopatrol rights, and set rc_patrolled to 2 instead of 1 for edits by users with autopatrol rights, including sysops and bots. Similarly, if there is at least one bot on the wiki, all edits by registered non-bot users will be incorrectly marked as bot edits in the recentchanges table when they shouldn't be.

Details

SubjectRepoBranchLines +/-
Set rc_patrolled to 2 for autopatrolled changes in rebuildrecentchanges.phpmediawiki/coreREL1_33+3 -2
Set rc_patrolled to 2 for autopatrolled changes in rebuildrecentchanges.phpmediawiki/coreREL1_34+3 -2
Set rc_patrolled to 2 for autopatrolled changes in rebuildrecentchanges.phpmediawiki/coreREL1_31+3 -2
Set rc_patrolled to 2 for autopatrolled changes in rebuildrecentchanges.phpmediawiki/coremaster+3 -2
user_group, the nonexistent table that keeps on givingmediawiki/coreREL1_32+2 -2
user_group, the nonexistent table that keeps on givingmediawiki/coreREL1_31+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

GTrang created this task.Jul 12 2018, 8:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 12 2018, 8:06 PM
GTrang updated the task description. (Show Details)Jul 12 2018, 8:08 PM
Reedy subscribed.Jul 12 2018, 9:28 PM

Looking at the actor patch, I don't see this as new behaviour to the script

https://github.com/wikimedia/mediawiki/commit/b09a23f284079758653c62305f1ab590e48a09a3

GTrang renamed this task from Rebuildrecentchanges.php does not work correctly in MediaWiki 1.31 to Rebuildrecentchanges.php does not work correctly in MediaWiki 1.31 and later.Feb 28 2019, 12:46 AM
GTrang updated the task description. (Show Details)
GTrang updated the task description. (Show Details)Feb 28 2019, 12:49 AM
gerritbot subscribed.Mar 6 2019, 1:57 AM

Change 494636 had a related patch set uploaded (by GeoffreyT2000; owner: GeoffreyT2000):
[mediawiki/core@master] Set rc_patrolled to 2 for autopatrolled changes in rebuildrecentchanges.php

https://gerrit.wikimedia.org/r/494636

gerritbot added a project: Patch-For-Review.Mar 6 2019, 1:57 AM
GTrang added subscribers: ashley, lcawte.Mar 6 2019, 2:10 AM

The part about rc_bot has already been fixed with https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/494619/. Perhaps
Jack Phoenix and Lewis Cawte could also make a similar patch that fixes the problem for rc_patrolled.

gerritbot added a comment.Mar 6 2019, 9:50 AM

Change 494672 had a related patch set uploaded (by Lewis Cawte; owner: Jack Phoenix):
[mediawiki/core@REL1_31] user_group, the nonexistent table that keeps on giving

https://gerrit.wikimedia.org/r/494672

lcawte added a comment.Mar 6 2019, 9:53 AM
In T199474#5003716, @GeoffreyT2000 wrote:

The part about rc_bot has already been fixed with https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/494619/. Perhaps
Jack Phoenix and Lewis Cawte could also make a similar patch that fixes the problem for rc_patrolled.

So it seems that the cause of this bug was the same as the one we patched last night - a typo in the user_groups table name resulting in broken joins. @ashley patched this, and it has been merged into core, the backports are still pending as of the time of writing.

gerritbot added a comment.Mar 6 2019, 9:54 AM

Change 494675 had a related patch set uploaded (by Lewis Cawte; owner: Jack Phoenix):
[mediawiki/core@REL1_32] user_group, the nonexistent table that keeps on giving

https://gerrit.wikimedia.org/r/494675

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.21; 2019-03-12).Mar 6 2019, 10:00 AM
gerritbot added a comment.Mar 6 2019, 12:20 PM

Change 494675 merged by jenkins-bot:
[mediawiki/core@REL1_32] user_group, the nonexistent table that keeps on giving

https://gerrit.wikimedia.org/r/494675

gerritbot added a comment.Mar 6 2019, 12:21 PM

Change 494672 merged by jenkins-bot:
[mediawiki/core@REL1_31] user_group, the nonexistent table that keeps on giving

https://gerrit.wikimedia.org/r/494672

ReleaseTaggerBot added projects: MW-1.31-release-notes, MW-1.32-notes.Mar 6 2019, 1:00 PM
gerritbot added a comment.Mar 19 2019, 9:47 PM

Change 494636 had a related patch set uploaded (by GeoffreyT2000; owner: GeoffreyT2000):
[mediawiki/core@master] Set rc_patrolled to 2 for autopatrolled changes in rebuildrecentchanges.php

https://gerrit.wikimedia.org/r/494636

GTrang mentioned this in T229455: [EPIC] More rebuildrecentchanges.php improvements.Jul 31 2019, 5:52 PM
GTrang added a parent task: T229455: [EPIC] More rebuildrecentchanges.php improvements.
GTrang moved this task from Backlog to rebuildrecentchanges.php on the MediaWiki-Maintenance-system board.Aug 1 2019, 9:29 PM
GTrang added a parent task: T205905: rebuildrecentchanges.php removes tags and changes all edits as bot edits.Aug 1 2019, 9:35 PM
gerritbot added a comment.Feb 12 2020, 4:24 PM

Change 494636 merged by jenkins-bot:
[mediawiki/core@master] Set rc_patrolled to 2 for autopatrolled changes in rebuildrecentchanges.php

https://gerrit.wikimedia.org/r/494636

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.20; 2020-02-18).Feb 12 2020, 5:00 PM
gerritbot added a comment.Feb 13 2020, 1:40 AM

Change 571844 had a related patch set uploaded (by GeoffreyT2000; owner: GeoffreyT2000):
[mediawiki/core@REL1_31] Set rc_patrolled to 2 for autopatrolled changes in rebuildrecentchanges.php

https://gerrit.wikimedia.org/r/571844

gerritbot added a comment.Feb 13 2020, 1:40 AM

Change 571846 had a related patch set uploaded (by GeoffreyT2000; owner: GeoffreyT2000):
[mediawiki/core@REL1_33] Set rc_patrolled to 2 for autopatrolled changes in rebuildrecentchanges.php

https://gerrit.wikimedia.org/r/571846

gerritbot added a comment.Feb 13 2020, 1:41 AM

Change 571847 had a related patch set uploaded (by GeoffreyT2000; owner: GeoffreyT2000):
[mediawiki/core@REL1_34] Set rc_patrolled to 2 for autopatrolled changes in rebuildrecentchanges.php

https://gerrit.wikimedia.org/r/571847

Krinkle edited projects, added MediaWiki-Recent-changes; removed MediaWiki-Maintenance-system.Apr 3 2020, 3:07 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptApr 3 2020, 3:07 PM
gerritbot added a comment.May 28 2020, 8:10 PM

Change 571844 merged by jenkins-bot:
[mediawiki/core@REL1_31] Set rc_patrolled to 2 for autopatrolled changes in rebuildrecentchanges.php

https://gerrit.wikimedia.org/r/571844

gerritbot added a comment.May 28 2020, 8:14 PM

Change 571847 merged by jenkins-bot:
[mediawiki/core@REL1_34] Set rc_patrolled to 2 for autopatrolled changes in rebuildrecentchanges.php

https://gerrit.wikimedia.org/r/571847

gerritbot added a comment.May 28 2020, 8:19 PM

Change 571846 merged by jenkins-bot:
[mediawiki/core@REL1_33] Set rc_patrolled to 2 for autopatrolled changes in rebuildrecentchanges.php

https://gerrit.wikimedia.org/r/571846

ReleaseTaggerBot edited projects, added MW-1.34-notes, MW-1.33-notes; removed MW-1.33-notes (1.33.0-wmf.21; 2019-03-12).May 28 2020, 9:00 PM
GTrang closed this task as Resolved.May 29 2020, 10:23 PM
GTrang claimed this task.

All fixed now, including backports to REL1_31, REL1_33, and REL1_34.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits