Page MenuHomePhabricator
Create Task
Maniphest T199932

RecentChanges filters menu items got bigger
Closed, ResolvedPublic
Actions

Assigned To
Catrope
Authored By
Catrope
Jul 18 2018, 5:27 PM
Tags
Referenced Files
F23942052: Screen Shot 2018-07-21 at 9.20.09 AM.png
Jul 21 2018, 7:28 AM
F23885209: Screenshot from 2018-07-18 19-25-08.png
Jul 18 2018, 5:27 PM
F23885211: Screenshot from 2018-07-18 19-25-16.png
Jul 18 2018, 5:27 PM
Subscribers
Aklapper
Catrope
Etonkovidova
gerritbot
SBisson

Description

I think this is an OOUI regression. From investigating this, it seems to be a Chrome browser bug triggered by the padding-left rule on the labels

enwiki (wmf.12):

Screenshot from 2018-07-18 19-25-08.png (253×460 px, 42 KB)

testwiki (wmf.13):

Screenshot from 2018-07-18 19-25-16.png (340×467 px, 41 KB)

Details

SubjectRepoBranchLines +/-
RCFilters: Work around Chrome browser bug in filter menumediawiki/coremaster+6 -0
Customize query in gerrit

Related Objects

Event Timeline

Catrope created this task.Jul 18 2018, 5:27 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 18 2018, 5:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Jul 18 2018, 5:42 PM

Change 446628 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] RCFilters: Work around Chrome browser bug in filter menu

https://gerrit.wikimedia.org/r/446628

gerritbot added a project: Patch-For-Review.Jul 18 2018, 5:43 PM
JTannerWMF moved this task from Inbox to Needs Discussion on the Growth-Team board.Jul 18 2018, 6:31 PM
gerritbot added a comment.Jul 19 2018, 5:02 PM

Change 446628 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Work around Chrome browser bug in filter menu

https://gerrit.wikimedia.org/r/446628

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)).Jul 19 2018, 6:00 PM
SBisson assigned this task to Catrope.Jul 20 2018, 6:20 PM
SBisson edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
SBisson moved this task from Incoming to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
Etonkovidova added subscribers: SBisson, Etonkovidova.Jul 21 2018, 7:28 AM

@Catrope, @SBisson - Checked in betalabs (Chrome/FF/Safari and IE) - the spaciousness is fixed, but another misalignment (the label is vertically centered and not aligned with the checkbox) is present across all checked browsers:

Screen Shot 2018-07-21 at 9.20.09 AM.png (591×707 px, 106 KB)

• Petar.petkovic removed a project: Patch-For-Review.Jul 23 2018, 8:32 AM
Etonkovidova mentioned this in T200364: [wmf.14-minor] Misalignment of labels - RC filters.Jul 25 2018, 6:59 PM

Filed all misaligned minor issues as a separate ticket - T200364: [wmf.14-minor] Misalignment of labels - RC filters.

Etonkovidova closed this task as Resolved.Jul 25 2018, 7:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL