Page MenuHomePhabricator

GlobalPreferences breaks Echo notification blacklist
Closed, ResolvedPublic


Steps to reproduce on a beta cluster wiki:

  1. Ensure you don't have any users in your Special:Preferences echo blacklist (Muted users under Notifications).
  2. Go to Special:GlobalPreferences.
  3. Enable a global override for the blacklist and ensure that it's empty.
  4. Hit save.

Expected: The global blacklist is enabled but empty.
Actual: The global blacklist magically has a user inserted. The user is not in my local blacklist for any wikis.

Triaging this as high priority. Bug introduced as part of the work done in T198935.

Event Timeline

Niharika created this task.

Let's re-assess on Monday and revert if bug is not fixed before next train.

Change 447104 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/GlobalPreferences@master] Fix global user 1 popping up in Echo blacklist

Change 447104 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] Fix global user 1 popping up in Echo blacklist

Niharika moved this task from QA to Q1 2018-19 on the Community-Tech-Sprint board.