Page MenuHomePhabricator
Create Task
Maniphest T199954

GlobalPreferences breaks Echo notification blacklist
Closed, ResolvedPublic
Actions

Description

Steps to reproduce on a beta cluster wiki:

  1. Ensure you don't have any users in your Special:Preferences echo blacklist (Muted users under Notifications).
  2. Go to Special:GlobalPreferences.
  3. Enable a global override for the blacklist and ensure that it's empty.
  4. Hit save.

Expected: The global blacklist is enabled but empty.
Actual: The global blacklist magically has a user inserted. The user is not in my local blacklist for any wikis.

Triaging this as high priority. Bug introduced as part of the work done in T198935.

Details

SubjectRepoBranchLines +/-
Fix global user 1 popping up in Echo blacklistmediawiki/extensions/GlobalPreferencesmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Niharika triaged this task as High priority.Jul 18 2018, 10:03 PM
Niharika created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 18 2018, 10:03 PM
Niharika added a comment.Jul 18 2018, 10:04 PM

Let's re-assess on Monday and revert if bug is not fixed before next train.

Niharika added a project: Notifications.Jul 18 2018, 10:11 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 18 2018, 10:11 PM
Niharika updated the task description. (Show Details)Jul 18 2018, 10:12 PM
Mooeypoo moved this task from Ready to In Development on the Community-Tech-Sprint board.Jul 19 2018, 10:51 PM
SBisson moved this task from Inbox to External on the Growth-Team board.Jul 20 2018, 4:48 PM
gerritbot subscribed.Jul 20 2018, 9:52 PM

Change 447104 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/GlobalPreferences@master] Fix global user 1 popping up in Echo blacklist

https://gerrit.wikimedia.org/r/447104

gerritbot added a project: Patch-For-Review.Jul 20 2018, 9:52 PM
gerritbot added a comment.Jul 21 2018, 12:37 AM

Change 447104 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] Fix global user 1 popping up in Echo blacklist

https://gerrit.wikimedia.org/r/447104

Mooeypoo moved this task from In Development to QA on the Community-Tech-Sprint board.Jul 21 2018, 12:37 AM
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)).Jul 21 2018, 1:00 AM
Niharika added a project: Community-Tech.Jul 27 2018, 9:08 PM
Niharika moved this task from New & TBD Tickets to In Sprint 🏃‍♀️🏃‍♂️ on the Community-Tech board.Jul 27 2018, 9:11 PM
Niharika closed this task as Resolved.Jul 27 2018, 11:38 PM
Niharika moved this task from QA to Q1 2018-19 on the Community-Tech-Sprint board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits