Page MenuHomePhabricator

Clean up the mess with one-off transformations for some preferences
Closed, ResolvedPublic

Description

This is a spinoff from T198273: Create an API module to allow apps to read local overrides . Preferences email-blacklist and echo-notifications-blacklist have hardcoded transformations applied to them. As a result, meta=userinfo&uiprop=options API unexpectedly returns an array for these preferences, while interaction between core, Echo and GlobalPreferences becomes much messier.

The current plan I'm working on is to make the internal representation the same as stored by implementing a concept of filters for preference values between form fields and the rest of MediaWiki.

Details

Related Gerrit Patches:
mediawiki/extensions/GlobalPreferences : masterGet rid of special casing for multiuser preferences
mediawiki/extensions/Echo : masterGet rid of special casing for user blacklist
mediawiki/core : masterIntroduce preference filters

Event Timeline

MaxSem created this task.Jul 6 2018, 3:07 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 6 2018, 3:07 AM
MaxSem claimed this task.Jul 6 2018, 3:08 AM
MaxSem moved this task from Ready to In Development on the Community-Tech-Sprint board.

Change 444273 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/core@master] WIP: Introduce preference filters

https://gerrit.wikimedia.org/r/444273

Change 444753 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/Echo@master] Get rid of special casing for user blacklist

https://gerrit.wikimedia.org/r/444753

Change 445048 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/GlobalPreferences@master] Get rid of special casing for multiuser preferences

https://gerrit.wikimedia.org/r/445048

Change 444273 merged by jenkins-bot:
[mediawiki/core@master] Introduce preference filters

https://gerrit.wikimedia.org/r/444273

Change 444753 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Get rid of special casing for user blacklist

https://gerrit.wikimedia.org/r/444753

Change 445048 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] Get rid of special casing for multiuser preferences

https://gerrit.wikimedia.org/r/445048

Niharika closed this task as Resolved.Jul 27 2018, 12:49 AM
Niharika moved this task from QA to Q1 2018-19 on the Community-Tech-Sprint board.