Page MenuHomePhabricator

[BUG] Picture of the day's description is truncated
Closed, ResolvedPublic

Description

How many times were you able to reproduce it?

5/5

On regular phones, description is truncated on landscape. On smaller phones (iPhone SE), description is truncated on portrait and disappears on landscape.

Steps to reproduce 1

  1. On an iPhone different than SE (device or simulator), tap on Picture of the day feed card
  2. Rotate to landscape

Expected results

Description is visible

Actual results

Description is truncated

Steps to reproduce 2

  1. On a smaller iPhone (for example, SE), tap on Picture of the day feed card
  2. Rotate to landscape

Expected results

Description is visible

Actual results

Description disappears

Environments observed

App version: 5.8.2, latest
OS versions: 11.4 (all?)
Device model: iPhone X, iPhone SE
Device language: EN

Related Objects

Mentioned In
rAPIOS8dcef00ed9aa: Merge pull request #2657 from wikimedia/fix/gallery-descriptions-follow…
rAPIOS36992860ef87: Merge pull request #2587 from wikimedia/fix/gallery-truncation/T200268
rAPIOS317051932fb9: Merge branch 'develop' into fix/gallery-truncation/T200268
rAPIOS4d1bd8456eaa: Merge branch 'develop' into fix/gallery-truncation/T200268
rAPIOS81691fdc43cc: Merge branch 'develop' into fix/gallery-truncation/T200268
rAPIOS751b2e7526e9: Merge branch 'develop' into fix/gallery-truncation/T200268
rAPIOS21eefa0f561a: Merge branch 'develop' into fix/gallery-truncation/T200268
rAPIOS3dd167f71659: Merge branch 'develop' into fix/gallery-truncation/T200268
rAPIOS788f0a93e4a9: Merge branch 'develop' into fix/gallery-truncation/T200268
rAPIOSe5f8a3a710af: Merge branch 'develop' into fix/gallery-truncation/T200268
rAPIOSfaa80852186e: Merge branch 'develop' into fix/gallery-truncation/T200268
rAPIOS9c9f4e715c9f: Merge branch 'develop' into fix/gallery-truncation/T200268
rAPIOS6fb01818664d: Merge branch 'develop' into fix/gallery-truncation/T200268
rAPIOS31c1bfc134e9: Merge branch 'develop' into fix/gallery-truncation/T200268
rAPIOSbd4485a853f6: Merge branch 'develop' into fix/gallery-truncation/T200268
rAPIOS47f73dbeac8c: Merge branch 'develop' into fix/gallery-truncation/T200268
rAPIOS68af3b952f01: Merge branch 'develop' into fix/gallery-truncation/T200268
rAPIOSbc4b3036cbf3: Merge branch 'develop' into fix/gallery-truncation/T200268
rAPIOS0f31e5b840fb: Merge branch 'develop' into fix/gallery-truncation/T200268
rAPIOS795aa64cd1ec: Merge branch 'develop' into fix/gallery-truncation/T200268

Event Timeline

Per @cmadeo:

  • we can do the tap to expand, but only in the expanded state should it be scrollable
  • only in the expanded state should the text view use its internal top and bottom gradients
  • try to get the ... back for minimized state

@ABorbaWMF Testing on iPhone SE with iOS 12 and Wikipedia app 6.1.0 (1506). As shown in the screencaps below the good news is that the description doesn't disappear when rotated to landscape, however the description is truncated and has to be scrolled - it doesn't display on screen all at the same time as it does in portrait. So now iPhone SE's Steps to reproduce 2 bug is fixed but it has the issue of the other iPhones (Steps to reproduce 1).

T200268 Portrait.PNG (1×640 px, 447 KB)
T200268 Landscape 1.PNG (640×1 px, 357 KB)
T200268 Landscape 2.PNG (640×1 px, 353 KB)