Page MenuHomePhabricator

Several extensions affected by AvailableRightsTest::testAllRightsWithMessage PHPUnit test failure
Closed, ResolvedPublic

Description

Extensions that add rights should have the corresponding right documentation in the form of right-$rightname in their en.json and qqq.json. Recent build updates by @Legoktm's libraryupgrade bot is uncovering some of those missing strings. This is a task to reference all the fixes made on those extensions for posterity.

Raw output (extension.json-only extensions)

1MISSING: ApprovedRevs: viewapprover
2MISSING: ArticleToCategory2: author
3MISSING: ArticleToCategory2: authorprotect
4MISSING: Athena: athena
5MISSING: BibManager: bibmanageredit
6MISSING: BibManager: bibmanagerdelete
7MISSING: BibManager: bibmanagercreate
8MISSING: BlueSpiceAbout: bluespiceabout-viewspecialpage
9MISSING: BlueSpiceBlog: blog-viewspecialpage
10MISSING: BlueSpiceCategoryManager: categorymanager-viewspecialpage
11MISSING: BlueSpiceChecklist: checklistmodify
12MISSING: BlueSpiceConfigManager: bluespiceconfigmanager-viewspecialpage
13MISSING: BlueSpiceDashboards: dashboards-viewspecialpage-userdashboard
14MISSING: BlueSpiceExtendedStatistics: right-statistic-viewspecialpage
15MISSING: BlueSpiceGroupManager: groupmanager-viewspecialpage
16MISSING: BlueSpiceInterWikiLinks: interwikilinks-viewspecialpage
17MISSING: BlueSpiceNamespaceManager: namespacemanager-viewspecialpage
18MISSING: BlueSpicePageAccess: pageaccess-viewspecialpage
19MISSING: BlueSpicePageTemplates: pagetemplatesadmin-viewspecialpage
20MISSING: BlueSpicePermissionManager: permissionmanager-viewspecialpage
21MISSING: BlueSpiceRSSFeeder: rssfeeder-viewspecialpage
22MISSING: BlueSpiceReaders: viewreaders
23MISSING: BlueSpiceUsageTracker: usagetracker-update
24MISSING: BlueSpiceUserManager: usermanager-viewspecialpage
25MISSING: Cargo: recreatecargodata
26MISSING: Cargo: deletecargodata
27MISSING: LdapGroups: manageldapgroups
28MISSING: LinkedWiki: data-edit
29MISSING: MathSearch: mathwmcsubmit
30MISSING: MintyDocs: mintydocs-administer
31MISSING: MintyDocs: mintydocs-edit
32MISSING: MultiLanguageManager: language
33MISSING: SecureAuth: sa-access
34MISSING: WikibaseMediaInfo: mediainfo-term

To-Do list

  • AdvancedMeta
  • ApprovedRevs
  • ArticleRatings
  • ArticleToCategory2 (T201144)
  • Athena
  • BibManager
  • BlockAndNuke
  • BlueSpiceAbout
  • BlueSpiceBlog
  • BlueSpiceCategoryManager
  • BlueSpiceChecklist
  • BlueSpiceConfigManager
  • BlueSpiceDashboards
  • BlueSpiceExtendedStatistics
  • BlueSpiceGroupManager
  • BlueSpiceInterWikiLinks
  • BlueSpiceNamespaceManager
  • BlueSpicePageAccess
  • BlueSpicePageTemplates
  • BlueSpicePermissionManager
  • BlueSpiceReaders
  • BlueSpiceRSSFeeder
  • BlueSpiceUsageTracker
  • BlueSpiceUserManager
  • Cargo (449461)
  • GoogleLogin
  • LdapGroups
  • LinkedWiki (T200815)
  • MarkAsHelpful
  • PageBlock
  • MathSearch (T200850)
  • MintyDocs (449494)
  • MultiLanguageManager (T200894)
  • Push
  • SecureAuth (T200617)
  • SmiteSpam
  • SpellingDictionary
  • StopForumSpam
  • WatchSubpages
  • WikibaseMediaInfo (T201304)

Details

SubjectRepoBranchLines +/-
mediawiki/extensions/BlueSpiceInterWikiLinksmaster+4 -2
mediawiki/extensions/BlueSpiceCategoryManagermaster+4 -2
mediawiki/extensions/MultiLanguageManagermaster+4 -2
mediawiki/extensions/Athenamaster+6 -2
mediawiki/extensions/LinkedWikimaster+3 -2
mediawiki/extensions/LinkedWikimaster+4 -2
mediawiki/extensions/MarkAsHelpfulmaster+8 -2
mediawiki/extensions/LdapGroupsmaster+12 -3
mediawiki/extensions/BibManagermaster+185 -179
mediawiki/extensions/SpellingDictionarymaster+7 -3
mediawiki/extensions/WatchSubpagesmaster+4 -2
mediawiki/extensions/Pushmaster+2 -0
mediawiki/extensions/PageBlockmaster+4 -2
mediawiki/extensions/GoogleLoginmaster+2 -0
mediawiki/extensions/SmiteSpammaster+2 -0
mediawiki/extensions/StopForumSpammaster+10 -4
mediawiki/extensions/AdvancedMetamaster+4 -2
mediawiki/extensions/ArticleRatingsmaster+4 -1
mediawiki/extensions/BlockAndNukemaster+8 -4
Show related patches Customize query in gerrit

Related Objects

Mentioned In
T206299: QuizTabulate missing 'viewquiztabulate' message (AvailableRightsTest::testAllRightsWithMessage test failure)
T206292: OfflineImportLexicon missing 'offlineimportlexicon' message (AvailableRightsTest::testAllRightsWithMessage test failure)
T201304: User right 'mediainfo-term' description is missing and causes PHPUnit failures
rEBSB829af97f1861: Revert "Add message for right "statistic-viewspecialpage". T200565"
T201144: [ArticleToCategory2] Add missing 'right.*' messages to the extension
T201143: [ArticleToCategory2] Conflicting user rights naming
rEBTV9eb3d0783137: Merge "Add message for right "usagetracker-update". T200565"
rEBSU398d6b458177: Add messages for rights T200565
rEBSU88fcabfbc2e3: Add message for right "usermanager-viewspecialpage". T200565
rEBTVc7cf398a79e4: Add message for right "usagetracker-update". T200565
rEBSOa78d65681801: Add message for right "bluespiceconfigmanager-viewspecialpage". T200565
rEBTF8bf601a9afd0: Add message "interwikilinks-viewspecialpage". T200565
rEBTFc487ed361d6c: Add message "interwikilinks-viewspecialpage"
rEBSUa63dcb096660: Add message for right "usermanager-viewspecialpage". T200565
rEBSUe208f699af88: Add message for right "usermanager-viewspecialpage". T200565
rEBTR1f8c03b888e7: Add message for right "rssfeeder-viewspecialpage". T200565
rEBSJ2f1a5a4f07c8: Add message for right "permissionmanager-viewspecialpage". T200565
rEBSLedc4eb5eca0b: Fixed message for right "pagetemplatesadmin-viewspecialpage". T200565
rEBTQ7925b5d1ba87: Add message for right "pageaccess-viewspecialpage". T200565
rEBSM06d4774328a7: Add message for right "categorymanager-viewspecialpage"
rEBSN3d270bf81fe6: Add message for right "namespacemanager-viewspecialpage". T200565
rEBSBc75781a72589: Add message for right "statistic-viewspecialpage". T200565
rEBSB810e3478b627: Add message for right "statistic-viewspecialpage". T200565
rEBSK265cecb3efb6: Add message for right "groupmanager-viewspecialpage". T200565
rEBTJ046d34aa8ba4: Add message for right "bluespiceabout-viewspecialpage". T200565
rEBTD583f60860f8c: Add message for right "dashboards-viewspecialpage-userdashboard". T200565
rEBSZ2b7903cc611d: Add message for right "blog-viewspecialpage". T200565
rEBSZ47a41220c894: Add message for right "blog-viewspecialpage". T200565
rEMLMbf301b7b8cde: Add message for "right-language"
rEBTA77bbcb4545ed: Add message for right "checklistmodify". T200565
rEBSM3acea44c0723: Add message for right "categorymanager-viewspecialpage". T200565
T200894: [MultiLanguageManager] 'right-language' is missing and causes PHPUnit failures
T200850: 'right-mathwmcsubmit' is missing on i18n files causing PHPUnit failures
rEATHd042e4c8dac9: Document 'right-athena' and 'action-athena'
rEATHc1b0218155ef: Document 'right-athena' and 'action-athena'
T200815: right-data-edit needs documentation
rELDG9623d908a636: Document 'right-manageldapgroups'
T200617: Document 'right-sa-access'
rEARAacda3d388837: Document 'right-change-rating'
rEARA2c82684186f6: Document 'right-change-rating' to unblock AvailableRightsTest…
Mentioned Here
T201304: User right 'mediainfo-term' description is missing and causes PHPUnit failures
T201144: [ArticleToCategory2] Add missing 'right.*' messages to the extension
T200894: [MultiLanguageManager] 'right-language' is missing and causes PHPUnit failures
T200850: 'right-mathwmcsubmit' is missing on i18n files causing PHPUnit failures
T200815: right-data-edit needs documentation
P7397 (An Untitled Masterwork)
T200617: Document 'right-sa-access'

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 449487 merged by MarcoAurelio:
[mediawiki/extensions/LinkedWiki@master] Document 'right-data-edit'

https://gerrit.wikimedia.org/r/449487

Change 449709 had a related patch set uploaded (by Karima Rafes; owner: Karima Rafes):
[mediawiki/extensions/LinkedWiki@master] Update docs

https://gerrit.wikimedia.org/r/449709

Change 449709 merged by Karima Rafes:
[mediawiki/extensions/LinkedWiki@master] Update docs

https://gerrit.wikimedia.org/r/449709

Change 449498 merged by jenkins-bot:
[mediawiki/extensions/Athena@master] Document 'right-athena' and 'action-athena'

https://gerrit.wikimedia.org/r/449498

Change 449940 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/BlueSpiceAbout@master] Add message for right "bluespiceabout-viewspecialpage". T200565

https://gerrit.wikimedia.org/r/449940

Change 449941 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/BlueSpiceBlog@master] Add message for right "blog-viewspecialpage". T200565

https://gerrit.wikimedia.org/r/449941

Change 449946 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/BlueSpiceCategoryManager@master] Add message for right "categorymanager-viewspecialpage". T200565

https://gerrit.wikimedia.org/r/449946

Change 449948 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/BlueSpiceChecklist@master] Add message for right "checklistmodify". T200565

https://gerrit.wikimedia.org/r/449948

Change 449952 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/BlueSpiceConfigManager@master] Add message for right "bluespiceconfigmanager-viewspecialpage". T200565

https://gerrit.wikimedia.org/r/449952

Change 449953 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/BlueSpiceDashboards@master] Add message for right "dashboards-viewspecialpage-userdashboard". T200565

https://gerrit.wikimedia.org/r/449953

Change 449936 had a related patch set uploaded (by MarcoAurelio; owner: Pwirth):
[mediawiki/extensions/MultiLanguageManager@master] Add message for "right-language"

https://gerrit.wikimedia.org/r/449936

Change 449956 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/BlueSpiceExtendedStatistics@master] Add message for right "statistic-viewspecialpage". T200565

https://gerrit.wikimedia.org/r/449956

Change 449936 merged by jenkins-bot:
[mediawiki/extensions/MultiLanguageManager@master] Add message for "right-language"

https://gerrit.wikimedia.org/r/449936

Change 449966 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/BlueSpiceGroupManager@master] Add message for right "groupmanager-viewspecialpage". T200565

https://gerrit.wikimedia.org/r/449966

Change 449972 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/BlueSpiceInterWikiLinks@master] Add message "interwikilinks-viewspecialpage". T200565

https://gerrit.wikimedia.org/r/449972

Change 449973 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/BlueSpiceNamespaceManager@master] Add message for right "namespacemanager-viewspecialpage". T200565

https://gerrit.wikimedia.org/r/449973

Change 449972 had a related patch set uploaded (by MarcoAurelio; owner: Pwirth):
[mediawiki/extensions/BlueSpiceInterWikiLinks@master] Add message "interwikilinks-viewspecialpage"

https://gerrit.wikimedia.org/r/449972

Change 449946 had a related patch set uploaded (by MarcoAurelio; owner: Pwirth):
[mediawiki/extensions/BlueSpiceCategoryManager@master] Add message for right "categorymanager-viewspecialpage"

https://gerrit.wikimedia.org/r/449946

Change 449976 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/BlueSpicePageAccess@master] Add message for right "pageaccess-viewspecialpage". T200565

https://gerrit.wikimedia.org/r/449976

Change 449977 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/BlueSpicePageTemplates@master] Fixed message for right "pagetemplatesadmin-viewspecialpage". T200565

https://gerrit.wikimedia.org/r/449977

Change 449980 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/BlueSpicePermissionManager@master] Add message for right "permissionmanager-viewspecialpage". T200565

https://gerrit.wikimedia.org/r/449980

Change 449983 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/BlueSpiceRSSFeeder@master] Add message for right "rssfeeder-viewspecialpage". T200565

https://gerrit.wikimedia.org/r/449983

Change 449985 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/BlueSpiceUserManager@master] Add message for right "usermanager-viewspecialpage". T200565

https://gerrit.wikimedia.org/r/449985

Change 450001 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/BlueSpiceUsageTracker@master] Add message for right "usagetracker-update". T200565

https://gerrit.wikimedia.org/r/450001

Change 449980 merged by jenkins-bot:
[mediawiki/extensions/BlueSpicePermissionManager@master] Add message for right "permissionmanager-viewspecialpage". T200565

https://gerrit.wikimedia.org/r/449980

Change 450001 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceUsageTracker@master] Add message for right "usagetracker-update". T200565

https://gerrit.wikimedia.org/r/450001

Change 449983 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceRSSFeeder@master] Add message for right "rssfeeder-viewspecialpage". T200565

https://gerrit.wikimedia.org/r/449983

Change 449966 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceGroupManager@master] Add message for right "groupmanager-viewspecialpage". T200565

https://gerrit.wikimedia.org/r/449966

Change 449956 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceExtendedStatistics@master] Add message for right "statistic-viewspecialpage". T200565

https://gerrit.wikimedia.org/r/449956

Change 449953 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceDashboards@master] Add message for right "dashboards-viewspecialpage-userdashboard". T200565

https://gerrit.wikimedia.org/r/449953

Change 449948 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceChecklist@master] Add message for right "checklistmodify". T200565

https://gerrit.wikimedia.org/r/449948

Change 449946 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceCategoryManager@master] Add message for right "categorymanager-viewspecialpage"

https://gerrit.wikimedia.org/r/449946

Change 449941 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceBlog@master] Add message for right "blog-viewspecialpage". T200565

https://gerrit.wikimedia.org/r/449941

Change 449985 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceUserManager@master] Add messages for rights T200565

https://gerrit.wikimedia.org/r/449985

Change 449952 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceConfigManager@master] Add message for right "bluespiceconfigmanager-viewspecialpage". T200565

https://gerrit.wikimedia.org/r/449952

Change 449973 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceNamespaceManager@master] Add message for right "namespacemanager-viewspecialpage". T200565

https://gerrit.wikimedia.org/r/449973

Change 449976 merged by jenkins-bot:
[mediawiki/extensions/BlueSpicePageAccess@master] Add message for right "pageaccess-viewspecialpage". T200565

https://gerrit.wikimedia.org/r/449976

Change 449977 merged by jenkins-bot:
[mediawiki/extensions/BlueSpicePageTemplates@master] Fixed message for right "pagetemplatesadmin-viewspecialpage". T200565

https://gerrit.wikimedia.org/r/449977

Change 449940 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceAbout@master] Add message for right "bluespiceabout-viewspecialpage". T200565

https://gerrit.wikimedia.org/r/449940

@MarcoAurelio There is currently a known issue with this extension. The failing test will be addressed separately. We will force merge this

Change 449972 merged by Pwirth:
[mediawiki/extensions/BlueSpiceInterWikiLinks@master] Add message "interwikilinks-viewspecialpage"

https://gerrit.wikimedia.org/r/449972

MarcoAurelio updated the task description. (Show Details)
MarcoAurelio removed a project: Patch-For-Review.

Closing. Only two extensions so far remaining, and they have their own tasks. Thanks for the help.