Page MenuHomePhabricator

Get WikimediaMessages' tests running on Jenkins
Closed, ResolvedPublic

Description

The tests in WikimediaMessages are not being run on Jenkins

Details

Related Gerrit Patches:

Event Timeline

dbarratt created this task.Jul 30 2018, 1:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 30 2018, 1:27 PM

What makes you think Jenkins do not work on WikimediaMessages? I see https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/WikimediaMessages all being verified+/-1 and the same at your last patch at https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikimediaMessages/+/449177/. Do you mean a specific test? Regards.

What makes you think Jenkins do not work on WikimediaMessages? I see https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/WikimediaMessages all being verified+/-1 and the same at your last patch at https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikimediaMessages/+/449177/. Do you mean a specific test? Regards.

Yes. Sorry for the confusion.
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaMessages/+/444639#message-dafe0241a11310ed31b57de21155956ee98bc43d
I think the filename just needs to be renamed.

But since this is the only test:
https://phabricator.wikimedia.org/diffusion/EWME/browse/master/tests/phpunit/WikimediaMessagesTest.hooks.php
then none of the tests are running (other than the linter I suppose).

Change 449211 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/extensions/WikimediaMessages@master] Rename WikimediaMessagesTest.hooks.php to WikimediaMessagesHooksTest.php

https://gerrit.wikimedia.org/r/449211

dbarratt claimed this task.Jul 30 2018, 2:59 PM
dbarratt moved this task from Ready to Review on the Anti-Harassment (AHT Sprint 25) board.

@Legoktm That doesn't seem to have fixed it... is there something else that needs to change?

AFAIK extension registration autodetects PHPUnit tests inside the /tests/phpunit folder. I see Quibble did run PHPUnit tests for the extension; but if they used that file or not I am not sure.

The escaped() stuff they mention in the other patchset is only detected if you run the phan-taint-check-plugin (which is not running on that repository yet).

@Legoktm That doesn't seem to have fixed it... is there something else that needs to change?

It works fine. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaMessages/+/449369/1

Legoktm closed this task as Resolved.Jul 30 2018, 11:21 PM

Not an issue in Continuous-Integration-Config - was an issue in WikimediaMessages.

Change 449211 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMessages@master] Rename WikimediaMessagesTest.hooks.php to WikimediaMessagesHooksTest.php

https://gerrit.wikimedia.org/r/449211