Page MenuHomePhabricator
Create Task
Maniphest T200867

Uncaught TypeError: Cannot read property 'getLeadSectionElement' of undefined
Closed, ResolvedPublic
Actions

Description

Client side error seen on https://en.m.wikipedia.beta.wmflabs.org/wiki/Plantilla:Cita_web
Occurs on page load. At time of writing cannot see any noticeable issues in the UI, but we should assume that they may exist.

Likely related to recent changes T191532.

To be confirmed: I suspect this might be an unbreak now. At the very minimum this is likely to be break the availability of page issues. We may need a SWAT deploy to fix.

Details

SubjectRepoBranchLines +/-
QA: Issues should be run on integration testmediawiki/skins/MinervaNeuemaster+1 -1
Restore page issuesmediawiki/skins/MinervaNeuewmf/1.32.0-wmf.15+1 -1
Restore page issuesmediawiki/skins/MinervaNeuemaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Aug 1 2018, 2:16 AM
Restricted Application added a project: Web-Team-Backlog. · View Herald TranscriptAug 1 2018, 2:16 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdlrobson triaged this task as High priority.Aug 1 2018, 2:16 AM
Jdlrobson added a subscriber: ovasileva.

cc @ovasileva

Jdlrobson updated the task description. (Show Details)Aug 1 2018, 2:16 AM

Caused by https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/449213/

Jdlrobson raised the priority of this task from High to Unbreak Now!.Aug 1 2018, 3:03 AM

Looks like this is on master. :(
Will need to be fixed in SWAT or part of next release: https://test.m.wikipedia.org/wiki/%C5%9Eablon:GSR/2015-08-19
Easiest thing to do will be to revert that change, but the fix looks trivial.

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptAug 1 2018, 3:03 AM
gerritbot subscribed.Aug 1 2018, 3:34 AM

Change 449645 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Restore page issues

https://gerrit.wikimedia.org/r/449645

gerritbot added a project: Patch-For-Review.Aug 1 2018, 3:34 AM

Change 449646 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] QA: Issues should be run on integration test

https://gerrit.wikimedia.org/r/449646

gerritbot added a comment.Aug 1 2018, 3:34 AM

Change 449647 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@wmf/1.32.0-wmf.15] Restore page issues

https://gerrit.wikimedia.org/r/449647

Jdlrobson moved this task from To Do to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Aug 1 2018, 3:35 AM

This was picked up by https://integration.wikimedia.org/ci/view/Reading-Web/job/selenium-MinervaNeue/ but for some reason the test wasn't being run on commits. I've added a test to make sure this doesn't happen again. This change will need a SWAT - I've prepared the patch above.

Jdlrobson moved this task from Incoming to Current Sprint (and resolved 2018-19 Q1) pre-milestone on the Web-Team-Backlog board.Aug 1 2018, 7:00 AM
gerritbot added a comment.Aug 1 2018, 11:33 AM

Change 449647 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@wmf/1.32.0-wmf.15] Restore page issues

https://gerrit.wikimedia.org/r/449647

gerritbot added a comment.Aug 1 2018, 11:33 AM

Change 449645 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Restore page issues

https://gerrit.wikimedia.org/r/449645

Stashbot subscribed.Aug 1 2018, 11:45 AM

Mentioned in SAL (#wikimedia-operations) [2018-08-01T11:45:53Z] <zfilipin@deploy1001> Synchronized php-1.32.0-wmf.15/skins/MinervaNeue/: SWAT: [[gerrit:449647|Restore page issues (T200867)]] (duration: 00m 57s)

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)).Aug 1 2018, 12:01 PM
phuedx moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Aug 1 2018, 12:29 PM
phuedx closed this task as Resolved.Aug 1 2018, 5:03 PM
phuedx claimed this task.
phuedx subscribed.

Being bold.

Jdlrobson reopened this task as Open.Aug 3 2018, 1:04 AM
Jdlrobson moved this task from Ready for Signoff to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.

https://gerrit.wikimedia.org/r/449646 is still awaiting review. We want to avoid this regression ever happening again.

phuedx added a comment.Aug 3 2018, 8:32 AM

It won't but I take your point 😉

phuedx removed phuedx as the assignee of this task.Aug 3 2018, 8:32 AM
phuedx lowered the priority of this task from Unbreak Now! to Medium.
Jdrewniak moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Aug 3 2018, 1:41 PM
Jdrewniak subscribed.Aug 3 2018, 1:44 PM

LGTM. https://gerrit.wikimedia.org/r/449645 has been merged so I've merged the patch for this ticket https://gerrit.wikimedia.org/r/449646 and moving this to sign-off.

gerritbot added a comment.Aug 3 2018, 1:59 PM

Change 449646 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] QA: Issues should be run on integration test

https://gerrit.wikimedia.org/r/449646

phuedx closed this task as Resolved.Aug 3 2018, 5:25 PM
phuedx claimed this task.

Being bold… again!

Liuxinyu970226 unsubscribed.Aug 6 2018, 4:20 AM
• Phabricator_maintenance edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1); removed Web-Team-Backlog.Sep 13 2018, 6:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL