Page MenuHomePhabricator

show diff content in email notifications
Open, Needs TriagePublic

Description

steps to reproduce:

  1. enable email messages for all notification types
  2. receive a notification

actual results:

In the email it says 'X left you a mention at page Y'.

expected results:

In the email it says 'X left you a mention at page Y. here is the diff:

+ == Hello ==
+ Message text. --[[User:X|X]] August 1, 2018'

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I think they're related but not duplicate, because this is about Notifications (extension), and the other is about enotifwatchlist (core), so IIUC they'd need to be resolved separately. (But I might be wrong, as I don't know the code at all, and perhaps they both utilize the same thing at some level.)

EDIT Wrong thread

Let me make it clearer. Here is an example:

image.png (1,962×690 px, 138 KB)

The message is abbreviated with ellipsis. I want to see the whole thing, or at least a lot more than currently.

The message currently looks like this:

~2024-1 mentioned you on the ‪Kezdőlap‬ talk page in "‪Teszt‬".

@Tacsipacsi: Quo deserunt minus optio aut omnis eos. Quaerat minus impedit voluptatum explicabo eius et labore et. Tenetur qui est quia. Possimus r...

View mention: http://localhost:8010/wiki/Vita:Kezd%C5%91lap?markasread=33#Teszt

~2024-1: http://localhost:8010/wiki/Szerkeszt%C5%91:~2024-1

View changes: http://localhost:8010/w/index.php?title=Vita:Kezd%C5%91lap&oldid=prev&diff=2190


To control which emails we send you, check your preferences:
http://localhost:8010/wiki/Speci%C3%A1lis:Be%C3%A1ll%C3%ADt%C3%A1saim#mw-prefsection-echo

The content is there, even if truncated, so I think this can be called done. @Gryllida, what do you think?

For non-power-users, I think an actual diff would be harder to read than the current quote. In most cases, there are no changes other than the new message anyway.