Page MenuHomePhabricator
Create Task
Maniphest T201011

Apply schema change to translate_reviews in WMF
Closed, ResolvedPublic
Actions

Description

The ALTER TABLEs:

Where to run changes:

  • s3
  • testwiki
  • testwikidatawiki
  • advisorswiki
  • amwikimedia
  • bewikimedia
  • betawikiversity
  • brwikimedia
  • bdwikimedia
  • cawikimedia
  • collabwiki
  • hiwikimedia
  • incubatorwiki
  • legalteamwiki
  • maiwikimedia
  • mediawikiwiki
  • nowikimedia
  • otrs_wikiwiki
  • outreachwiki
  • ruwikimedia
  • sourceswiki
  • specieswiki
  • uawikimedia
  • wbwikimedia
  • wikimania2012wiki
  • wikimania2013wiki
  • wikimania2014wiki
  • wikimania2015wiki
  • wikimania2016wiki
  • wikimania2017wiki
  • wikimania2018wiki
  • wikimaniawiki
  • s4
  • commonswiki
  • s7
  • frwiktionary
  • metawiki
  • s8
  • wikidatawiki

When to run those changes:

  • Anytime

If the schema change is backwards compatible (is compatible with the current code deployed and can be performed at any time now)

  • It is backwards and forward compatible

If the schema change has been tested already on some of the test/beta wikis. Usually, as a last test, change should be applied to testwiki first.

  • Deployed and tested on Beta Cluster
  • Deployed and tested on translatewiki.net

Details

SubjectRepoBranchLines +/-
db-eqiad.php: Depool db1092, db1099:3318operations/mediawiki-configmaster+8 -8
db-eqiad.php: Depool db1094 and db1098:3317operations/mediawiki-configmaster+7 -7
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedPRODUCTION ERRORPginer-WMFT195293 503 error attempting to open multiple projects (Wikipedia and meta wiki are loading very slowly)
ResolvedLSobanskiT17441 Some tables lack unique or primary keys, may allow confusing duplicate data
ResolvedMarosteguiT201011 Apply schema change to translate_reviews in WMF
· · ·

Event Timeline

Nikerabbit created this task.Aug 2 2018, 2:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 2 2018, 2:36 PM
Nikerabbit updated the task description. (Show Details)Aug 14 2018, 8:19 AM
Nikerabbit renamed this task from WIP: Apply schema change to translate_reviews in WMF to Apply schema change to translate_reviews in WMF.Aug 14 2018, 1:09 PM
Nikerabbit edited projects, added Schema-change-in-production; removed User-Nikerabbit.
Nikerabbit updated the task description. (Show Details)
Restricted Application added a subscriber: jeblad. · View Herald TranscriptAug 14 2018, 1:09 PM
jcrespo added subscribers: jcrespo, Marostegui.Aug 14 2018, 1:14 PM
Nikerabbit moved this task from Backlog to Blocked on the Language-2018-July-September board.Aug 20 2018, 6:55 AM
Nikerabbit added a parent task: T195293: 503 error attempting to open multiple projects (Wikipedia and meta wiki are loading very slowly) .Aug 28 2018, 7:38 AM
Nikerabbit added a project: MediaWiki-extensions-Translate.
Nikerabbit mentioned this in T195293: 503 error attempting to open multiple projects (Wikipedia and meta wiki are loading very slowly) .Aug 30 2018, 9:50 AM
Marostegui triaged this task as Medium priority.Sep 3 2018, 7:14 AM
Marostegui added a comment.Sep 3 2018, 7:17 AM

Quick note: this table is small enough (10MB on commons and wikidata) that this can probably be done directly on the primary masters and let it replicate

AndyRussG subscribed.Sep 12 2018, 5:57 PM
Marostegui added a comment.Sep 14 2018, 5:50 AM

The biggest table is on metawiki which is 22M, so probably good to go directly on the masters someday early in the morning.

Marostegui updated the task description. (Show Details)Sep 14 2018, 9:34 AM
Marostegui added a parent task: T17441: Some tables lack unique or primary keys, may allow confusing duplicate data.Sep 14 2018, 10:19 AM
Stashbot subscribed.Sep 17 2018, 5:36 AM

Mentioned in SAL (#wikimedia-operations) [2018-09-17T05:36:18Z] <marostegui> Deploy schema change on s3:testwiki directly on the master (db2043) - T201011

Stashbot added a comment.Sep 17 2018, 5:47 AM

Mentioned in SAL (#wikimedia-operations) [2018-09-17T05:47:03Z] <marostegui> Deploy schema change on s3:testwikidatawiki directly on the master (db2043) - T201011

Stashbot added a comment.Sep 17 2018, 6:04 AM

Mentioned in SAL (#wikimedia-operations) [2018-09-17T06:03:58Z] <marostegui> Deploy schema change on s3 - T201011

Stashbot added a comment.Sep 17 2018, 6:31 AM

Mentioned in SAL (#wikimedia-operations) [2018-09-17T06:31:42Z] <marostegui> Deploy schema change on s4 - T201011

Marostegui updated the task description. (Show Details)Sep 17 2018, 6:33 AM
Stashbot added a comment.Sep 17 2018, 6:33 AM

Mentioned in SAL (#wikimedia-operations) [2018-09-17T06:33:31Z] <marostegui> Deploy schema change on s7 (frwiktionary,metawiki) - T201011

Marostegui updated the task description. (Show Details)Sep 17 2018, 6:34 AM
Marostegui added a comment.Sep 17 2018, 6:45 AM

For some reason db1094 (s7) already had that PK added there so it broke replication while adding it. Just to be completely sure and safe about consistency, I am going to re-import the table there from the master.

gerritbot subscribed.Sep 17 2018, 6:47 AM

Change 460786 had a related patch set uploaded (by Marostegui; owner: Marostegui):
[operations/mediawiki-config@master] db-eqiad.php: Depool db1094 and db1098:3317

https://gerrit.wikimedia.org/r/460786

gerritbot added a project: Patch-For-Review.Sep 17 2018, 6:47 AM
gerritbot added a comment.Sep 17 2018, 6:51 AM

Change 460786 merged by jenkins-bot:
[operations/mediawiki-config@master] db-eqiad.php: Depool db1094 and db1098:3317

https://gerrit.wikimedia.org/r/460786

Stashbot added a comment.Sep 17 2018, 6:53 AM

Mentioned in SAL (#wikimedia-operations) [2018-09-17T06:53:40Z] <marostegui@deploy1001> Synchronized wmf-config/db-eqiad.php: Depool db1094 and db1098:3317 - T201011 (duration: 01m 04s)

Stashbot added a comment.Sep 17 2018, 6:53 AM

Mentioned in SAL (#wikimedia-operations) [2018-09-17T06:53:51Z] <marostegui> Stop replication in sync on db1094 and db1098:3317 - T201011

Stashbot added a comment.Sep 17 2018, 7:02 AM

Mentioned in SAL (#wikimedia-operations) [2018-09-17T07:01:59Z] <marostegui@deploy1001> Synchronized wmf-config/db-eqiad.php: Repool db1094 and db1098:3317 - T201011 (duration: 00m 49s)

Marostegui added a comment.Sep 17 2018, 7:13 AM

In s8, db1092 has the same issue. So I am going to re-import the table before executing the change so replication doesn't break once I get it deployed directly on the master.

gerritbot added a comment.Sep 17 2018, 7:15 AM

Change 460792 had a related patch set uploaded (by Marostegui; owner: Marostegui):
[operations/mediawiki-config@master] db-eqiad.php: Depool db1092, db1099:3318

https://gerrit.wikimedia.org/r/460792

gerritbot added a comment.Sep 17 2018, 7:17 AM

Change 460792 merged by jenkins-bot:
[operations/mediawiki-config@master] db-eqiad.php: Depool db1092, db1099:3318

https://gerrit.wikimedia.org/r/460792

Stashbot added a comment.Sep 17 2018, 7:18 AM

Mentioned in SAL (#wikimedia-operations) [2018-09-17T07:18:43Z] <marostegui@deploy1001> Synchronized wmf-config/db-eqiad.php: Depool db1092 and db1099:3318 - T201011 (duration: 00m 49s)

Stashbot added a comment.Sep 17 2018, 7:18 AM

Mentioned in SAL (#wikimedia-operations) [2018-09-17T07:18:51Z] <marostegui> Stop replication in sync on db1092 and db1099:3318 - T201011

Stashbot added a comment.Sep 17 2018, 7:24 AM

Mentioned in SAL (#wikimedia-operations) [2018-09-17T07:24:45Z] <marostegui> Deploy schema change on s8 - T201011

Stashbot added a comment.Sep 17 2018, 7:24 AM

Mentioned in SAL (#wikimedia-operations) [2018-09-17T07:24:53Z] <marostegui@deploy1001> Synchronized wmf-config/db-eqiad.php: Repool db1092 and db1099:3318 - T201011 (duration: 00m 49s)

Marostegui closed this task as Resolved.Sep 17 2018, 7:26 AM
Marostegui claimed this task.
Marostegui updated the task description. (Show Details)

This is all done.

• Petar.petkovic removed a project: Patch-For-Review.Sep 17 2018, 8:35 AM
• Petar.petkovic moved this task from Blocked to Done on the Language-2018-July-September board.
• Petar.petkovic removed a subscriber: gerritbot.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL