Page MenuHomePhabricator
Create Task
Maniphest T201107

Archive the Reflect extension
Closed, ResolvedPublicRequest
Actions

Description

Reason: Obsolete (requires LQT), and has security flaws. Only one wiki using it in WikiApiary, and that wiki is on 1.16.x, so it wouldn't even affect them anyways.

Details

SubjectRepoBranchLines +/-
Archive the Reflect extensionintegration/configmaster+1 -2
Archive the Reflect extensiontranslatewikimaster+0 -2
Archive the Reflect extensionmediawiki/extensions/Reflectmaster+2 -19 K
Archive the Reflect extensionmediawiki/extensionsmaster+0 -5
Customize query in gerrit

Revisions and Commits

Restricted Differential Revision

Related Objects

Event Timeline

Legoktm created this task.Aug 2 2018, 9:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 2 2018, 9:48 PM
MarcoAurelio claimed this task.Aug 2 2018, 10:24 PM
MarcoAurelio subscribed.
Restricted Application added a project: User-MarcoAurelio. · View Herald TranscriptAug 2 2018, 10:24 PM
Dinoguy1000 updated the task description. (Show Details)Aug 2 2018, 11:37 PM
MarcoAurelio moved this task from unsorted/backlog to working on on the User-MarcoAurelio board.Aug 3 2018, 8:48 AM
MarcoAurelio updated the task description. (Show Details)Aug 3 2018, 9:29 AM
Liuxinyu970226 moved this task from Untriaged to Archive extensions on the Projects-Cleanup board.Aug 4 2018, 12:43 PM
Liuxinyu970226 subscribed.

Good luck! Maybe in the near future we can also consider archiving LQT.

Liuxinyu970226 awarded a token.Aug 4 2018, 12:45 PM
Liuxinyu970226 added a project: MediaWiki-extensions-Other.Aug 4 2018, 1:16 PM
Liuxinyu970226 mentioned this in T28998: "Reflect" extension full of hardcoded English text, doesn't use MW i18n system.Aug 5 2018, 12:21 AM
gerritbot subscribed.Aug 5 2018, 10:00 AM

Change 450431 had a related patch set uploaded (by MarcoAurelio; owner: MarcoAurelio):
[mediawiki/extensions@master] Archive the Reflect extension

https://gerrit.wikimedia.org/r/450431

gerritbot added a project: Patch-For-Review.Aug 5 2018, 10:00 AM

Change 450431 merged by MarcoAurelio:
[mediawiki/extensions@master] Archive the Reflect extension

https://gerrit.wikimedia.org/r/450431

MarcoAurelio updated the task description. (Show Details)Aug 5 2018, 10:02 AM
gerritbot added a comment.Aug 5 2018, 10:05 AM

Change 450435 had a related patch set uploaded (by MarcoAurelio; owner: MarcoAurelio):
[integration/config@master] Archive the Reflect extension

https://gerrit.wikimedia.org/r/450435

MarcoAurelio updated the task description. (Show Details)Aug 5 2018, 10:07 AM
gerritbot added a comment.Aug 5 2018, 10:08 AM

Change 450436 had a related patch set uploaded (by MarcoAurelio; owner: MarcoAurelio):
[translatewiki@master] Archive the Reflect extension

https://gerrit.wikimedia.org/r/450436

MarcoAurelio updated the task description. (Show Details)Aug 5 2018, 10:09 AM
gerritbot added a comment.Aug 5 2018, 10:15 AM

Change 450438 had a related patch set uploaded (by MarcoAurelio; owner: MarcoAurelio):
[mediawiki/extensions/Reflect@master] Archive the Reflect extension

https://gerrit.wikimedia.org/r/450438

gerritbot added a comment.Aug 5 2018, 10:15 AM

Change 450438 merged by MarcoAurelio:
[mediawiki/extensions/Reflect@master] Archive the Reflect extension

https://gerrit.wikimedia.org/r/450438

MarcoAurelio updated the task description. (Show Details)Aug 5 2018, 10:16 AM

I can't see any vagrant references, but I am not familiar with that so please doublecheck. I cannot delete GitHub mirrors either. These are the things that remain to do here (and few patches for review at https://gerrit.wikimedia.org/r/#/q/topic:T201107+(status:open+OR+status:merged). Thank you.

MarcoAurelio added a revision: Restricted Differential Revision.Aug 5 2018, 10:52 AM
Mainframe98 subscribed.Aug 5 2018, 11:06 AM

Grepping rMWVA mediawiki/vagrant (https://phabricator.wikimedia.org/source/mediawiki-vagrant/browse/master/?grep=reflect) doesn't show any reference to the extension.

MarcoAurelio updated the task description. (Show Details)Aug 5 2018, 11:08 AM
In T201107#4479374, @Mainframe98 wrote:

Grepping rMWVA mediawiki/vagrant (https://phabricator.wikimedia.org/source/mediawiki-vagrant/browse/master/?grep=reflect) doesn't show any reference to the extension.

Thank you. Marked as handled above :)

gerritbot added a comment.Aug 5 2018, 2:28 PM

Change 450436 merged by jenkins-bot:
[translatewiki@master] Archive the Reflect extension

https://gerrit.wikimedia.org/r/450436

MarcoAurelio added a comment.Aug 6 2018, 9:40 AM

Remaining: CI patch and GitHub.

MarcoAurelio moved this task from working on to ready/patched/SWAT on the User-MarcoAurelio board.Aug 6 2018, 10:13 AM
MarcoAurelio updated the task description. (Show Details)Aug 6 2018, 1:49 PM
Krinkle updated the task description. (Show Details)Aug 6 2018, 8:35 PM
MarcoAurelio triaged this task as Medium priority.Aug 6 2018, 9:05 PM
Krinkle closed this task as Resolved.Aug 7 2018, 7:53 PM
Krinkle updated the task description. (Show Details)
Krinkle removed a project: Patch-For-Review.
gerritbot added a comment.Aug 7 2018, 7:54 PM

Change 450435 merged by jenkins-bot:
[integration/config@master] Archive the Reflect extension

https://gerrit.wikimedia.org/r/450435

MarcoAurelio moved this task from ready/patched/SWAT to cabinet on the User-MarcoAurelio board.Aug 7 2018, 7:57 PM
Stashbot subscribed.Aug 7 2018, 7:59 PM

Mentioned in SAL (#wikimedia-releng) [2018-08-07T19:59:05Z] <Krinkle> Reloading Zuul to deploy https://gerrit.wikimedia.org/r/450435 / T201107)

Liuxinyu970226 unsubscribed.Aug 8 2018, 1:21 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits