Maniphest T201274

MediaWiki doesn't handle SVG dimensions of decimal points with no preceding digits
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Hello71
	Aug 5 2018, 5:46 PM

Description

https://commons.wikimedia.org/wiki/File:DFO_Logo.svg was parsed incorrectly by MediaWiki because its height was specified as a decimal without a leading zero and in non-pixel units. .417118in is a valid height value in SVG per W3C validator and works in librsvg 2.40.18, Inkscape, Firefox, and Chromium.

Details

	Subject	Repo	Branch	Lines +/-
	SVG: SVG unit parser support for wider range of number	mediawiki/core	master	+46 -1

Customize query in gerrit

Related Objects

Mentioned In: T194192: viewBox="0,0,620,472" should be the same as viewBox="0 0 620 472"

Event Timeline

Hello71 triaged this task as Low priority.Aug 5 2018, 5:46 PM

Hello71 created this task.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 5 2018, 5:46 PM

Works for me, cannot reproduce: https://upload.wikimedia.org/wikipedia/commons/thumb/8/8f/DFO_Logo.svg/680px-DFO_Logo.svg.png
Have you bypassed your browser cache?

(Please do not prioritize tasks if you don't plan to work on them yourself. Thanks!)

@Aklapper I assume @Hello71 is referring to the first version of the file, where the height is specified as .417118in (that first version doesn't render). The current file's height is 1.0594797cm. I think librsvg might have some issues with handling decimal points with no leading zeroes, as I've run into similar issues with the stroke-dasharray attribute.

@Aklapper I've reuploaded the original file with the only difference being that the file height is now 0.417118in. The file now works.

Jc86035 changed the task status from Stalled to Open.Aug 6 2018, 8:44 AM

Jc86035 updated the task description. (Show Details)

Ah, I am sorry! I missed the revision info in the task description.

Aklapper removed a parent task: T40010: RFC: Re-evaluate librsvg as SVG renderer on Wikimedia wikis.Aug 6 2018, 8:45 AM

@Jc86035 It could also be an issue with the SVG metadata parser of MediaWiki.

This looks suspicious: https://gerrit.wikimedia.org/g/mediawiki/core/+/master/includes/media/SVGMetadataExtractor.php#383
though the fallback i guess would create incorrect data, not so much cause missing data perhaps...

In T201274#4480188, @Aklapper wrote:

(Please do not prioritize tasks if you don't plan to work on them yourself. Thanks!)

Phab copied it from the parent ticket.

In T201274#4480445, @TheDJ wrote:

@Jc86035 It could also be an issue with the SVG metadata parser of MediaWiki.

This looks suspicious: https://gerrit.wikimedia.org/g/mediawiki/core/+/master/includes/media/SVGMetadataExtractor.php#383
though the fallback i guess would create incorrect data, not so much cause missing data perhaps...

Well in this case, the value is .417118in, so it will be entered as .417118px, which is presumably rounded to 0 somewhere else.

I uploaded https://commons.wikimedia.org/wiki/File:DFO_Logo_2x_size_test.svg with a height of .834236in to test, and it does in fact display a height of 1 pixel and also render a one pixel tall preview.

Hello71 renamed this task from librsvg doesn't handle decimal points with no preceding digits to MediaWiki doesn't handle SVG dimensions of decimal points with no preceding digits.Aug 6 2018, 12:41 PM

Hello71 updated the task description. (Show Details)

Glrx subscribed.Aug 6 2018, 3:01 PM

@Hello71 Thank you for confirming. Should be an easy fix then.

So the official SVG spec indicates it should be something more in the order of:
/^\s*([-+]?\d*(?:\.\d+|\d+)(?:[Ee][-+]?\d+)?)\s*(em|ex|px|pt|pc|cm|mm|in|%|)\s*$/

https://www.w3.org/TR/SVG/types.html#DataTypeLength
https://www.w3.org/TR/SVG/types.html#DataTypeNumber

Change 451092 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/core@master] SVG: SVG unit parser support for wider range of number

https://gerrit.wikimedia.org/r/451092

gerritbot added a project: Patch-For-Review.Aug 7 2018, 7:51 PM

Change 451092 merged by jenkins-bot:
[mediawiki/core@master] SVG: SVG unit parser support for wider range of number

https://gerrit.wikimedia.org/r/451092

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).Aug 9 2018, 9:00 PM

TheDJ closed this task as Resolved.Aug 9 2018, 9:48 PM

TheDJ claimed this task.

TheDJ removed a project: Patch-For-Review.

Glrx mentioned this in T194192: viewBox="0,0,620,472" should be the same as viewBox="0 0 620 472".Aug 10 2018, 5:55 AM

Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)); removed MW-1.32-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).Aug 14 2018, 8:55 PM