Page MenuHomePhabricator
Create Task
Maniphest T201721

Exception thrown in list diff
Closed, ResolvedPublic
Actions

Description

https://www.mediawiki.org/w/index.php?title=Visual-based_mobile_editing/Mobile_editing_documentation&type=revision&diff=2852001&oldid=2851996&diffmode=visual

Cannot read property 'isDiffedAsLeaf' of undefined TypeError: Cannot read property 'isDiffedAsLeaf' of undefined
    at VeUiDiffElement.ve.ui.DiffElement.getChangedNodeData (<anonymous>:268:268)
    at VeUiDiffElement.ve.ui.DiffElement.getChangedListNodeData (<anonymous>:271:6)
    at VeUiDiffElement.ve.ui.DiffElement.getChangedNodeData (<anonymous>:268:399)
    at VeUiDiffElement.ve.ui.DiffElement.getChangedNodeElements (<anonymous>:268:73)
    at VeUiDiffElement.processQueue (<anonymous>:262:278)
    at VeUiDiffElement.ve.ui.DiffElement.renderDiff (<anonymous>:265:360)
    at new VeUiDiffElement (<anonymous>:258:822)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update VE core submodule to master (d2e64ca7b)mediawiki/extensions/VisualEditormaster+1 -1
Unbreak visual diff results for checking node type changemediawiki/extensions/Citemaster+1 -1
Check new node diff type in visual diffVisualEditor/VisualEditormaster+28 -31
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Aug 10 2018, 8:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 10 2018, 8:43 PM
Jdforrester-WMF added projects: VisualEditor, VisualEditor-VisualDiffs.Aug 10 2018, 8:44 PM
Tchanders moved this task from To Triage to Needs Discussion/Analysis on the VisualEditor board.Sep 5 2018, 4:40 PM
JTannerWMF edited projects, added VisualEditor (Current work); removed VisualEditor.Sep 5 2018, 5:49 PM
Tchanders claimed this task.Sep 12 2018, 4:42 PM
Tchanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.
gerritbot subscribed.Sep 12 2018, 4:53 PM

Change 460052 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[VisualEditor/VisualEditor@master] Check new node diff type in visual diff

https://gerrit.wikimedia.org/r/460052

gerritbot added a project: Patch-For-Review.Sep 12 2018, 4:53 PM
Esanders added a comment.Sep 13 2018, 11:45 AM

Diff after monkey-patch

image.png (468×834 px, 78 KB)

Esanders moved this task from Code review to QA on the VisualEditor (Current work) board.Sep 13 2018, 11:46 AM
gerritbot added a comment.Sep 13 2018, 11:49 AM

Change 460052 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Check new node diff type in visual diff

https://gerrit.wikimedia.org/r/460052

gerritbot added a comment.Sep 13 2018, 5:52 PM

Change 460404 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (d2e64ca7b)

https://gerrit.wikimedia.org/r/460404

gerritbot added a comment.Sep 13 2018, 6:09 PM

Change 460407 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Cite@master] Unbreak visual diff results for checking node type change

https://gerrit.wikimedia.org/r/460407

gerritbot added a comment.Sep 13 2018, 7:03 PM

Change 460407 merged by Jforrester:
[mediawiki/extensions/Cite@master] Unbreak visual diff results for checking node type change

https://gerrit.wikimedia.org/r/460407

gerritbot added a comment.Sep 13 2018, 7:40 PM

Change 460404 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (d2e64ca7b)

https://gerrit.wikimedia.org/r/460404

Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor-EditingTools; removed Patch-For-Review.Sep 13 2018, 7:41 PM
Ryasmeen added a project: Verified.Sep 13 2018, 10:19 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
• Deskana closed this task as Resolved.Sep 28 2018, 9:55 AM
• Deskana triaged this task as Medium priority.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits