Page MenuHomePhabricator

Exception thrown in list diff
Closed, ResolvedPublic

Description

https://www.mediawiki.org/w/index.php?title=Visual-based_mobile_editing/Mobile_editing_documentation&type=revision&diff=2852001&oldid=2851996&diffmode=visual

Cannot read property 'isDiffedAsLeaf' of undefined TypeError: Cannot read property 'isDiffedAsLeaf' of undefined
    at VeUiDiffElement.ve.ui.DiffElement.getChangedNodeData (<anonymous>:268:268)
    at VeUiDiffElement.ve.ui.DiffElement.getChangedListNodeData (<anonymous>:271:6)
    at VeUiDiffElement.ve.ui.DiffElement.getChangedNodeData (<anonymous>:268:399)
    at VeUiDiffElement.ve.ui.DiffElement.getChangedNodeElements (<anonymous>:268:73)
    at VeUiDiffElement.processQueue (<anonymous>:262:278)
    at VeUiDiffElement.ve.ui.DiffElement.renderDiff (<anonymous>:265:360)
    at new VeUiDiffElement (<anonymous>:258:822)

Event Timeline

Esanders created this task.Aug 10 2018, 8:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 10 2018, 8:43 PM
Tchanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.

Change 460052 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[VisualEditor/VisualEditor@master] Check new node diff type in visual diff

https://gerrit.wikimedia.org/r/460052

Diff after monkey-patch

Change 460052 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Check new node diff type in visual diff

https://gerrit.wikimedia.org/r/460052

Change 460404 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (d2e64ca7b)

https://gerrit.wikimedia.org/r/460404

Change 460407 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Cite@master] Unbreak visual diff results for checking node type change

https://gerrit.wikimedia.org/r/460407

Change 460407 merged by Jforrester:
[mediawiki/extensions/Cite@master] Unbreak visual diff results for checking node type change

https://gerrit.wikimedia.org/r/460407

Change 460404 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (d2e64ca7b)

https://gerrit.wikimedia.org/r/460404

Deskana closed this task as Resolved.Sep 28 2018, 9:55 AM
Deskana triaged this task as Normal priority.