Page MenuHomePhabricator
Create Task
Maniphest T201838

Use link formatter that uses cache instead of wb_terms for all wikidatawiki properties
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Added setting to adjust the range of PropertyIDs using new link formatteroperations/mediawiki-configmaster+5 -0
Beta: use the new link formatter to format P1 on wikidata betaoperations/mediawiki-configmaster+5 -0
wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter fully onoperations/mediawiki-configmaster+1 -1
wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter 3000operations/mediawiki-configmaster+1 -1
Introduce wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatteroperations/mediawiki-configmaster+11 -1
Use link formatter using cache instead of wb_terms for propertiesmediawiki/extensions/Wikibasemaster+253 -3
Renamed ItemIdHtmlLinkFormatter to ItemPropertyIdHtmlLinkFormattermediawiki/extensions/Wikibasemaster+14 -14
Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-leszek created this task.EditedAug 13 2018, 1:42 PM

Planned to happen on Tue 2018-09-04.

WMDE-leszek mentioned this in T201831: Deploy item/property link formatter that uses cache instead of wb_terms DB table.Aug 13 2018, 1:45 PM
WMDE-leszek triaged this task as Medium priority.Aug 13 2018, 1:54 PM
WMDE-leszek removed a project: Tracking-Neverending.
WMDE-leszek set Due Date to Aug 29 2018, 5:00 PM.Aug 22 2018, 7:34 AM
Restricted Application changed the subtype of this task from "Task" to "Deadline". · View Herald TranscriptAug 22 2018, 7:34 AM
WMDE-leszek changed Due Date from Aug 29 2018, 5:00 PM to Aug 30 2018, 5:00 PM.Aug 24 2018, 11:46 AM
WMDE-leszek changed Due Date from Aug 30 2018, 5:00 PM to Sep 4 2018, 5:00 PM.Aug 24 2018, 12:34 PM
WMDE-leszek removed Due Date.Sep 22 2018, 5:33 PM
WMDE-leszek added a project: Wikidata-Campsite.
WMDE-leszek edited subscribers, added: Addshore; removed: • Aleksey_WMDE.
Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptSep 22 2018, 5:33 PM
Addshore added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Oct 16 2018, 1:38 PM
Addshore moved this task from incoming to in progress on the Wikidata board.Oct 16 2018, 1:49 PM
Addshore removed a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Nov 1 2018, 11:14 AM
Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Addshore renamed this task from Use link formatter that uses cache instead of wb_terms for all properties to Use link formatter that uses cache instead of wb_terms for all wikidatawiki properties.Nov 12 2018, 5:43 PM
Addshore claimed this task.
Addshore moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Restricted Application added a project: User-Addshore. · View Herald TranscriptNov 12 2018, 5:44 PM
Addshore removed Addshore as the assignee of this task.Dec 17 2018, 2:25 PM
Addshore moved this task from Doing to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

@WMDE-leszek afaik this isn't just config switch right?
This requires either changing the default entity id formatter or adding this new one specifically for PT:wikibase-property ?
It's a bit odd as the thing is called ItemIdHtmlLinkFormatter :/

WMDE-leszek added a comment.Dec 18 2018, 4:46 PM

It is not only config change indeed.

It's a bit odd as the thing is called ItemIdHtmlLinkFormatter

yeah, it might not be that obvious, especially that currently the code in this class is basically the same as in LabelsProviderEntityIdHtmlLinkFormatter.
To quote the commit message of aef2372916411750a2d2a1274958ca1400ffb261: "This (separating the link formatter for itemd IDs) is needed to be able to evolve it separately from the one for Properties."

Those formatters haven't evolved that far away just yet. I am not sure if this is going to happen. I do remember though that the existing formatter weren't perfect (e.g. link's "title" attribute showing ID, whereas there were ideas it could e.g. show description). So it does not seem necessary to have a separate formatter class for property IDs (this statement with a remark that I am not aware of detailed plans of UI changes, so might be completely wrong). It might be better to rename ItemIdHtmlLinkFormatter, or even more drastically fold it back to LabelsProviderEntityIdHtmlLinkFormatter, if they're really 100% the same, and are only is used in the very same contexts.

Code changes related to property formatting coming up!

WMDE-leszek added a comment.Dec 18 2018, 4:48 PM

and LabelsProviderEntityIdHtmlLinkFormatter indeed seems to be used more broadly than ItemIdHtmlLinkFormatter so it might be better to be careful with jumping to conclusions too early (I mean conclusions on merging those two classes)

gerritbot subscribed.Dec 18 2018, 5:44 PM

Change 480547 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Renamed ItemIdHtmlLinkFormatter to ItemPropertyIdHtmlLinkFormatter

https://gerrit.wikimedia.org/r/480547

gerritbot added a project: Patch-For-Review.Dec 18 2018, 5:44 PM

Change 480548 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Use link formatter using cache instead of wb_terms for properties

https://gerrit.wikimedia.org/r/480548

gerritbot added a comment.Dec 18 2018, 5:47 PM

Change 480550 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[operations/mediawiki-config@master] Added setting to adjust the range of PropertyIDs using new link formatter

https://gerrit.wikimedia.org/r/480550

gerritbot added a comment.Dec 18 2018, 5:47 PM

Change 480551 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[operations/mediawiki-config@master] Beta: use the new link formatter to format P1 on wikidata beta

https://gerrit.wikimedia.org/r/480551

Addshore moved this task from Stalled/Waiting to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 19 2018, 5:37 PM
Addshore added a comment.Jan 4 2019, 11:29 AM

I just +2ed both patches, after the train next week the config changes can also roll out.

gerritbot added a comment.Jan 4 2019, 11:56 AM

Change 480547 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Renamed ItemIdHtmlLinkFormatter to ItemPropertyIdHtmlLinkFormatter

https://gerrit.wikimedia.org/r/480547

gerritbot added a comment.Jan 4 2019, 11:56 AM

Change 480548 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use link formatter using cache instead of wb_terms for properties

https://gerrit.wikimedia.org/r/480548

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.12; 2019-01-08).Jan 4 2019, 12:00 PM
Addshore moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 9 2019, 12:29 AM

Moving to to verify as T201831 covers the deployment of this.
Of course this can't be verified until it is deployed somewhere..

gerritbot added a comment.Jan 14 2019, 3:54 PM

Change 484245 had a related patch set uploaded (by Addshore; owner: Addshore):
[operations/mediawiki-config@master] Introduce wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter

https://gerrit.wikimedia.org/r/484245

gerritbot added a comment.Jan 14 2019, 3:57 PM

Change 484247 had a related patch set uploaded (by Addshore; owner: Addshore):
[operations/mediawiki-config@master] wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter 3000

https://gerrit.wikimedia.org/r/484247

gerritbot added a comment.Jan 14 2019, 3:58 PM

Change 484248 had a related patch set uploaded (by Addshore; owner: Addshore):
[operations/mediawiki-config@master] wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter fully on

https://gerrit.wikimedia.org/r/484248

gerritbot added a comment.Jan 14 2019, 5:06 PM

Change 484245 merged by jenkins-bot:
[operations/mediawiki-config@master] Introduce wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter

https://gerrit.wikimedia.org/r/484245

Stashbot subscribed.Jan 14 2019, 5:08 PM

Mentioned in SAL (#wikimedia-operations) [2019-01-14T17:08:42Z] <addshore@deploy1001> Synchronized wmf-config/InitialiseSettings.php: T201831 T201838 Introduce wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter PT 1/2 (duration: 00m 47s)

Stashbot added a comment.Jan 14 2019, 5:09 PM

Mentioned in SAL (#wikimedia-operations) [2019-01-14T17:09:44Z] <addshore@deploy1001> Synchronized wmf-config/Wikibase.php: T201831 T201838 Introduce wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter PT 2/2 (duration: 00m 45s)

gerritbot added a comment.Jan 14 2019, 5:11 PM

Change 484247 merged by jenkins-bot:
[operations/mediawiki-config@master] wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter 3000

https://gerrit.wikimedia.org/r/484247

Stashbot added a comment.Jan 14 2019, 5:11 PM

Mentioned in SAL (#wikimedia-operations) [2019-01-14T17:11:45Z] <addshore@deploy1001> sync-file aborted: T201831 T201838 wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter 3000 (duration: 00m 01s)

Stashbot added a comment.Jan 14 2019, 5:13 PM

Mentioned in SAL (#wikimedia-operations) [2019-01-14T17:13:05Z] <addshore@deploy1001> Synchronized wmf-config/InitialiseSettings.php: T201831 T201838 wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter 3000 (duration: 00m 46s)

gerritbot added a comment.Jan 14 2019, 5:20 PM

Change 484248 merged by jenkins-bot:
[operations/mediawiki-config@master] wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter fully on

https://gerrit.wikimedia.org/r/484248

Stashbot added a comment.Jan 14 2019, 5:21 PM

Mentioned in SAL (#wikimedia-operations) [2019-01-14T17:21:57Z] <addshore@deploy1001> Synchronized wmf-config/InitialiseSettings.php: T201831 T201838 wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter fully on (duration: 00m 46s)

Addshore closed this task as Resolved.Jan 15 2019, 9:21 AM
Addshore claimed this task.
Addshore moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Feb 11 2019, 3:02 PM

Change 480551 abandoned by WMDE-leszek:
Beta: use the new link formatter to format P1 on wikidata beta

https://gerrit.wikimedia.org/r/480551

gerritbot added a comment.Feb 11 2019, 3:02 PM

Change 480550 abandoned by WMDE-leszek:
Added setting to adjust the range of PropertyIDs using new link formatter

https://gerrit.wikimedia.org/r/480550

Addshore mentioned this in T237984: Some property labels are not displayed on Item pages.Dec 17 2019, 10:25 AM
Addshore mentioned this in T241050: Investigate if FormatterCache is actually used everywhere it should be when rendering an entity.Dec 18 2019, 12:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL