Details
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | Addshore | T201831 Deploy item/property link formatter that uses cache instead of wb_terms DB table | |||
Resolved | Addshore | T201838 Use link formatter that uses cache instead of wb_terms for all wikidatawiki properties |
Event Timeline
@WMDE-leszek afaik this isn't just config switch right?
This requires either changing the default entity id formatter or adding this new one specifically for PT:wikibase-property ?
It's a bit odd as the thing is called ItemIdHtmlLinkFormatter :/
It is not only config change indeed.
It's a bit odd as the thing is called ItemIdHtmlLinkFormatter
yeah, it might not be that obvious, especially that currently the code in this class is basically the same as in LabelsProviderEntityIdHtmlLinkFormatter.
To quote the commit message of aef2372916411750a2d2a1274958ca1400ffb261: "This (separating the link formatter for itemd IDs) is needed to be able to evolve it separately from the one for Properties."
Those formatters haven't evolved that far away just yet. I am not sure if this is going to happen. I do remember though that the existing formatter weren't perfect (e.g. link's "title" attribute showing ID, whereas there were ideas it could e.g. show description). So it does not seem necessary to have a separate formatter class for property IDs (this statement with a remark that I am not aware of detailed plans of UI changes, so might be completely wrong). It might be better to rename ItemIdHtmlLinkFormatter, or even more drastically fold it back to LabelsProviderEntityIdHtmlLinkFormatter, if they're really 100% the same, and are only is used in the very same contexts.
Code changes related to property formatting coming up!
and LabelsProviderEntityIdHtmlLinkFormatter indeed seems to be used more broadly than ItemIdHtmlLinkFormatter so it might be better to be careful with jumping to conclusions too early (I mean conclusions on merging those two classes)
Change 480547 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Renamed ItemIdHtmlLinkFormatter to ItemPropertyIdHtmlLinkFormatter
Change 480548 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Use link formatter using cache instead of wb_terms for properties
Change 480550 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[operations/mediawiki-config@master] Added setting to adjust the range of PropertyIDs using new link formatter
Change 480551 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[operations/mediawiki-config@master] Beta: use the new link formatter to format P1 on wikidata beta
I just +2ed both patches, after the train next week the config changes can also roll out.
Change 480547 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Renamed ItemIdHtmlLinkFormatter to ItemPropertyIdHtmlLinkFormatter
Change 480548 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use link formatter using cache instead of wb_terms for properties
Moving to to verify as T201831 covers the deployment of this.
Of course this can't be verified until it is deployed somewhere..
Change 484245 had a related patch set uploaded (by Addshore; owner: Addshore):
[operations/mediawiki-config@master] Introduce wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter
Change 484247 had a related patch set uploaded (by Addshore; owner: Addshore):
[operations/mediawiki-config@master] wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter 3000
Change 484248 had a related patch set uploaded (by Addshore; owner: Addshore):
[operations/mediawiki-config@master] wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter fully on
Change 484245 merged by jenkins-bot:
[operations/mediawiki-config@master] Introduce wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter
Mentioned in SAL (#wikimedia-operations) [2019-01-14T17:08:42Z] <addshore@deploy1001> Synchronized wmf-config/InitialiseSettings.php: T201831 T201838 Introduce wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter PT 1/2 (duration: 00m 47s)
Mentioned in SAL (#wikimedia-operations) [2019-01-14T17:09:44Z] <addshore@deploy1001> Synchronized wmf-config/Wikibase.php: T201831 T201838 Introduce wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter PT 2/2 (duration: 00m 45s)
Change 484247 merged by jenkins-bot:
[operations/mediawiki-config@master] wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter 3000
Mentioned in SAL (#wikimedia-operations) [2019-01-14T17:11:45Z] <addshore@deploy1001> sync-file aborted: T201831 T201838 wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter 3000 (duration: 00m 01s)
Mentioned in SAL (#wikimedia-operations) [2019-01-14T17:13:05Z] <addshore@deploy1001> Synchronized wmf-config/InitialiseSettings.php: T201831 T201838 wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter 3000 (duration: 00m 46s)
Change 484248 merged by jenkins-bot:
[operations/mediawiki-config@master] wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter fully on
Mentioned in SAL (#wikimedia-operations) [2019-01-14T17:21:57Z] <addshore@deploy1001> Synchronized wmf-config/InitialiseSettings.php: T201831 T201838 wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter fully on (duration: 00m 46s)
Change 480551 abandoned by WMDE-leszek:
Beta: use the new link formatter to format P1 on wikidata beta
Change 480550 abandoned by WMDE-leszek:
Added setting to adjust the range of PropertyIDs using new link formatter