Page MenuHomePhabricator
Create Task
Maniphest T201831

Deploy item/property link formatter that uses cache instead of wb_terms DB table
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Start only with using the formatter to display link for Q1, and gradually increase the amount of items covered by the "new" formatter.

Current plan

Details

SubjectRepoBranchLines +/-
wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter fully onoperations/mediawiki-configmaster+1 -1
wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter 3000operations/mediawiki-configmaster+1 -1
Introduce wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatteroperations/mediawiki-configmaster+11 -1
FormatterCache, wrap in hash cachemediawiki/extensions/Wikibasemaster+21 -2
Record cache misses for "FormatterCache"mediawiki/extensions/Wikibasemaster+185 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-leszek created this task.Aug 13 2018, 1:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2018, 1:39 PM
WMDE-leszek renamed this task from Deploy item/property link formatter that uses to Deploy item/property link formatter that uses cache instead of wb_terms DB table.Aug 13 2018, 1:39 PM
WMDE-leszek updated the task description. (Show Details)Aug 13 2018, 1:45 PM
WMDE-leszek updated the task description. (Show Details)Aug 15 2018, 7:28 AM

everything pushed a week forward as no deployments in the week of 2018-08-15...

WMDE-leszek updated the task description. (Show Details)Aug 22 2018, 7:26 AM
WMDE-leszek updated the task description. (Show Details)Aug 24 2018, 11:41 AM
WMDE-leszek updated the task description. (Show Details)Aug 24 2018, 12:31 PM
WMDE-leszek updated the task description. (Show Details)Aug 24 2018, 12:35 PM
WMDE-leszek updated the task description. (Show Details)Aug 26 2018, 11:16 AM
WMDE-leszek closed subtask T201835: Use link formatter that uses cache instead of wb_terms for items Q1-Q100.000 as Resolved.Sep 7 2018, 3:08 PM
WMDE-leszek closed subtask T201833: Use link formatter that uses cache instead of wb_terms for items Q1-Q100 as Resolved.Sep 7 2018, 3:12 PM
WMDE-leszek closed subtask T201834: Use link formatter that uses cache instead of wb_terms for items Q1-Q10.000 as Resolved.
WMDE-leszek closed subtask T201832: Use link formatter that uses cache instead of wb_terms for item Q1 as Resolved.
Lucas_Werkmeister_WMDE mentioned this in T205556: Missing labels on items (statements show item IDs instead of labels even though labels are defined).Sep 26 2018, 4:26 PM
Addshore triaged this task as Low priority.Oct 16 2018, 12:53 PM
Addshore added a project: Wikidata-Campsite.
Addshore moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.
Addshore moved this task from incoming to in progress on the Wikidata board.
Addshore added a subtask: T201930: Track entity page performance.Oct 16 2018, 1:31 PM
Addshore added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Oct 16 2018, 1:35 PM
Addshore set the point value for this task to 1.
Addshore moved this task from Ready to estimate to In Progress on the Wikidata-Campsite board.Oct 16 2018, 1:38 PM
Addshore removed a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Nov 1 2018, 11:14 AM
Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.Nov 1 2018, 11:17 AM
Addshore claimed this task.Nov 12 2018, 5:43 PM
Addshore moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Addshore subscribed.

@WMDE-leszek im going to claim this and slowly work on it with you.

Per T201930#4712029 I think you need to upload some numbers first though to make sure things are okay?

Restricted Application added a project: User-Addshore. · View Herald TranscriptNov 12 2018, 5:43 PM
Addshore updated the task description. (Show Details)Nov 12 2018, 5:43 PM
gerritbot subscribed.Nov 14 2018, 9:39 PM

Change 473626 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] Record cache misses for "FormatterCache"

https://gerrit.wikimedia.org/r/473626

gerritbot added a project: Patch-For-Review.Nov 14 2018, 9:39 PM
gerritbot added a comment.Nov 15 2018, 8:56 AM

Change 473695 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] FormatterCache, wrap in hash cache

https://gerrit.wikimedia.org/r/473695

gerritbot added a comment.Nov 15 2018, 9:07 AM

Change 473626 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Record cache misses for "FormatterCache"

https://gerrit.wikimedia.org/r/473626

gerritbot added a comment.Nov 15 2018, 11:34 AM

Change 473695 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FormatterCache, wrap in hash cache

https://gerrit.wikimedia.org/r/473695

Addshore removed Addshore as the assignee of this task.Dec 18 2018, 10:35 AM
Addshore moved this task from Doing to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Addshore closed subtask T201837: Use link formatter that uses cache instead of wb_terms for all wikidatawiki items as Resolved.Dec 20 2018, 11:22 AM
Lydia_Pintscher subscribed.Jan 3 2019, 11:33 AM

Is this still waiting on @WMDE-leszek uploading numbers or something else?

Addshore added a comment.Jan 3 2019, 11:35 AM
In T201831#4851663, @Lydia_Pintscher wrote:

Is this still waiting on @WMDE-leszek uploading numbers or something else?

Nope not really.

T201930 was merged today and after that is deployed and we make 1 more dashboard we can close that ticket.

This ticket is now just blocked on T201838 being reviewed and merged and deployed.

Addshore mentioned this in T201838: Use link formatter that uses cache instead of wb_terms for all wikidatawiki properties.Jan 9 2019, 12:29 AM

This is now just waiting for T201838 to be deployed which will be happening this week.
Then we can move it back to TODO :)

Addshore moved this task from Stalled/Waiting to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 11 2019, 11:09 AM
Addshore closed subtask T201930: Track entity page performance as Resolved.Jan 14 2019, 10:05 AM
Addshore claimed this task.Jan 14 2019, 10:09 AM
Addshore moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Jan 14 2019, 3:54 PM

Change 484245 had a related patch set uploaded (by Addshore; owner: Addshore):
[operations/mediawiki-config@master] Introduce wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter

https://gerrit.wikimedia.org/r/484245

gerritbot added a comment.Jan 14 2019, 3:57 PM

Change 484247 had a related patch set uploaded (by Addshore; owner: Addshore):
[operations/mediawiki-config@master] wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter 3000

https://gerrit.wikimedia.org/r/484247

gerritbot added a comment.Jan 14 2019, 3:58 PM

Change 484248 had a related patch set uploaded (by Addshore; owner: Addshore):
[operations/mediawiki-config@master] wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter fully on

https://gerrit.wikimedia.org/r/484248

Addshore updated the task description. (Show Details)Jan 14 2019, 3:59 PM
gerritbot added a comment.Jan 14 2019, 5:06 PM

Change 484245 merged by jenkins-bot:
[operations/mediawiki-config@master] Introduce wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter

https://gerrit.wikimedia.org/r/484245

Stashbot subscribed.Jan 14 2019, 5:08 PM

Mentioned in SAL (#wikimedia-operations) [2019-01-14T17:08:42Z] <addshore@deploy1001> Synchronized wmf-config/InitialiseSettings.php: T201831 T201838 Introduce wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter PT 1/2 (duration: 00m 47s)

Stashbot added a comment.Jan 14 2019, 5:09 PM

Mentioned in SAL (#wikimedia-operations) [2019-01-14T17:09:44Z] <addshore@deploy1001> Synchronized wmf-config/Wikibase.php: T201831 T201838 Introduce wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter PT 2/2 (duration: 00m 45s)

gerritbot added a comment.Jan 14 2019, 5:11 PM

Change 484247 merged by jenkins-bot:
[operations/mediawiki-config@master] wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter 3000

https://gerrit.wikimedia.org/r/484247

Stashbot added a comment.Jan 14 2019, 5:11 PM

Mentioned in SAL (#wikimedia-operations) [2019-01-14T17:11:45Z] <addshore@deploy1001> sync-file aborted: T201831 T201838 wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter 3000 (duration: 00m 01s)

Stashbot added a comment.Jan 14 2019, 5:13 PM

Mentioned in SAL (#wikimedia-operations) [2019-01-14T17:13:05Z] <addshore@deploy1001> Synchronized wmf-config/InitialiseSettings.php: T201831 T201838 wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter 3000 (duration: 00m 46s)

gerritbot added a comment.Jan 14 2019, 5:21 PM

Change 484248 merged by jenkins-bot:
[operations/mediawiki-config@master] wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter fully on

https://gerrit.wikimedia.org/r/484248

Stashbot added a comment.Jan 14 2019, 5:21 PM

Mentioned in SAL (#wikimedia-operations) [2019-01-14T17:21:57Z] <addshore@deploy1001> Synchronized wmf-config/InitialiseSettings.php: T201831 T201838 wmgWikibaseMaxItemIdForNewPropertyIdHtmlFormatter fully on (duration: 00m 46s)

Addshore closed this task as Resolved.Jan 15 2019, 8:47 AM
Addshore moved this task from Doing to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Addshore updated the task description. (Show Details)
Addshore closed subtask T201838: Use link formatter that uses cache instead of wb_terms for all wikidatawiki properties as Resolved.Jan 15 2019, 9:21 AM
Liuxinyu970226 moved this task from Tag to Transition completed / Archived on the Tracking-Neverending board.Feb 7 2019, 3:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL