Maniphest T201885

Lexeme RDF export has labels repeated several times
Closed, ResolvedPublic
Actions

Description

Looking at https://www.wikidata.org/wiki/Special:EntityData/L1.ttl?flavor=dump I notice:

wd:L1 a ontolex:LexicalEntry ;
	rdfs:label "ama"@mis-x-Q36790 ;
	skos:prefLabel "ama"@mis-x-Q36790 ;
	schema:name "ama"@mis-x-Q36790 ;
	wikibase:lemma "ama"@mis-x-Q36790 ;
	rdfs:label "𒂼"@mis-x-Q401 ;
	skos:prefLabel "𒂼"@mis-x-Q401 ;
	schema:name "𒂼"@mis-x-Q401 ;
	wikibase:lemma "𒂼"@mis-x-Q401 ;
	dct:language wd:Q36790 ;
	wikibase:lexicalCategory wd:Q1084 ;
	a ontolex:LexicalEntry ;
	rdfs:label "ama"@mis-x-Q36790 ;
	skos:prefLabel "ama"@mis-x-Q36790 ;
	schema:name "ama"@mis-x-Q36790 ;
	wikibase:lemma "ama"@mis-x-Q36790 ;
	rdfs:label "𒂼"@mis-x-Q401 ;
	skos:prefLabel "𒂼"@mis-x-Q401 ;
	schema:name "𒂼"@mis-x-Q401 ;
	wikibase:lemma "𒂼"@mis-x-Q401 ;
	dct:language wd:Q36790 ;
	wikibase:lexicalCategory wd:Q1084 ;
	a ontolex:LexicalEntry ;
	rdfs:label "ama"@mis-x-Q36790 ;
	skos:prefLabel "ama"@mis-x-Q36790 ;
	schema:name "ama"@mis-x-Q36790 ;
	wikibase:lemma "ama"@mis-x-Q36790 ;
	rdfs:label "𒂼"@mis-x-Q401 ;
	skos:prefLabel "𒂼"@mis-x-Q401 ;
	schema:name "𒂼"@mis-x-Q401 ;
	wikibase:lemma "𒂼"@mis-x-Q401 ;
	dct:language wd:Q36790 ;
	wikibase:lexicalCategory wd:Q1084 .

Easy to see that the information is repeated 3 times. Should be only once.

Details

	Subject	Repo	Branch	Lines +/-
	Split generic and entity builders	mediawiki/extensions/Wikibase	master	+35 -21

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T193645 [Epic] querying for lexicographical data
Resolved	Smalyshev	T160259 [Story] RDF for Lexemes, Forms and Senses
Resolved	Smalyshev	T195043 [Task] Implement RDF serialization for lexemes and forms
Resolved	Smalyshev	T201885 Lexeme RDF export has labels repeated several times

Event Timeline

Smalyshev created this task.Aug 13 2018, 11:35 PM

Smalyshev moved this task from Incoming to SDAW on the Wikidata-Query-Service board.Aug 20 2018, 5:02 PM

Smalyshev added a parent task: T193645: [Epic] querying for lexicographical data.Aug 21 2018, 9:16 PM

Smalyshev added a parent task: T195043: [Task] Implement RDF serialization for lexemes and forms.

Looks like $this->builders is not initialized correctly in RdfBuilder - LexemeRdfBuilder appears three times in that array. I'm not even sure why entity RDF builders and sub-entity builders like TermsRdfBuilder are stored in the same array under different keys...

Change 455251 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[mediawiki/extensions/Wikibase@master] Split generic and entity builders

https://gerrit.wikimedia.org/r/455251

gerritbot added a project: Patch-For-Review.Aug 24 2018, 10:04 PM

Smalyshev added a subscriber: Ladsgroup.Aug 24 2018, 10:50 PM

Lydia_Pintscher removed a parent task: T193645: [Epic] querying for lexicographical data.Aug 26 2018, 11:11 AM

Lydia_Pintscher moved this task from incoming to features/bugs for next release (querying and searching) on the Wikidata Lexicographical data board.Sep 1 2018, 6:56 PM

Change 455251 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Split generic and entity builders

https://gerrit.wikimedia.org/r/455251

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)).Sep 3 2018, 1:00 PM

Smalyshev closed this task as Resolved.Sep 20 2018, 11:36 PM

Smalyshev claimed this task.

Smalyshev triaged this task as Medium priority.